Re: [PATCH] soc: fsl: qbman: Fix return value on success

2020-09-22 Thread Li Yang 
On Sun, Sep 20, 2020 at 3:27 PM Krzysztof Kozlowski  wrote:
>
> On error the function was meant to return -ERRNO.  This also fixes
> compile warning:
>
>   drivers/soc/fsl/qbman/bman.c:640:6: warning: variable 'err' set but not 
> used [-Wunused-but-set-variable]
>
> Fixes: 0505d00c8dba ("soc/fsl/qbman: Cleanup buffer pools if BMan was 
> initialized prior to bootup")
> Signed-off-by: Krzysztof Kozlowski 

Applied for next.  Thanks.

> ---
>  drivers/soc/fsl/qbman/bman.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/fsl/qbman/bman.c b/drivers/soc/fsl/qbman/bman.c
> index f4fb527d8301..c5dd026fe889 100644
> --- a/drivers/soc/fsl/qbman/bman.c
> +++ b/drivers/soc/fsl/qbman/bman.c
> @@ -660,7 +660,7 @@ int bm_shutdown_pool(u32 bpid)
> }
>  done:
> put_affine_portal();
> -   return 0;
> +   return err;
>  }
>
>  struct gen_pool *bm_bpalloc;
> --
> 2.17.1
>

[PATCH] soc: fsl: qbman: Fix return value on success

2020-09-20 Thread Krzysztof Kozlowski 
On error the function was meant to return -ERRNO.  This also fixes
compile warning:

  drivers/soc/fsl/qbman/bman.c:640:6: warning: variable 'err' set but not used 
[-Wunused-but-set-variable]

Fixes: 0505d00c8dba ("soc/fsl/qbman: Cleanup buffer pools if BMan was 
initialized prior to bootup")
Signed-off-by: Krzysztof Kozlowski 
---
 drivers/soc/fsl/qbman/bman.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/fsl/qbman/bman.c b/drivers/soc/fsl/qbman/bman.c
index f4fb527d8301..c5dd026fe889 100644
--- a/drivers/soc/fsl/qbman/bman.c
+++ b/drivers/soc/fsl/qbman/bman.c
@@ -660,7 +660,7 @@ int bm_shutdown_pool(u32 bpid)
}
 done:
put_affine_portal();
-   return 0;
+   return err;
 }
 
 struct gen_pool *bm_bpalloc;
-- 
2.17.1