Re: [PATCH] tools/perf/powerpc: Fix build break

2014-10-08 Thread Aneesh Kumar K.V 
Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com writes:

   CC   arch/powerpc/util/skip-callchain-idx.o
 arch/powerpc/util/skip-callchain-idx.c: In function ‘check_return_reg’:
 arch/powerpc/util/skip-callchain-idx.c:55:3: error: implicit declaration of 
 function ‘pr_debug’ [-Werror=implicit-function-declaration]
pr_debug(dwarf_frame_register() %s\n, dwarf_errmsg(-1));

 Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com
 ---
  tools/perf/arch/powerpc/util/skip-callchain-idx.c | 1 +
  1 file changed, 1 insertion(+)

 diff --git a/tools/perf/arch/powerpc/util/skip-callchain-idx.c 
 b/tools/perf/arch/powerpc/util/skip-callchain-idx.c
 index a7c23a4b3778..d73ef8bb08c7 100644
 --- a/tools/perf/arch/powerpc/util/skip-callchain-idx.c
 +++ b/tools/perf/arch/powerpc/util/skip-callchain-idx.c
 @@ -15,6 +15,7 @@

  #include util/thread.h
  #include util/callchain.h
 +#include util/debug.h

  /*
   * When saving the callchain on Power, the kernel conservatively saves

We still have this broken upstream.

-aneesh

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] tools/perf/powerpc: Fix build break

2014-10-08 Thread Sukadev Bhattiprolu 
Aneesh Kumar K.V [aneesh.ku...@linux.vnet.ibm.com] wrote:
| Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com writes:
| 
|CC   arch/powerpc/util/skip-callchain-idx.o
|  arch/powerpc/util/skip-callchain-idx.c: In function ‘check_return_reg’:
|  arch/powerpc/util/skip-callchain-idx.c:55:3: error: implicit declaration of 
function ‘pr_debug’ [-Werror=implicit-function-declaration]
| pr_debug(dwarf_frame_register() %s\n, dwarf_errmsg(-1));
| 
|  Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com
|  ---
|   tools/perf/arch/powerpc/util/skip-callchain-idx.c | 1 +
|   1 file changed, 1 insertion(+)
| 
|  diff --git a/tools/perf/arch/powerpc/util/skip-callchain-idx.c 
b/tools/perf/arch/powerpc/util/skip-callchain-idx.c
|  index a7c23a4b3778..d73ef8bb08c7 100644
|  --- a/tools/perf/arch/powerpc/util/skip-callchain-idx.c
|  +++ b/tools/perf/arch/powerpc/util/skip-callchain-idx.c
|  @@ -15,6 +15,7 @@
| 
|   #include util/thread.h
|   #include util/callchain.h
|  +#include util/debug.h
| 
|   /*
|* When saving the callchain on Power, the kernel conservatively saves
| 
| We still have this broken upstream.

The fix is in Ingo's tree, commit ad7e767.

Ingo, can you push this fix to Linus - it fixes a build failure in
Powerpc.

Sukadev


| 
| -aneesh
| 
| ___
| Linuxppc-dev mailing list
| Linuxppc-dev@lists.ozlabs.org
| https://lists.ozlabs.org/listinfo/linuxppc-dev

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] tools/perf/powerpc: Fix build break

2014-08-18 Thread Sukadev Bhattiprolu 
I posted a patch for this to LKML last week:

https://lkml.org/lkml/2014/8/7/77

Aneesh Kumar K.V [aneesh.ku...@linux.vnet.ibm.com] wrote:
|   CC   arch/powerpc/util/skip-callchain-idx.o
| arch/powerpc/util/skip-callchain-idx.c: In function ‘check_return_reg’:
| arch/powerpc/util/skip-callchain-idx.c:55:3: error: implicit declaration of 
function ‘pr_debug’ [-Werror=implicit-function-declaration]
|pr_debug(dwarf_frame_register() %s\n, dwarf_errmsg(-1));
| 
| Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com
| ---
|  tools/perf/arch/powerpc/util/skip-callchain-idx.c | 1 +
|  1 file changed, 1 insertion(+)
| 
| diff --git a/tools/perf/arch/powerpc/util/skip-callchain-idx.c 
b/tools/perf/arch/powerpc/util/skip-callchain-idx.c
| index a7c23a4b3778..d73ef8bb08c7 100644
| --- a/tools/perf/arch/powerpc/util/skip-callchain-idx.c
| +++ b/tools/perf/arch/powerpc/util/skip-callchain-idx.c
| @@ -15,6 +15,7 @@
|  
|  #include util/thread.h
|  #include util/callchain.h
| +#include util/debug.h
|  
|  /*
|   * When saving the callchain on Power, the kernel conservatively saves
| -- 
| 1.9.1
| 
| ___
| Linuxppc-dev mailing list
| Linuxppc-dev@lists.ozlabs.org
| https://lists.ozlabs.org/listinfo/linuxppc-dev

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH] tools/perf/powerpc: Fix build break

2014-08-14 Thread Aneesh Kumar K.V 
  CC   arch/powerpc/util/skip-callchain-idx.o
arch/powerpc/util/skip-callchain-idx.c: In function ‘check_return_reg’:
arch/powerpc/util/skip-callchain-idx.c:55:3: error: implicit declaration of 
function ‘pr_debug’ [-Werror=implicit-function-declaration]
   pr_debug(dwarf_frame_register() %s\n, dwarf_errmsg(-1));

Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com
---
 tools/perf/arch/powerpc/util/skip-callchain-idx.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/perf/arch/powerpc/util/skip-callchain-idx.c 
b/tools/perf/arch/powerpc/util/skip-callchain-idx.c
index a7c23a4b3778..d73ef8bb08c7 100644
--- a/tools/perf/arch/powerpc/util/skip-callchain-idx.c
+++ b/tools/perf/arch/powerpc/util/skip-callchain-idx.c
@@ -15,6 +15,7 @@
 
 #include util/thread.h
 #include util/callchain.h
+#include util/debug.h
 
 /*
  * When saving the callchain on Power, the kernel conservatively saves
-- 
1.9.1

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev