RE: [PATCH] usb: gadget: fsl: properly remove remnant of MXC support

2021-06-14 Thread Leo Li


> -Original Message-
> From: Joel Stanley 
> Sent: Monday, June 14, 2021 8:52 PM
> To: Leo Li 
> Cc: Felipe Balbi ; Greg Kroah-Hartman
> ; linux-...@vger.kernel.org; linuxppc-dev
> ; Linux Kernel Mailing List  ker...@vger.kernel.org>; Arnd Bergmann ; Ran Wang
> ; Fabio Estevam 
> Subject: Re: [PATCH] usb: gadget: fsl: properly remove remnant of MXC
> support
> 
> On Sat, 12 Jun 2021 at 00:31, Li Yang  wrote:
> >
> > Commit a390bef7db1f ("usb: gadget: fsl_mxc_udc: Remove the driver")
> > didn't remove all the MXC related stuff which can cause build problem
> > for LS1021 when enabled again in Kconfig.  This patch remove all the
> > remnants.
> >
> > Signed-off-by: Li Yang 
> 
> Reviewed-by: Joel Stanley 
> 
> Will you re-submit the kconfig change once this is merged?

I think that we can re-use your previous patch.

Hi Greg,

Can you apply the reverted Kconfig patch again?  Or do you prefer us to 
re-submit it again?

Regards,
Leo


Re: [PATCH] usb: gadget: fsl: properly remove remnant of MXC support

2021-06-14 Thread Joel Stanley
On Sat, 12 Jun 2021 at 00:31, Li Yang  wrote:
>
> Commit a390bef7db1f ("usb: gadget: fsl_mxc_udc: Remove the driver")
> didn't remove all the MXC related stuff which can cause build problem
> for LS1021 when enabled again in Kconfig.  This patch remove all the
> remnants.
>
> Signed-off-by: Li Yang 

Reviewed-by: Joel Stanley 

Will you re-submit the kconfig change once this is merged?

Cheers,

Joel


Re: [PATCH] usb: gadget: fsl: properly remove remnant of MXC support

2021-06-12 Thread Fabio Estevam
Hi Li,

On Fri, Jun 11, 2021 at 9:31 PM Li Yang  wrote:
>
> Commit a390bef7db1f ("usb: gadget: fsl_mxc_udc: Remove the driver")
> didn't remove all the MXC related stuff which can cause build problem
> for LS1021 when enabled again in Kconfig.  This patch remove all the
> remnants.
>
> Signed-off-by: Li Yang 

Thanks for the fix:

Reviewed-by: Fabio Estevam 


Re: [PATCH] usb: gadget: fsl: properly remove remnant of MXC support

2021-06-12 Thread Arnd Bergmann
On Sat, Jun 12, 2021 at 2:31 AM Li Yang  wrote:
>
> Commit a390bef7db1f ("usb: gadget: fsl_mxc_udc: Remove the driver")
> didn't remove all the MXC related stuff which can cause build problem
> for LS1021 when enabled again in Kconfig.  This patch remove all the
> remnants.
>
> Signed-off-by: Li Yang 

Looks good to me,

Acked-by: Arnd Bergmann 


[PATCH] usb: gadget: fsl: properly remove remnant of MXC support

2021-06-11 Thread Li Yang
Commit a390bef7db1f ("usb: gadget: fsl_mxc_udc: Remove the driver")
didn't remove all the MXC related stuff which can cause build problem
for LS1021 when enabled again in Kconfig.  This patch remove all the
remnants.

Signed-off-by: Li Yang 
---
 drivers/usb/gadget/udc/fsl_udc_core.c | 36 +--
 drivers/usb/gadget/udc/fsl_usb2_udc.h | 19 --
 2 files changed, 6 insertions(+), 49 deletions(-)

diff --git a/drivers/usb/gadget/udc/fsl_udc_core.c 
b/drivers/usb/gadget/udc/fsl_udc_core.c
index 2b357b3f64c0..29fcb9b461d7 100644
--- a/drivers/usb/gadget/udc/fsl_udc_core.c
+++ b/drivers/usb/gadget/udc/fsl_udc_core.c
@@ -36,7 +36,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 
 #include 
@@ -323,13 +322,11 @@ static int dr_controller_setup(struct fsl_udc *udc)
fsl_writel(tmp, _regs->endptctrl[ep_num]);
}
/* Config control enable i/o output, cpu endian register */
-#ifndef CONFIG_ARCH_MXC
if (udc->pdata->have_sysif_regs) {
ctrl = __raw_readl(_sys_regs->control);
ctrl |= USB_CTRL_IOENB;
__raw_writel(ctrl, _sys_regs->control);
}
-#endif
 
 #if defined(CONFIG_PPC32) && !defined(CONFIG_NOT_COHERENT_CACHE)
/* Turn on cache snooping hardware, since some PowerPC platforms
@@ -2153,7 +2150,6 @@ static int fsl_proc_read(struct seq_file *m, void *v)
tmp_reg = fsl_readl(_regs->endpointprime);
seq_printf(m, "EP Prime Reg = [0x%x]\n\n", tmp_reg);
 
-#ifndef CONFIG_ARCH_MXC
if (udc->pdata->have_sysif_regs) {
tmp_reg = usb_sys_regs->snoop1;
seq_printf(m, "Snoop1 Reg : = [0x%x]\n\n", tmp_reg);
@@ -2161,7 +2157,6 @@ static int fsl_proc_read(struct seq_file *m, void *v)
tmp_reg = usb_sys_regs->control;
seq_printf(m, "General Control Reg : = [0x%x]\n\n", tmp_reg);
}
-#endif
 
/* --fsl_udc, fsl_ep, fsl_request structure information - */
ep = >eps[0];
@@ -2412,28 +2407,21 @@ static int fsl_udc_probe(struct platform_device *pdev)
 */
if (pdata->init && pdata->init(pdev)) {
ret = -ENODEV;
-   goto err_iounmap_noclk;
+   goto err_iounmap;
}
 
/* Set accessors only after pdata->init() ! */
fsl_set_accessors(pdata);
 
-#ifndef CONFIG_ARCH_MXC
if (pdata->have_sysif_regs)
usb_sys_regs = (void *)dr_regs + USB_DR_SYS_OFFSET;
-#endif
-
-   /* Initialize USB clocks */
-   ret = fsl_udc_clk_init(pdev);
-   if (ret < 0)
-   goto err_iounmap_noclk;
 
/* Read Device Controller Capability Parameters register */
dccparams = fsl_readl(_regs->dccparams);
if (!(dccparams & DCCPARAMS_DC)) {
ERR("This SOC doesn't support device role\n");
ret = -ENODEV;
-   goto err_iounmap;
+   goto err_exit;
}
/* Get max device endpoints */
/* DEN is bidirectional ep number, max_ep doubles the number */
@@ -2442,7 +2430,7 @@ static int fsl_udc_probe(struct platform_device *pdev)
ret = platform_get_irq(pdev, 0);
if (ret <= 0) {
ret = ret ? : -ENODEV;
-   goto err_iounmap;
+   goto err_exit;
}
udc_controller->irq = ret;
 
@@ -2451,7 +2439,7 @@ static int fsl_udc_probe(struct platform_device *pdev)
if (ret != 0) {
ERR("cannot request irq %d err %d\n",
udc_controller->irq, ret);
-   goto err_iounmap;
+   goto err_exit;
}
 
/* Initialize the udc structure including QH member and other member */
@@ -2467,10 +2455,6 @@ static int fsl_udc_probe(struct platform_device *pdev)
dr_controller_setup(udc_controller);
}
 
-   ret = fsl_udc_clk_finalize(pdev);
-   if (ret)
-   goto err_free_irq;
-
/* Setup gadget structure */
udc_controller->gadget.ops = _gadget_ops;
udc_controller->gadget.max_speed = USB_SPEED_HIGH;
@@ -2530,11 +2514,10 @@ static int fsl_udc_probe(struct platform_device *pdev)
dma_pool_destroy(udc_controller->td_pool);
 err_free_irq:
free_irq(udc_controller->irq, udc_controller);
-err_iounmap:
+err_exit:
if (pdata->exit)
pdata->exit(pdev);
-   fsl_udc_clk_release();
-err_iounmap_noclk:
+err_iounmap:
iounmap(dr_regs);
 err_release_mem_region:
if (pdata->operating_mode == FSL_USB2_DR_DEVICE)
@@ -2561,8 +2544,6 @@ static int fsl_udc_remove(struct platform_device *pdev)
udc_controller->done = 
usb_del_gadget_udc(_controller->gadget);
 
-   fsl_udc_clk_release();
-
/* DR has been stopped in usb_gadget_unregister_driver() */
remove_proc_file();
 
@@ -2677,10 +2658,6 @@ static int fsl_udc_otg_resume(struct device *dev)