Re: [PATCH 0/2 v3] mpc5200 ac97 gpio reset
On Thu, Aug 5, 2010 at 6:59 AM, Eric Millbrandt emillbra...@dekaresearch.com wrote: -Original Message- From: linuxppc-dev-bounces+emillbrandt=dekaresearch@lists.ozlabs.org [mailto:linuxppc-dev- bounces+emillbrandt=dekaresearch@lists.ozlabs.org] On Behalf Of Mark Brown Sent: Tuesday, August 03, 2010 01:52 To: Grant Likely Cc: linuxppc-dev@lists.ozlabs.org; Eric Millbrandt Subject: Re: [PATCH 0/2 v3] mpc5200 ac97 gpio reset On Sat, Jul 31, 2010 at 10:42:15PM -0600, Grant Likely wrote: On Sun, Jun 27, 2010 at 4:01 PM, Mark Brown I'm a little concerned with a collision with multi codec here. It'd be handy if you could keep it separate in case it needs merging into both trees (or we could merge via ASoC only). Hmmm. Yeah, probably better to take it via your tree then. I've currently got patch 1 in linux-next, but I'll drop it before asking benh to pull. Go ahead and add my acked-by. Looks like multi-component is slightly too late for .36 and I don't have the original patch any more since it looked like you were going to be carrying it... could you restore the patch to your tree please? ping Grant, are you going to pick up this series for .36? Yes, working on it... :-) g. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
RE: [PATCH 0/2 v3] mpc5200 ac97 gpio reset
-Original Message- From: linuxppc-dev-bounces+emillbrandt=dekaresearch@lists.ozlabs.org [mailto:linuxppc-dev- bounces+emillbrandt=dekaresearch@lists.ozlabs.org] On Behalf Of Mark Brown Sent: Tuesday, August 03, 2010 01:52 To: Grant Likely Cc: linuxppc-dev@lists.ozlabs.org; Eric Millbrandt Subject: Re: [PATCH 0/2 v3] mpc5200 ac97 gpio reset On Sat, Jul 31, 2010 at 10:42:15PM -0600, Grant Likely wrote: On Sun, Jun 27, 2010 at 4:01 PM, Mark Brown I'm a little concerned with a collision with multi codec here. It'd be handy if you could keep it separate in case it needs merging into both trees (or we could merge via ASoC only). Hmmm. Yeah, probably better to take it via your tree then. I've currently got patch 1 in linux-next, but I'll drop it before asking benh to pull. Go ahead and add my acked-by. Looks like multi-component is slightly too late for .36 and I don't have the original patch any more since it looked like you were going to be carrying it... could you restore the patch to your tree please? ping Grant, are you going to pick up this series for .36? Eric -DISCLAIMER: an automatically appended disclaimer may follow. By posting- -to a public e-mail mailing list I hereby grant permission to distribute- -and copy this message.- This e-mail and the information, including any attachments, it contains are intended to be a confidential communication only to the person or entity to whom it is addressed and may contain information that is privileged. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please immediately notify the sender and destroy the original message. Thank you. Please consider the environment before printing this email. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 0/2 v3] mpc5200 ac97 gpio reset
On Sat, Jul 31, 2010 at 10:42:15PM -0600, Grant Likely wrote: On Sun, Jun 27, 2010 at 4:01 PM, Mark Brown I'm a little concerned with a collision with multi codec here. It'd be handy if you could keep it separate in case it needs merging into both trees (or we could merge via ASoC only). Hmmm. Yeah, probably better to take it via your tree then. I've currently got patch 1 in linux-next, but I'll drop it before asking benh to pull. Go ahead and add my acked-by. Looks like multi-component is slightly too late for .36 and I don't have the original patch any more since it looked like you were going to be carrying it... could you restore the patch to your tree please? ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 0/2 v3] mpc5200 ac97 gpio reset
On Sun, Jun 27, 2010 at 4:01 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On 26 Jun 2010, at 00:04, Grant Likely grant.lik...@secretlab.ca wrote: On Tue, Jun 22, 2010 at 5:00 PM, Mark Brown On Tue, Jun 15, 2010 at 12:05:05PM -0400, Eric Millbrandt wrote: These patches reimplement the reset fuction in the ac97 to use gpio pins instead of using the mpc5200 ac97 reset functionality in the psc. This avoids a problem in which attached ac97 devices go into test mode appear unresponsive. These patches were tested on a pcm030 baseboard and on custom hardware with a wm9715 audio codec/touchscreen controller. Grant, are you OK with this series? Yes, I'm going to pick it up. I'm a little concerned with a collision with multi codec here. It'd be handy if you could keep it separate in case it needs merging into both trees (or we could merge via ASoC only). Hmmm. Yeah, probably better to take it via your tree then. I've currently got patch 1 in linux-next, but I'll drop it before asking benh to pull. Go ahead and add my acked-by. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 0/2 v3] mpc5200 ac97 gpio reset
On 26 Jun 2010, at 00:04, Grant Likely grant.lik...@secretlab.ca wrote: On Tue, Jun 22, 2010 at 5:00 PM, Mark Brown On Tue, Jun 15, 2010 at 12:05:05PM -0400, Eric Millbrandt wrote: These patches reimplement the reset fuction in the ac97 to use gpio pins instead of using the mpc5200 ac97 reset functionality in the psc. This avoids a problem in which attached ac97 devices go into test mode appear unresponsive. These patches were tested on a pcm030 baseboard and on custom hardware with a wm9715 audio codec/touchscreen controller. Grant, are you OK with this series? Yes, I'm going to pick it up. I'm a little concerned with a collision with multi codec here. It'd be handy if you could keep it separate in case it needs merging into both trees (or we could merge via ASoC only). ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 0/2 v3] mpc5200 ac97 gpio reset
On Tue, Jun 22, 2010 at 5:00 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Tue, Jun 15, 2010 at 12:05:05PM -0400, Eric Millbrandt wrote: These patches reimplement the reset fuction in the ac97 to use gpio pins instead of using the mpc5200 ac97 reset functionality in the psc. This avoids a problem in which attached ac97 devices go into test mode appear unresponsive. These patches were tested on a pcm030 baseboard and on custom hardware with a wm9715 audio codec/touchscreen controller. Grant, are you OK with this series? Yes, I'm going to pick it up. g. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 0/2 v3] mpc5200 ac97 gpio reset
On Tue, Jun 15, 2010 at 12:05:05PM -0400, Eric Millbrandt wrote: These patches reimplement the reset fuction in the ac97 to use gpio pins instead of using the mpc5200 ac97 reset functionality in the psc. This avoids a problem in which attached ac97 devices go into test mode appear unresponsive. These patches were tested on a pcm030 baseboard and on custom hardware with a wm9715 audio codec/touchscreen controller. Grant, are you OK with this series? ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
[PATCH 0/2 v3] mpc5200 ac97 gpio reset
These patches reimplement the reset fuction in the ac97 to use gpio pins instead of using the mpc5200 ac97 reset functionality in the psc. This avoids a problem in which attached ac97 devices go into test mode appear unresponsive. These patches were tested on a pcm030 baseboard and on custom hardware with a wm9715 audio codec/touchscreen controller. Eric Millbrandt --- changes since v1 - Refactored to manipulate port_config and gpio pins internally instead of exporting an API. - Amended commit message with comments from Mark Brown - Refactored to move the port_config manipulation to platform code. - Remove the gpio pins from the device-tree changes since v2 - Factored out gpiolib calls, write to the gpio registers directly - Remove redundant checks around call to mpc5200_psc_ac97_gpio_reset() Eric Millbrandt (2): powerpc/5200: add mpc5200_psc_ac97_gpio_reset sound/soc: mpc5200_psc_ac97: Use gpio pins for cold reset arch/powerpc/include/asm/mpc52xx.h |1 + arch/powerpc/include/asm/mpc52xx_psc.h |1 + arch/powerpc/platforms/52xx/mpc52xx_common.c | 113 ++ sound/soc/fsl/mpc5200_psc_ac97.c | 22 - 4 files changed, 133 insertions(+), 4 deletions(-) -DISCLAIMER: an automatically appended disclaimer may follow. By posting- -to a public e-mail mailing list I hereby grant permission to distribute- -and copy this message.- This e-mail and the information, including any attachments, it contains are intended to be a confidential communication only to the person or entity to whom it is addressed and may contain information that is privileged. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please immediately notify the sender and destroy the original message. Thank you. Please consider the environment before printing this email. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
