Re: [PATCH 00/17] Implement use of HW assistance on TLB table walk on 8xx
Le 11/05/2018 à 08:48, Michael Ellerman a écrit : Christophe Leroywrites: The purpose of this serie is to implement hardware assistance for TLB table walk on the 8xx. First part is to make L1 entries and L2 entries independant. For that, we need to alter ioremap functions in order to handle GUARD attribute at the PGD/PMD level. Last part is to try and reuse PTE fragment implemented on PPC64 in order to not waste 16k Pages for page tables as only 4k are used. For the time being, it doesn't work, but I include it in the serie anyway in order to get feedback. Tested successfully on 8xx up to the one before the last. Didn't have time to do compilation test on other configs, I send it anyway before leaving for one week vacation in order to get feedback. I replied to a few patches, here's some other build errors: arch/powerpc/mm/ioremap.c:135:15: error: '_PAGE_GUARDED' undeclared (first use in this function): pseries_defconfig/powerpc arch/powerpc/include/asm/book3s/32/pgtable.h:53:19: error: 'PKMAP_BASE' undeclared (first use in this function): pmac32_defconfig/powerpc-5.3 include/linux/mm.h:533:41: error: 'PKMAP_BASE' undeclared (first use in this function): pmac32_defconfig/powerpc ERROR: "ioremap_bot" [net/netfilter/nf_conntrack.ko] undefined!: linkstation_defconfig/powerpc ERROR: "ioremap_bot" [fs/xfs/xfs.ko] undefined!: linkstation_defconfig/powerpc arch/powerpc/include/asm/nohash/32/pgtable.h:80:20: error: 'PKMAP_BASE' undeclared (first use in this function): corenet32_smp_defconfig/powerpc-5.3 arch/powerpc/include/asm/nohash/32/pgalloc.h:64:43: error: '_PMD_GUARDED' undeclared (first use in this function): ppc40x_defconfig/powerpc-5.3 ERROR: "ioremap_bot" [net/packet/af_packet.ko] undefined!: storcenter_defconfig/powerpc ERROR: "ioremap_bot" [drivers/usb/core/usbcore.ko] undefined!: ppc44x_defconfig/powerpc Thanks for testing. I have now fixed all of them in v2. For PKMAP_BASE, I had to move it from asm/highmem.h into the book3s/32/pgtable.h and nohash/32/pgtable.h because including asm/highmem.h in the pgtable.h files was introducing circular dependency. Christophe
Re: [PATCH 00/17] Implement use of HW assistance on TLB table walk on 8xx
Christophe Leroywrites: > The purpose of this serie is to implement hardware assistance for TLB table > walk > on the 8xx. > > First part is to make L1 entries and L2 entries independant. > For that, we need to alter ioremap functions in order to handle GUARD > attribute > at the PGD/PMD level. > > Last part is to try and reuse PTE fragment implemented on PPC64 in order to > not waste 16k Pages for page tables as only 4k are used. For the time being, > it doesn't work, but I include it in the serie anyway in order to get > feedback. > > Tested successfully on 8xx up to the one before the last. > > Didn't have time to do compilation test on other configs, I send it anyway > before leaving for one week vacation in order to get feedback. I replied to a few patches, here's some other build errors: arch/powerpc/mm/ioremap.c:135:15: error: '_PAGE_GUARDED' undeclared (first use in this function): pseries_defconfig/powerpc arch/powerpc/include/asm/book3s/32/pgtable.h:53:19: error: 'PKMAP_BASE' undeclared (first use in this function): pmac32_defconfig/powerpc-5.3 include/linux/mm.h:533:41: error: 'PKMAP_BASE' undeclared (first use in this function): pmac32_defconfig/powerpc ERROR: "ioremap_bot" [net/netfilter/nf_conntrack.ko] undefined!: linkstation_defconfig/powerpc ERROR: "ioremap_bot" [fs/xfs/xfs.ko] undefined!: linkstation_defconfig/powerpc arch/powerpc/include/asm/nohash/32/pgtable.h:80:20: error: 'PKMAP_BASE' undeclared (first use in this function): corenet32_smp_defconfig/powerpc-5.3 arch/powerpc/include/asm/nohash/32/pgalloc.h:64:43: error: '_PMD_GUARDED' undeclared (first use in this function): ppc40x_defconfig/powerpc-5.3 ERROR: "ioremap_bot" [net/packet/af_packet.ko] undefined!: storcenter_defconfig/powerpc ERROR: "ioremap_bot" [drivers/usb/core/usbcore.ko] undefined!: ppc44x_defconfig/powerpc cheers
[PATCH 00/17] Implement use of HW assistance on TLB table walk on 8xx
The purpose of this serie is to implement hardware assistance for TLB table walk on the 8xx. First part is to make L1 entries and L2 entries independant. For that, we need to alter ioremap functions in order to handle GUARD attribute at the PGD/PMD level. Last part is to try and reuse PTE fragment implemented on PPC64 in order to not waste 16k Pages for page tables as only 4k are used. For the time being, it doesn't work, but I include it in the serie anyway in order to get feedback. Tested successfully on 8xx up to the one before the last. Didn't have time to do compilation test on other configs, I send it anyway before leaving for one week vacation in order to get feedback. Christophe Leroy (17): powerpc/nohash: remove hash related code from nohash headers. powerpc/nohash: remove _PAGE_BUSY powerpc/nohash: use IS_ENABLED() to simplify __set_pte_at() Revert "powerpc/8xx: Use L1 entry APG to handle _PAGE_ACCESSED for CONFIG_SWAP" powerpc: move io mapping functions into ioremap.c powerpc: common ioremap functions. powerpc: make ioremap_bot common to PPC32 and PPC64 powerpc: make __iounmap() common to PPC32 and PPC64 powerpc: make __ioremap_caller() common to PPC32 and PPC64 powerpc: use _ALIGN macro powerpc/nohash32: set GUARDED attribute in the PMD directly powerpc/8xx: Remove PTE_ATOMIC_UPDATES powerpc/mm: Use hardware assistance in TLB handlers on the 8xx powerpc/8xx: reunify TLB handler routines powerpc/8xx: Free up SPRN_SPRG_SCRATCH2 powerpc/mm: Make pte_fragment_alloc() common to PPC32 and PPC64 powerpc/mm: Use pte_fragment_alloc() on 8xx (Not Working yet) arch/powerpc/include/asm/book3s/32/pgtable.h | 16 +- arch/powerpc/include/asm/book3s/64/pgtable.h | 2 + arch/powerpc/include/asm/hugetlb.h | 4 +- arch/powerpc/include/asm/machdep.h | 2 +- arch/powerpc/include/asm/mmu-8xx.h | 38 +-- arch/powerpc/include/asm/mmu_context.h | 28 +++ arch/powerpc/include/asm/nohash/32/pgalloc.h | 39 ++- arch/powerpc/include/asm/nohash/32/pgtable.h | 88 +++ arch/powerpc/include/asm/nohash/32/pte-8xx.h | 6 +- arch/powerpc/include/asm/nohash/64/pgtable.h | 26 +- arch/powerpc/include/asm/nohash/pgtable.h| 61 ++--- arch/powerpc/include/asm/nohash/pte-book3e.h | 6 - arch/powerpc/include/asm/pgtable-types.h | 4 + arch/powerpc/kernel/head_8xx.S | 350 ++- arch/powerpc/mm/8xx_mmu.c| 12 +- arch/powerpc/mm/Makefile | 2 +- arch/powerpc/mm/dma-noncoherent.c| 2 +- arch/powerpc/mm/dump_linuxpagetables.c | 32 ++- arch/powerpc/mm/hugetlbpage.c| 12 + arch/powerpc/mm/init_32.c| 6 +- arch/powerpc/mm/ioremap.c| 250 +++ arch/powerpc/mm/mem.c| 16 +- arch/powerpc/mm/mmu_context_book3s64.c | 28 --- arch/powerpc/mm/mmu_context_nohash.c | 4 + arch/powerpc/mm/pgtable.c| 75 ++ arch/powerpc/mm/pgtable_32.c | 167 +++-- arch/powerpc/mm/pgtable_64.c | 244 --- arch/powerpc/platforms/Kconfig.cputype | 9 + 28 files changed, 730 insertions(+), 799 deletions(-) create mode 100644 arch/powerpc/mm/ioremap.c -- 2.13.3