Re: [PATCH 01/16 v3] powerpc: Remove extraneous error reporting for hcall failures in lparcfg

2008-07-21 Thread Paul Mackerras
Robert Jennings writes:

> From: Nathan Fontenot <[EMAIL PROTECTED]>
> 
> Remove the extraneous error reporting used when a hcall made from lparcfg 
> fails.
> 
> Signed-off-by: Nathan Fontenot <[EMAIL PROTECTED]>
> Signed-off-by: Robert Jennings <[EMAIL PROTECTED]>

Acked-by: Paul Mackerras <[EMAIL PROTECTED]>
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev


[PATCH 01/16 v3] powerpc: Remove extraneous error reporting for hcall failures in lparcfg

2008-07-04 Thread Robert Jennings
From: Nathan Fontenot <[EMAIL PROTECTED]>

Remove the extraneous error reporting used when a hcall made from lparcfg fails.

Signed-off-by: Nathan Fontenot <[EMAIL PROTECTED]>
Signed-off-by: Robert Jennings <[EMAIL PROTECTED]>

---
 arch/powerpc/kernel/lparcfg.c |   32 
 1 file changed, 32 deletions(-)

Index: b/arch/powerpc/kernel/lparcfg.c
===
--- a/arch/powerpc/kernel/lparcfg.c
+++ b/arch/powerpc/kernel/lparcfg.c
@@ -129,33 +129,6 @@ static int iseries_lparcfg_data(struct s
 /*
  * Methods used to fetch LPAR data when running on a pSeries platform.
  */
-static void log_plpar_hcall_return(unsigned long rc, char *tag)
-{
-   switch(rc) {
-   case 0:
-   return;
-   case H_HARDWARE:
-   printk(KERN_INFO "plpar-hcall (%s) "
-   "Hardware fault\n", tag);
-   return;
-   case H_FUNCTION:
-   printk(KERN_INFO "plpar-hcall (%s) "
-   "Function not allowed\n", tag);
-   return;
-   case H_AUTHORITY:
-   printk(KERN_INFO "plpar-hcall (%s) "
-   "Not authorized to this function\n", tag);
-   return;
-   case H_PARAMETER:
-   printk(KERN_INFO "plpar-hcall (%s) "
-   "Bad parameter(s)\n",tag);
-   return;
-   default:
-   printk(KERN_INFO "plpar-hcall (%s) "
-   "Unexpected rc(0x%lx)\n", tag, rc);
-   }
-}
-
 /*
  * H_GET_PPP hcall returns info in 4 parms.
  *  entitled_capacity,unallocated_capacity,
@@ -191,8 +164,6 @@ static unsigned int h_get_ppp(unsigned l
*aggregation = retbuf[2];
*resource = retbuf[3];
 
-   log_plpar_hcall_return(rc, "H_GET_PPP");
-
return rc;
 }
 
@@ -205,9 +176,6 @@ static void h_pic(unsigned long *pool_id
 
*pool_idle_time = retbuf[0];
*num_procs = retbuf[1];
-
-   if (rc != H_AUTHORITY)
-   log_plpar_hcall_return(rc, "H_PIC");
 }
 
 #define SPLPAR_CHARACTERISTICS_TOKEN 20
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev