Re: [PATCH 07/13] powerpc/5200: LocalPlus driver: reset BestComm when committing new request
On Tue, Dec 22, 2009 at 12:05 AM, Roman Fietze wrote: > Again, need a description as to 'why?' > Signed-off-by: Roman Fietze > --- > arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c > b/arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c > index 8d8a63a..a7cd585 100644 > --- a/arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c > +++ b/arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c > @@ -398,6 +398,8 @@ int mpc52xx_lpbfifo_submit(struct mpc52xx_lpbfifo_request > *req) > req->buffer_not_done_cnt = 0; > req->pos = 0; > > + bcom_gen_bd_rx_reset(lpbfifo.bcom_rx_task); > + bcom_gen_bd_tx_reset(lpbfifo.bcom_tx_task); > mpc52xx_lpbfifo_kick(req); > spin_unlock_irqrestore(&lpbfifo.lock, flags); > > @@ -456,7 +458,7 @@ mpc52xx_lpbfifo_probe(struct of_device *op, const struct > of_device_id *match) > lpbfifo.bcom_rx_task = bcom_gen_bd_rx_init(4, > res.start + offsetof(struct > mpc52xx_sclpc, fifo_data), > BCOM_INITIATOR_SCLPC, > BCOM_IPR_SCLPC, > - 16*1024*1024); > + 16 * 1024 * 1024); Unrelated change. Please drop. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
[PATCH 07/13] powerpc/5200: LocalPlus driver: reset BestComm when committing new request
Signed-off-by: Roman Fietze --- arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c b/arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c index 8d8a63a..a7cd585 100644 --- a/arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c +++ b/arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c @@ -398,6 +398,8 @@ int mpc52xx_lpbfifo_submit(struct mpc52xx_lpbfifo_request *req) req->buffer_not_done_cnt = 0; req->pos = 0; + bcom_gen_bd_rx_reset(lpbfifo.bcom_rx_task); + bcom_gen_bd_tx_reset(lpbfifo.bcom_tx_task); mpc52xx_lpbfifo_kick(req); spin_unlock_irqrestore(&lpbfifo.lock, flags); @@ -456,7 +458,7 @@ mpc52xx_lpbfifo_probe(struct of_device *op, const struct of_device_id *match) lpbfifo.bcom_rx_task = bcom_gen_bd_rx_init(4, res.start + offsetof(struct mpc52xx_sclpc, fifo_data), BCOM_INITIATOR_SCLPC, BCOM_IPR_SCLPC, - 16*1024*1024); + 16 * 1024 * 1024); if (!lpbfifo.bcom_rx_task) goto err_bcom_rx; -- 1.6.5.5 -- Roman FietzeTelemotive AG Büro Mühlhausen Breitwiesen 73347 Mühlhausen Tel.: +49(0)7335/18493-45http://www.telemotive.de ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
