Re: [PATCH 07/30] memblock: remove _virt from APIs returning virtual address

2018-09-26 Thread Michal Hocko
On Fri 14-09-18 15:10:22, Mike Rapoport wrote:
> The conversion is done using
> 
> sed -i 's@memblock_virt_alloc@memblock_alloc@g' \
>   $(git grep -l memblock_virt_alloc)
> 
> Signed-off-by: Mike Rapoport 

As I've said earlier, I am not entirely thrilled by this change. It is
unnecessary churn. So if nothing else just add a note _why_ you think
this is better.
-- 
Michal Hocko
SUSE Labs


[PATCH 07/30] memblock: remove _virt from APIs returning virtual address

2018-09-14 Thread Mike Rapoport
The conversion is done using

sed -i 's@memblock_virt_alloc@memblock_alloc@g' \
$(git grep -l memblock_virt_alloc)

Signed-off-by: Mike Rapoport 
---
 arch/arm/kernel/setup.c   |  4 ++--
 arch/arm/mach-omap2/omap_hwmod.c  |  6 ++---
 arch/arm64/mm/kasan_init.c|  2 +-
 arch/arm64/mm/numa.c  |  2 +-
 arch/mips/kernel/setup.c  |  2 +-
 arch/powerpc/kernel/pci_32.c  |  2 +-
 arch/powerpc/lib/alloc.c  |  2 +-
 arch/powerpc/mm/mmu_context_nohash.c  |  6 ++---
 arch/powerpc/platforms/powermac/nvram.c   |  2 +-
 arch/powerpc/platforms/powernv/pci-ioda.c |  6 ++---
 arch/powerpc/platforms/ps3/setup.c|  2 +-
 arch/powerpc/sysdev/msi_bitmap.c  |  2 +-
 arch/s390/kernel/setup.c  | 12 +-
 arch/s390/kernel/smp.c|  2 +-
 arch/s390/kernel/topology.c   |  4 ++--
 arch/s390/numa/mode_emu.c |  2 +-
 arch/s390/numa/toptree.c  |  2 +-
 arch/x86/mm/kasan_init_64.c   |  4 ++--
 arch/xtensa/mm/kasan_init.c   |  2 +-
 drivers/clk/ti/clk.c  |  2 +-
 drivers/firmware/memmap.c |  2 +-
 drivers/of/fdt.c  |  2 +-
 drivers/of/unittest.c |  2 +-
 include/linux/bootmem.h   | 38 +++
 init/main.c   |  6 ++---
 kernel/dma/swiotlb.c  |  8 +++
 kernel/power/snapshot.c   |  2 +-
 kernel/printk/printk.c|  4 ++--
 lib/cpumask.c |  2 +-
 mm/hugetlb.c  |  2 +-
 mm/kasan/kasan_init.c |  2 +-
 mm/memblock.c | 26 ++---
 mm/page_alloc.c   |  8 +++
 mm/page_ext.c |  2 +-
 mm/percpu.c   | 28 +++
 mm/sparse-vmemmap.c   |  2 +-
 mm/sparse.c   | 12 +-
 37 files changed, 108 insertions(+), 108 deletions(-)

diff --git a/arch/arm/kernel/setup.c b/arch/arm/kernel/setup.c
index 4c249cb..39e6090 100644
--- a/arch/arm/kernel/setup.c
+++ b/arch/arm/kernel/setup.c
@@ -857,7 +857,7 @@ static void __init request_standard_resources(const struct 
machine_desc *mdesc)
 */
boot_alias_start = phys_to_idmap(start);
if (arm_has_idmap_alias() && boot_alias_start != 
IDMAP_INVALID_ADDR) {
-   res = memblock_virt_alloc(sizeof(*res), 0);
+   res = memblock_alloc(sizeof(*res), 0);
res->name = "System RAM (boot alias)";
res->start = boot_alias_start;
res->end = phys_to_idmap(end);
@@ -865,7 +865,7 @@ static void __init request_standard_resources(const struct 
machine_desc *mdesc)
request_resource(_resource, res);
}
 
-   res = memblock_virt_alloc(sizeof(*res), 0);
+   res = memblock_alloc(sizeof(*res), 0);
res->name  = "System RAM";
res->start = start;
res->end = end;
diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c
index 56a1fe9..1f9b34a 100644
--- a/arch/arm/mach-omap2/omap_hwmod.c
+++ b/arch/arm/mach-omap2/omap_hwmod.c
@@ -726,7 +726,7 @@ static int __init _setup_clkctrl_provider(struct 
device_node *np)
u64 size;
int i;
 
-   provider = memblock_virt_alloc(sizeof(*provider), 0);
+   provider = memblock_alloc(sizeof(*provider), 0);
if (!provider)
return -ENOMEM;
 
@@ -736,12 +736,12 @@ static int __init _setup_clkctrl_provider(struct 
device_node *np)
of_property_count_elems_of_size(np, "reg", sizeof(u32)) / 2;
 
provider->addr =
-   memblock_virt_alloc(sizeof(void *) * provider->num_addrs, 0);
+   memblock_alloc(sizeof(void *) * provider->num_addrs, 0);
if (!provider->addr)
return -ENOMEM;
 
provider->size =
-   memblock_virt_alloc(sizeof(u32) * provider->num_addrs, 0);
+   memblock_alloc(sizeof(u32) * provider->num_addrs, 0);
if (!provider->size)
return -ENOMEM;
 
diff --git a/arch/arm64/mm/kasan_init.c b/arch/arm64/mm/kasan_init.c
index 1214587..2391560 100644
--- a/arch/arm64/mm/kasan_init.c
+++ b/arch/arm64/mm/kasan_init.c
@@ -38,7 +38,7 @@ static pgd_t tmp_pg_dir[PTRS_PER_PGD] __initdata 
__aligned(PGD_SIZE);
 
 static phys_addr_t __init kasan_alloc_zeroed_page(int node)
 {
-   void *p = memblock_virt_alloc_try_nid(PAGE_SIZE, PAGE_SIZE,
+   void *p = memblock_alloc_try_nid(PAGE_SIZE, PAGE_SIZE,
  __pa(MAX_DMA_ADDRESS),