Re: [PATCH 1/2] powerpc/85xx: add ngPIXIS FPGA device tree node to the P1022DS board

2010-10-06 Thread Kumar Gala 

On Sep 9, 2010, at 1:39 PM, Timur Tabi wrote:

 The device tree for Freescale's P1022DS reference board is missing the node
 for the ngPIXIS FPGA.
 
 Signed-off-by: Timur Tabi ti...@freescale.com
 ---
 arch/powerpc/boot/dts/p1022ds.dts |9 +
 1 files changed, 9 insertions(+), 0 deletions(-)
 
 diff --git a/arch/powerpc/boot/dts/p1022ds.dts 
 b/arch/powerpc/boot/dts/p1022ds.dts
 index 8bcb10b..e61b42d 100644
 --- a/arch/powerpc/boot/dts/p1022ds.dts
 +++ b/arch/powerpc/boot/dts/p1022ds.dts
 @@ -148,6 +148,15 @@
   label = reserved-nand;
   };
   };
 +
 + board-cont...@3,0 {
 + #address-cells = 1;
 + #size-cells = 1;

these aren't need if we don't have a child node.

 + compatible = fsl,fpga-pixis;

lets make this fsl,p1022ds-pixis

 + reg = 3 0 0x30;
 + interrupt-parent = mpic;
 + interrupts = 8 8;

what do we think about adding a comment about what this interrupt is for

 + };
   };
 
   s...@fffe0 {
 -- 
 1.7.2.2
 
 
 ___
 Linuxppc-dev mailing list
 Linuxppc-dev@lists.ozlabs.org
 https://lists.ozlabs.org/listinfo/linuxppc-dev


___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH 1/2] powerpc/85xx: add ngPIXIS FPGA device tree node to the P1022DS board

2010-09-09 Thread Timur Tabi 
The device tree for Freescale's P1022DS reference board is missing the node
for the ngPIXIS FPGA.

Signed-off-by: Timur Tabi ti...@freescale.com
---
 arch/powerpc/boot/dts/p1022ds.dts |9 +
 1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/arch/powerpc/boot/dts/p1022ds.dts 
b/arch/powerpc/boot/dts/p1022ds.dts
index 8bcb10b..e61b42d 100644
--- a/arch/powerpc/boot/dts/p1022ds.dts
+++ b/arch/powerpc/boot/dts/p1022ds.dts
@@ -148,6 +148,15 @@
label = reserved-nand;
};
};
+
+   board-cont...@3,0 {
+   #address-cells = 1;
+   #size-cells = 1;
+   compatible = fsl,fpga-pixis;
+   reg = 3 0 0x30;
+   interrupt-parent = mpic;
+   interrupts = 8 8;
+   };
};
 
s...@fffe0 {
-- 
1.7.2.2


___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev