Re: [PATCH 1/3] spi: mpc52xx: Avoid using get_tbl()

[Michael Ellerman]

On Tue, 9 Feb 2021 10:26:21 + (UTC), Christophe Leroy wrote:
> get_tbl() is confusing as it returns the content TBL register
> on PPC32 but the concatenation of TBL and TBU on PPC64.
> 
> Use mftb() instead.
> 
> This will allow the removal of get_tbl() in a following patch.

Applied to powerpc/next.

[1/3] spi: mpc52xx: Avoid using get_tbl()
  https://git.kernel.org/powerpc/c/e10656114d32c659768e7ca8aebaaa6ac6e959ab
[2/3] powerpc/time: Avoid using get_tbl()
  https://git.kernel.org/powerpc/c/55d68df623eb679cc91f61137f14751e7f369662
[3/3] powerpc/time: Remove get_tbl()
  https://git.kernel.org/powerpc/c/132f94f133961d18af615cb3503368e59529e9a8

cheers

Re: [PATCH 1/3] spi: mpc52xx: Avoid using get_tbl()

[Mark Brown]

On Tue, Feb 09, 2021 at 10:26:21AM +, Christophe Leroy wrote:
> get_tbl() is confusing as it returns the content TBL register
> on PPC32 but the concatenation of TBL and TBU on PPC64.
> 
> Use mftb() instead.
> 
> This will allow the removal of get_tbl() in a following patch.

Acked-by: Mark Brown 


signature.asc
Description: PGP signature

[PATCH 1/3] spi: mpc52xx: Avoid using get_tbl()

[Christophe Leroy]

get_tbl() is confusing as it returns the content TBL register
on PPC32 but the concatenation of TBL and TBU on PPC64.

Use mftb() instead.

This will allow the removal of get_tbl() in a following patch.

Signed-off-by: Christophe Leroy 
---
 drivers/spi/spi-mpc52xx.c | 12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/spi/spi-mpc52xx.c b/drivers/spi/spi-mpc52xx.c
index ef2f24420460..e6a30f232370 100644
--- a/drivers/spi/spi-mpc52xx.c
+++ b/drivers/spi/spi-mpc52xx.c
@@ -120,7 +120,7 @@ static void mpc52xx_spi_start_transfer(struct mpc52xx_spi 
*ms)
ms->cs_change = ms->transfer->cs_change;
 
/* Write out the first byte */
-   ms->wcol_tx_timestamp = get_tbl();
+   ms->wcol_tx_timestamp = mftb();
if (ms->tx_buf)
out_8(ms->regs + SPI_DATA, *ms->tx_buf++);
else
@@ -221,8 +221,8 @@ static int mpc52xx_spi_fsmstate_transfer(int irq, struct 
mpc52xx_spi *ms,
 * but it can also be worked around simply by retrying the
 * transfer which is what we do here. */
ms->wcol_count++;
-   ms->wcol_ticks += get_tbl() - ms->wcol_tx_timestamp;
-   ms->wcol_tx_timestamp = get_tbl();
+   ms->wcol_ticks += mftb() - ms->wcol_tx_timestamp;
+   ms->wcol_tx_timestamp = mftb();
data = 0;
if (ms->tx_buf)
data = *(ms->tx_buf - 1);
@@ -247,14 +247,14 @@ static int mpc52xx_spi_fsmstate_transfer(int irq, struct 
mpc52xx_spi *ms,
/* Is the transfer complete? */
ms->len--;
if (ms->len == 0) {
-   ms->timestamp = get_tbl();
+   ms->timestamp = mftb();
ms->timestamp += ms->transfer->delay_usecs * tb_ticks_per_usec;
ms->state = mpc52xx_spi_fsmstate_wait;
return FSM_CONTINUE;
}
 
/* Write out the next byte */
-   ms->wcol_tx_timestamp = get_tbl();
+   ms->wcol_tx_timestamp = mftb();
if (ms->tx_buf)
out_8(ms->regs + SPI_DATA, *ms->tx_buf++);
else
@@ -276,7 +276,7 @@ mpc52xx_spi_fsmstate_wait(int irq, struct mpc52xx_spi *ms, 
u8 status, u8 data)
dev_err(>master->dev, "spurious irq, status=0x%.2x\n",
status);
 
-   if (((int)get_tbl()) - ms->timestamp < 0)
+   if (((int)mftb()) - ms->timestamp < 0)
return FSM_POLL;
 
ms->message->actual_length += ms->transfer->len;
-- 
2.25.0