Re: [PATCH 1/9] powerpc: 83xx: use module_i2c_driver macro

2012-10-16 Thread Kim Phillips 
On Sat, 13 Oct 2012 15:05:42 -0400
Devendra Naga devendra.a...@gmail.com wrote:

 replace the module init and exit calls containing the
 i2c_add_driver and i2c_del_driver with the module_i2c_driver
 macro as it does the same things as the code that is removed
 
 Signed-off-by: Devendra Naga devendra.a...@gmail.com
 ---
 
  Not compile tested,

Tested-by: Kim Phillips kim.phill...@freescale.com

 because i dont have a ppc cross toolchain

fyi, ppc and more cross compilers are available here:

http://kernel.org/pub/tools/crosstool/

Kim

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH 1/9] powerpc: 83xx: use module_i2c_driver macro

2012-10-13 Thread Devendra Naga 
replace the module init and exit calls containing the
i2c_add_driver and i2c_del_driver with the module_i2c_driver
macro as it does the same things as the code that is removed

Signed-off-by: Devendra Naga devendra.a...@gmail.com
---

 Not compile tested, because i dont have a ppc cross toolchain
 arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c |   13 +
 1 files changed, 1 insertions(+), 12 deletions(-)

diff --git a/arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c 
b/arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c
index ef6537b..d27477b 100644
--- a/arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c
+++ b/arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c
@@ -232,18 +232,7 @@ static struct i2c_driver mcu_driver = {
.id_table = mcu_ids,
 };
 
-static int __init mcu_init(void)
-{
-   return i2c_add_driver(mcu_driver);
-}
-module_init(mcu_init);
-
-static void __exit mcu_exit(void)
-{
-   i2c_del_driver(mcu_driver);
-}
-module_exit(mcu_exit);
-
+module_i2c_driver(mcu_driver);
 MODULE_DESCRIPTION(Power Management and GPIO expander driver for 
   MPC8349E-mITX-compatible MCU);
 MODULE_AUTHOR(Anton Vorontsov avoront...@ru.mvista.com);
-- 
1.7.1

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 1/9] powerpc: 83xx: use module_i2c_driver macro

2012-10-13 Thread devendra.aaru 
whoops, sorry, i made mistake in the patchset numbering,

please ignore this patch i will send a patch with the updated correct
number. actually there is only one patch. no 9 patches,

sorry for the noise,

devendra
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH 1/9] powerpc: 83xx: use module_i2c_driver macro

2012-10-13 Thread Devendra Naga 
replace the module init and exit calls containing the
i2c_add_driver and i2c_del_driver with the module_i2c_driver
macro as it does the same things as the code that is removed

Signed-off-by: Devendra Naga devendra.a...@gmail.com
---

 Not compile tested, because i dont have a ppc cross toolchain
 arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c |   13 +
 1 files changed, 1 insertions(+), 12 deletions(-)

diff --git a/arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c 
b/arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c
index ef6537b..d27477b 100644
--- a/arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c
+++ b/arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c
@@ -232,18 +232,7 @@ static struct i2c_driver mcu_driver = {
.id_table = mcu_ids,
 };
 
-static int __init mcu_init(void)
-{
-   return i2c_add_driver(mcu_driver);
-}
-module_init(mcu_init);
-
-static void __exit mcu_exit(void)
-{
-   i2c_del_driver(mcu_driver);
-}
-module_exit(mcu_exit);
-
+module_i2c_driver(mcu_driver);
 MODULE_DESCRIPTION(Power Management and GPIO expander driver for 
   MPC8349E-mITX-compatible MCU);
 MODULE_AUTHOR(Anton Vorontsov avoront...@ru.mvista.com);
-- 
1.7.1

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev