Re: [PATCH 1/9 v2] powerpc: change FDT compatible prefix to mrvl
Either use the stock ticker, in UPPER CASE, or use a nice descriptive name. The lower case space is free for all, using shortened names (like mrvl) there only increases the chances of collisions. Frankly Segher, it doesn't matter to me. However, NONE of the existing DTS files use upper-case stock ticker. I see no reason to deviate from the existing convention It's not an existing convention, it's a mistake some people made ;-) (even if that convention doesn't follow the previously defined upper-case stock ticker convention.) That's not a previously defined convention, it's the defined rules in the OF standard. Conventions are examples that are nice to follow if there's no real reason to choose either way; standards are things that if you break them, people shout out you. Let me say this again: it is *fine* if you use some lower-case name. In that case though, marvell is slightly better than mrvl, and you had the former already, so just keep it :-) Agreed? Ca we move on now? :-) Segher ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
[PATCH 1/9 v2] powerpc: change FDT compatible prefix to mrvl
From: Dale Farnsworth [EMAIL PROTECTED]
Follow the convention that compatible names are prefixed by the
vendor's stock ticker symbol. For Marvell Technology Group Ltd.,
that's MRVL.
Signed-off-by: Dale Farnsworth [EMAIL PROTECTED]
Acked-by: Mark A. Greer [EMAIL PROTECTED]
Acked-by: Grant Likely [EMAIL PROTECTED]
Index: linux-2.6/arch/powerpc/boot/dts/prpmc2800.dts
===
--- linux-2.6.orig/arch/powerpc/boot/dts/prpmc2800.dts
+++ linux-2.6/arch/powerpc/boot/dts/prpmc2800.dts
@@ -44,7 +44,7 @@
#address-cells = 1;
#size-cells = 1;
model = mv64360; /* Default */
- compatible = marvell,mv64x60;
+ compatible = mrvl,mv64x60;
clock-frequency = 7f28155;/* 133.33 MHz */
reg = f100 0001;
virtual-reg = f100;
@@ -72,7 +72,7 @@
#address-cells = 1;
#size-cells = 0;
device_type = mdio;
- compatible = marvell,mv64x60-mdio;
+ compatible = mrvl,mv64x60-mdio;
[EMAIL PROTECTED] {
device_type = ethernet-phy;
compatible = broadcom,bcm5421;
@@ -93,7 +93,7 @@
reg = 2000 2000;
eth0 {
device_type = network;
- compatible = marvell,mv64x60-eth;
+ compatible = mrvl,mv64x60-eth;
block-index = 0;
interrupts = 20;
interrupt-parent = /mv64x60/pic;
@@ -102,7 +102,7 @@
};
eth1 {
device_type = network;
- compatible = marvell,mv64x60-eth;
+ compatible = mrvl,mv64x60-eth;
block-index = 1;
interrupts = 21;
interrupt-parent = /mv64x60/pic;
@@ -113,7 +113,7 @@
[EMAIL PROTECTED] {
device_type = dma;
- compatible = marvell,mv64x60-sdma;
+ compatible = mrvl,mv64x60-sdma;
reg = 4000 c18;
virtual-reg = f1004000;
interrupt-base = 0;
@@ -123,7 +123,7 @@
[EMAIL PROTECTED] {
device_type = dma;
- compatible = marvell,mv64x60-sdma;
+ compatible = mrvl,mv64x60-sdma;
reg = 6000 c18;
virtual-reg = f1006000;
interrupt-base = 0;
@@ -132,7 +132,7 @@
};
[EMAIL PROTECTED] {
- compatible = marvell,mv64x60-brg;
+ compatible = mrvl,mv64x60-brg;
reg = b200 8;
clock-src = 8;
clock-frequency = 7ed6b40;
@@ -141,7 +141,7 @@
};
[EMAIL PROTECTED] {
- compatible = marvell,mv64x60-brg;
+ compatible = mrvl,mv64x60-brg;
reg = b208 8;
clock-src = 8;
clock-frequency = 7ed6b40;
@@ -164,7 +164,7 @@
[EMAIL PROTECTED] {
device_type = serial;
- compatible = marvell,mpsc;
+ compatible = mrvl,mpsc;
reg = 8000 38;
virtual-reg = f1008000;
sdma = /mv64x60/[EMAIL PROTECTED];
@@ -184,7 +184,7 @@
[EMAIL PROTECTED] {
device_type = serial;
- compatible = marvell,mpsc;
+ compatible = mrvl,mpsc;
reg = 9000 38;
virtual-reg = f1009000;
sdma = /mv64x60/[EMAIL PROTECTED];
@@ -203,14 +203,14 @@
};
[EMAIL PROTECTED] { /* watchdog timer */
- compatible = marvell,mv64x60-wdt;
+ compatible = mrvl,mv64x60-wdt;
reg = b410 8;
timeout = a; /* wdt timeout in seconds */
};
[EMAIL PROTECTED] {
device_type = i2c;
- compatible = marvell,mv64x60-i2c;
+ compatible = mrvl,mv64x60-i2c;
reg = c000 20;
virtual-reg = f100c000;
freq_m = 8;
@@ -224,18 +224,18 @@
pic {
Re: [PATCH 1/9 v2] powerpc: change FDT compatible prefix to mrvl
Follow the convention that compatible names are prefixed by the vendor's stock ticker symbol. For Marvell Technology Group Ltd., that's MRVL. - compatible = marvell,mv64x60; + compatible = mrvl,mv64x60; NAK. Either use the stock ticker, in UPPER CASE, or use a nice descriptive name. The lower case space is free for all, using shortened names (like mrvl) there only increases the chances of collisions. Segher ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH 1/9 v2] powerpc: change FDT compatible prefix to mrvl
On Mon, Apr 07, 2008 at 10:49:40PM +0200, Segher Boessenkool wrote: Follow the convention that compatible names are prefixed by the vendor's stock ticker symbol. For Marvell Technology Group Ltd., that's MRVL. -compatible = marvell,mv64x60; +compatible = mrvl,mv64x60; NAK. Either use the stock ticker, in UPPER CASE, or use a nice descriptive name. The lower case space is free for all, using shortened names (like mrvl) there only increases the chances of collisions. [Oops, I forgot to copy the list on my reply to Segher. Segher, sorry for the repeat.] Frankly Segher, it doesn't matter to me. However, NONE of the existing DTS files use upper-case stock ticker. I see no reason to deviate from the existing convention (even if that convention doesn't follow the previous convention of using upper-case). Since it seems that the convention for compatible property prefixes hasn't been decided yet, maybe it would be best for me to back out this patch and redo those that follow. I'll do that and repost the series. -Dale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
