Re: [PATCH 18/21] [POWERPC] bamboo: remove bogus ranges property in EBC node

2007-12-21 Thread Josh Boyer
On Fri, 21 Dec 2007 15:39:35 +1100
Benjamin Herrenschmidt [EMAIL PROTECTED] wrote:

 This removes a bogus empty ranges property in the EBC device node
 of the Bamboo board device-tree.
 
 The ranges property will be created by the boot wrapper, there is
 no need to have an empty property there, and that causes recent
 dtc to complain.

The wrapper doesn't do anything with EBC for bamboo because the EBC
stuff is a nightmare on this board.  The patch can stand, but I'll
fixup the comments in the changelog.

josh
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev


Re: [PATCH 18/21] [POWERPC] bamboo: remove bogus ranges property in EBC node

2007-12-21 Thread Benjamin Herrenschmidt

On Fri, 2007-12-21 at 06:09 -0600, Josh Boyer wrote:
 On Fri, 21 Dec 2007 15:39:35 +1100
 Benjamin Herrenschmidt [EMAIL PROTECTED] wrote:
 
  This removes a bogus empty ranges property in the EBC device node
  of the Bamboo board device-tree.
  
  The ranges property will be created by the boot wrapper, there is
  no need to have an empty property there, and that causes recent
  dtc to complain.
 
 The wrapper doesn't do anything with EBC for bamboo because the EBC
 stuff is a nightmare on this board.  The patch can stand, but I'll
 fixup the comments in the changelog.

The wrapper could still create ranges for the chip select settings no ?

In any case, empty ranges is bogus.

Ben.


___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev


Re: [PATCH 18/21] [POWERPC] bamboo: remove bogus ranges property in EBC node

2007-12-21 Thread Josh Boyer
On Sat, 22 Dec 2007 08:16:55 +1100
Benjamin Herrenschmidt [EMAIL PROTECTED] wrote:

 
 On Fri, 2007-12-21 at 06:09 -0600, Josh Boyer wrote:
  On Fri, 21 Dec 2007 15:39:35 +1100
  Benjamin Herrenschmidt [EMAIL PROTECTED] wrote:
  
   This removes a bogus empty ranges property in the EBC device node
   of the Bamboo board device-tree.
   
   The ranges property will be created by the boot wrapper, there is
   no need to have an empty property there, and that causes recent
   dtc to complain.
  
  The wrapper doesn't do anything with EBC for bamboo because the EBC
  stuff is a nightmare on this board.  The patch can stand, but I'll
  fixup the comments in the changelog.
 
 The wrapper could still create ranges for the chip select settings no ?

It could.  It doesn't though.  Perhaps our interpretation of will be
created differed.

 In any case, empty ranges is bogus.

Correct.  Which is why I said I'd just edit the changelog :).

josh
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev


[PATCH 18/21] [POWERPC] bamboo: remove bogus ranges property in EBC node

2007-12-20 Thread Benjamin Herrenschmidt
This removes a bogus empty ranges property in the EBC device node
of the Bamboo board device-tree.

The ranges property will be created by the boot wrapper, there is
no need to have an empty property there, and that causes recent
dtc to complain.

Signed-off-by: Benjamin Herrenschmidt [EMAIL PROTECTED]
---

 arch/powerpc/boot/dts/bamboo.dts |1 -
 1 file changed, 1 deletion(-)

--- linux-merge.orig/arch/powerpc/boot/dts/bamboo.dts   2007-12-21 
14:35:23.0 +1100
+++ linux-merge/arch/powerpc/boot/dts/bamboo.dts2007-12-21 
14:35:25.0 +1100
@@ -126,7 +126,6 @@
#address-cells = 2;
#size-cells = 1;
clock-frequency = 0; /* Filled in by zImage */
-   ranges;
interrupts = 5 1;
interrupt-parent = UIC1;
};
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev