Re: [PATCH 2/5] powerpc/ftw: Define FTW_SETUP ioctl API

[Sukadev Bhattiprolu]

Randy Dunlap [rdun...@infradead.org] wrote:

> > +#define FTW_FLAGS_PIN_WINDOW   0x1
> > +
> > +#define FTW_SETUP  _IOW('v', 1, struct ftw_setup_attr)
> 
> ioctls should be documented in Documentation/ioctl/ioctl-number.txt.
> Please update that file.

Ok. Here is the updated patch.

Thanks for the review.

Sukadev
---
>From 1f347c199a0b1bbc528705c8e9ddd11c825a80fc Mon Sep 17 00:00:00 2001
From: Sukadev Bhattiprolu <suka...@linux.vnet.ibm.com>
Date: Thu, 2 Feb 2017 06:20:07 -0500
Subject: [PATCH 2/5] powerpc/ftw: Define FTW_SETUP ioctl API

Define the FTW_SETUP ioctl interface for fast thread wakeup (FTW). A
follow-on patch will implement the FTW driver and ioctl.

Thanks to input from Ben Herrenschmidt, Michael Neuling, Michael Ellerman.

Signed-off-by: Sukadev Bhattiprolu <suka...@linux.vnet.ibm.com>
---
Changelog[v2]
- [Michael Neuling] Use a single VAS_FTW_SETUP ioctl and simplify
  the interface.
- [Randy Dunlap] Reserve/document the ioctl number used.
---
 Documentation/ioctl/ioctl-number.txt |  1 +
 include/uapi/misc/ftw.h  | 35 +++
 2 files changed, 36 insertions(+)
 create mode 100644 include/uapi/misc/ftw.h

diff --git a/Documentation/ioctl/ioctl-number.txt 
b/Documentation/ioctl/ioctl-number.txt
index 3e3fdae..b0f323c 100644
--- a/Documentation/ioctl/ioctl-number.txt
+++ b/Documentation/ioctl/ioctl-number.txt
@@ -277,6 +277,7 @@ Code  Seq#(hex) Include FileComments
 'v'00-1F   linux/fs.h  conflict!
 'v'00-0F   linux/sonypi.h  conflict!
 'v'C0-FF   linux/meye.hconflict!
+'v'20-27   include/uapi/misc/ftw.h
 'w'all CERN SCI driver
 'y'00-1F   packet based user level communications
<mailto:zap...@interlan.net>
diff --git a/include/uapi/misc/ftw.h b/include/uapi/misc/ftw.h
new file mode 100644
index 000..99676b2
--- /dev/null
+++ b/include/uapi/misc/ftw.h
@@ -0,0 +1,35 @@
+/*
+ * Copyright 2018 IBM Corp.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version
+ * 2 of the License, or (at your option) any later version.
+ */
+
+#ifndef _UAPI_MISC_FTW_H
+#define _UAPI_MISC_FTW_H
+
+#include 
+#include 
+
+#define FTW_FLAGS_PIN_WINDOW   0x1
+
+/*
+ * Note: The range 0x20-27 for letter 'v' are reserved for FTW ioctls in
+ *  Documentation/ioctl/ioctl-number.txt.
+ */
+#define FTW_SETUP  _IOW('v', 0x20, struct ftw_setup_attr)
+
+struct ftw_setup_attr {
+   __s16   version;
+   __s16   vas_id; /* specific instance of vas or -1 for default */
+   __u32   reserved;
+
+   __u64   reserved1;
+
+   __u64   flags;
+   __u64   reserved2;
+};
+
+#endif /* _UAPI_MISC_FTW_H */
-- 
2.7.4

Re: [PATCH 2/5] powerpc/ftw: Define FTW_SETUP ioctl API

[Randy Dunlap]

On 01/16/18 18:50, Sukadev Bhattiprolu wrote:
> Define the FTW_SETUP ioctl interface for fast thread wakeup (FTW). A
> follow-on patch will implement the FTW driver and ioctl.
> 
> Thanks to input from Ben Herrenschmidt, Michael Neuling, Michael Ellerman.
> 
> Signed-off-by: Sukadev Bhattiprolu 
> ---
> Changelog[v2]
>   - [Michael Neuling] Use a single VAS_FTW_SETUP ioctl and simplify
> the interface.
> ---
>  include/uapi/misc/ftw.h | 31 +++
>  1 file changed, 31 insertions(+)
>  create mode 100644 include/uapi/misc/ftw.h
> 
> diff --git a/include/uapi/misc/ftw.h b/include/uapi/misc/ftw.h
> new file mode 100644
> index 000..f233f51
> --- /dev/null
> +++ b/include/uapi/misc/ftw.h
> @@ -0,0 +1,31 @@
> +/*
> + * Copyright 2018 IBM Corp.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License
> + * as published by the Free Software Foundation; either version
> + * 2 of the License, or (at your option) any later version.
> + */
> +
> +#ifndef _UAPI_MISC_FTW_H
> +#define _UAPI_MISC_FTW_H
> +
> +#include 
> +#include 
> +
> +#define FTW_FLAGS_PIN_WINDOW 0x1
> +
> +#define FTW_SETUP_IOW('v', 1, struct ftw_setup_attr)

ioctls should be documented in Documentation/ioctl/ioctl-number.txt.
Please update that file.

> +
> +struct ftw_setup_attr {
> + __s16   version;
> + __s16   vas_id; /* specific instance of vas or -1 for default */
> + __u32   reserved;
> +
> + __u64   reserved1;
> +
> + __u64   flags;
> + __u64   reserved2;
> +};
> +
> +#endif /* _UAPI_MISC_FTW_H */
> 


-- 
~Randy

[PATCH 2/5] powerpc/ftw: Define FTW_SETUP ioctl API

[Sukadev Bhattiprolu]

Define the FTW_SETUP ioctl interface for fast thread wakeup (FTW). A
follow-on patch will implement the FTW driver and ioctl.

Thanks to input from Ben Herrenschmidt, Michael Neuling, Michael Ellerman.

Signed-off-by: Sukadev Bhattiprolu 
---
Changelog[v2]
- [Michael Neuling] Use a single VAS_FTW_SETUP ioctl and simplify
  the interface.
---
 include/uapi/misc/ftw.h | 31 +++
 1 file changed, 31 insertions(+)
 create mode 100644 include/uapi/misc/ftw.h

diff --git a/include/uapi/misc/ftw.h b/include/uapi/misc/ftw.h
new file mode 100644
index 000..f233f51
--- /dev/null
+++ b/include/uapi/misc/ftw.h
@@ -0,0 +1,31 @@
+/*
+ * Copyright 2018 IBM Corp.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version
+ * 2 of the License, or (at your option) any later version.
+ */
+
+#ifndef _UAPI_MISC_FTW_H
+#define _UAPI_MISC_FTW_H
+
+#include 
+#include 
+
+#define FTW_FLAGS_PIN_WINDOW   0x1
+
+#define FTW_SETUP  _IOW('v', 1, struct ftw_setup_attr)
+
+struct ftw_setup_attr {
+   __s16   version;
+   __s16   vas_id; /* specific instance of vas or -1 for default */
+   __u32   reserved;
+
+   __u64   reserved1;
+
+   __u64   flags;
+   __u64   reserved2;
+};
+
+#endif /* _UAPI_MISC_FTW_H */
-- 
2.7.4