Re: [PATCH 2/6] KVM: PPC: BOOK3S: HV: Deny virtual page class key update via h_protect

2014-07-02 Thread Aneesh Kumar K.V 
Paul Mackerras pau...@samba.org writes:

 On Sun, Jun 29, 2014 at 04:47:31PM +0530, Aneesh Kumar K.V wrote:
 This makes it consistent with h_enter where we clear the key
 bits. We also want to use virtual page class key protection mechanism
 for indicating host page fault. For that we will be using key class
 index 30 and 31. So prevent the guest from updating key bits until
 we add proper support for virtual page class protection mechanism for
 the guest. This will not have any impact for PAPR linux guest because
 Linux guest currently don't use virtual page class key protection model

 As things stand, without this patch series, we do actually have
 everything we need in the kernel for guests to use virtual page class
 keys.  Arguably we should have a capability to tell userspace how many
 storage keys the guest can use, but that's the only missing piece as
 far as I can see.

yes.


 If we add such a capability, I can't see any reason why we should need
 to disable guest use of storage keys in this patchset.

With this patchset, we would need additonal changes to find out whether the key
fault happened because of the guest's usage of the key. I was planning to do
that as an add-on series to keep the changes in this minimal. Also since
linux didn't use keys i was not sure whether guest support of keys is an
important item.

-aneesh

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 2/6] KVM: PPC: BOOK3S: HV: Deny virtual page class key update via h_protect

2014-07-01 Thread Paul Mackerras 
On Sun, Jun 29, 2014 at 04:47:31PM +0530, Aneesh Kumar K.V wrote:
 This makes it consistent with h_enter where we clear the key
 bits. We also want to use virtual page class key protection mechanism
 for indicating host page fault. For that we will be using key class
 index 30 and 31. So prevent the guest from updating key bits until
 we add proper support for virtual page class protection mechanism for
 the guest. This will not have any impact for PAPR linux guest because
 Linux guest currently don't use virtual page class key protection model

As things stand, without this patch series, we do actually have
everything we need in the kernel for guests to use virtual page class
keys.  Arguably we should have a capability to tell userspace how many
storage keys the guest can use, but that's the only missing piece as
far as I can see.

If we add such a capability, I can't see any reason why we should need
to disable guest use of storage keys in this patchset.

Paul.
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH 2/6] KVM: PPC: BOOK3S: HV: Deny virtual page class key update via h_protect

2014-06-29 Thread Aneesh Kumar K.V 
This makes it consistent with h_enter where we clear the key
bits. We also want to use virtual page class key protection mechanism
for indicating host page fault. For that we will be using key class
index 30 and 31. So prevent the guest from updating key bits until
we add proper support for virtual page class protection mechanism for
the guest. This will not have any impact for PAPR linux guest because
Linux guest currently don't use virtual page class key protection model

Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com
---
 arch/powerpc/kvm/book3s_hv_rm_mmu.c | 12 
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/arch/powerpc/kvm/book3s_hv_rm_mmu.c 
b/arch/powerpc/kvm/book3s_hv_rm_mmu.c
index 157a5f35edfa..f908845f7379 100644
--- a/arch/powerpc/kvm/book3s_hv_rm_mmu.c
+++ b/arch/powerpc/kvm/book3s_hv_rm_mmu.c
@@ -658,13 +658,17 @@ long kvmppc_h_protect(struct kvm_vcpu *vcpu, unsigned 
long flags,
}
 
v = pte;
+   /*
+* We ignore key bits here. We use class 31 and 30 for
+* hypervisor purpose. We still don't track the page
+* class seperately. Until then don't allow h_protect
+* to change key bits.
+*/
bits = (flags  55)  HPTE_R_PP0;
-   bits |= (flags  48)  HPTE_R_KEY_HI;
-   bits |= flags  (HPTE_R_PP | HPTE_R_N | HPTE_R_KEY_LO);
+   bits |= flags  (HPTE_R_PP | HPTE_R_N);
 
/* Update guest view of 2nd HPTE dword */
-   mask = HPTE_R_PP0 | HPTE_R_PP | HPTE_R_N |
-   HPTE_R_KEY_HI | HPTE_R_KEY_LO;
+   mask = HPTE_R_PP0 | HPTE_R_PP | HPTE_R_N;
rev = real_vmalloc_addr(kvm-arch.revmap[pte_index]);
if (rev) {
r = (rev-guest_rpte  ~mask) | bits;
-- 
1.9.1

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev