Re: [PATCH 2/9] mtd: add mtd_is_master helper

[Marco Felsch]

On 24-07-01, Sergei Shtylyov wrote:
> On 7/1/24 4:53 PM, Marco Felsch wrote:
> 
> > Provide a simple helper to make it easy to detect an master mtd device.
> > 
> > Signed-off-by: Marco Felsch 
> > ---
> >  include/linux/mtd/mtd.h | 5 +
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h
> > index 8d10d9d2e830..bf3fc2ea7230 100644
> > --- a/include/linux/mtd/mtd.h
> > +++ b/include/linux/mtd/mtd.h
> > @@ -408,6 +408,11 @@ static inline struct mtd_info *mtd_get_master(struct 
> > mtd_info *mtd)
> > return mtd;
> >  }
> >  
> > +static inline bool mtd_is_master(struct mtd_info *mtd)
> > +{
> > +   return mtd->parent ? false : true;
> 
>Perhaps:
> 
>   return !mtd->parent;

Sure, if you prefer this style rather I will change it.

Regards,
  Marco

Re: [PATCH 2/9] mtd: add mtd_is_master helper

[Sergei Shtylyov]

On 7/1/24 4:53 PM, Marco Felsch wrote:

> Provide a simple helper to make it easy to detect an master mtd device.
> 
> Signed-off-by: Marco Felsch 
> ---
>  include/linux/mtd/mtd.h | 5 +
>  1 file changed, 5 insertions(+)
> 
> diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h
> index 8d10d9d2e830..bf3fc2ea7230 100644
> --- a/include/linux/mtd/mtd.h
> +++ b/include/linux/mtd/mtd.h
> @@ -408,6 +408,11 @@ static inline struct mtd_info *mtd_get_master(struct 
> mtd_info *mtd)
>   return mtd;
>  }
>  
> +static inline bool mtd_is_master(struct mtd_info *mtd)
> +{
> + return mtd->parent ? false : true;

   Perhaps:

return !mtd->parent;

[...]

MBR, Sergey

[PATCH 2/9] mtd: add mtd_is_master helper

[Marco Felsch]

Provide a simple helper to make it easy to detect an master mtd device.

Signed-off-by: Marco Felsch 
---
 include/linux/mtd/mtd.h | 5 +
 1 file changed, 5 insertions(+)

diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h
index 8d10d9d2e830..bf3fc2ea7230 100644
--- a/include/linux/mtd/mtd.h
+++ b/include/linux/mtd/mtd.h
@@ -408,6 +408,11 @@ static inline struct mtd_info *mtd_get_master(struct 
mtd_info *mtd)
return mtd;
 }
 
+static inline bool mtd_is_master(struct mtd_info *mtd)
+{
+   return mtd->parent ? false : true;
+}
+
 static inline u64 mtd_get_master_ofs(struct mtd_info *mtd, u64 ofs)
 {
while (mtd->parent) {

-- 
2.39.2