Re: [PATCH 3/4] powerpc/pseries: use notrace hcall variant for H_CEDE idle

2021-04-27 Thread Naveen N. Rao

Nicholas Piggin wrote:

Rather than special-case H_CEDE in the hcall trace wrappers, make the
idle H_CEDE call use plpar_hcall_norets_notrace().

Signed-off-by: Nicholas Piggin 
---
 arch/powerpc/include/asm/plpar_wrappers.h |  6 +-
 arch/powerpc/platforms/pseries/lpar.c | 10 --
 2 files changed, 5 insertions(+), 11 deletions(-)


Reviewed-by: Naveen N. Rao 


- Naveen



[PATCH 3/4] powerpc/pseries: use notrace hcall variant for H_CEDE idle

2021-04-22 Thread Nicholas Piggin
Rather than special-case H_CEDE in the hcall trace wrappers, make the
idle H_CEDE call use plpar_hcall_norets_notrace().

Signed-off-by: Nicholas Piggin 
---
 arch/powerpc/include/asm/plpar_wrappers.h |  6 +-
 arch/powerpc/platforms/pseries/lpar.c | 10 --
 2 files changed, 5 insertions(+), 11 deletions(-)

diff --git a/arch/powerpc/include/asm/plpar_wrappers.h 
b/arch/powerpc/include/asm/plpar_wrappers.h
index ece84a430701..83e0f701ebc6 100644
--- a/arch/powerpc/include/asm/plpar_wrappers.h
+++ b/arch/powerpc/include/asm/plpar_wrappers.h
@@ -28,7 +28,11 @@ static inline void set_cede_latency_hint(u8 latency_hint)
 
 static inline long cede_processor(void)
 {
-   return plpar_hcall_norets(H_CEDE);
+   /*
+* We cannot call tracepoints inside RCU idle regions which
+* means we must not trace H_CEDE.
+*/
+   return plpar_hcall_norets_notrace(H_CEDE);
 }
 
 static inline long extended_cede_processor(unsigned long latency_hint)
diff --git a/arch/powerpc/platforms/pseries/lpar.c 
b/arch/powerpc/platforms/pseries/lpar.c
index 0641779e5cde..835e7f661a05 100644
--- a/arch/powerpc/platforms/pseries/lpar.c
+++ b/arch/powerpc/platforms/pseries/lpar.c
@@ -1839,13 +1839,6 @@ notrace void __trace_hcall_entry(unsigned long opcode, 
unsigned long *args)
unsigned long flags;
unsigned int *depth;
 
-   /*
-* We cannot call tracepoints inside RCU idle regions which
-* means we must not trace H_CEDE.
-*/
-   if (opcode == H_CEDE)
-   return;
-
local_irq_save(flags);
 
depth = this_cpu_ptr(_trace_depth);
@@ -1867,9 +1860,6 @@ notrace void __trace_hcall_exit(long opcode, long retval, 
unsigned long *retbuf)
unsigned long flags;
unsigned int *depth;
 
-   if (opcode == H_CEDE)
-   return;
-
local_irq_save(flags);
 
depth = this_cpu_ptr(_trace_depth);
-- 
2.23.0