Re: [PATCH 4/4] [POWERPC] CPM1: implement GPIO API

2007-12-22 Thread Jochen Friedrich 
Hi Anton,

 Jochen, I kept your Signed-off-by, though this isn't your original
 patch. Hope you're okay with it. I also hope you'll test it. ;-)
   

that's OK.

Thanks,
Jochen
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH 4/4] [POWERPC] CPM1: implement GPIO API

2007-12-22 Thread Jochen Friedrich 
Hi Anton,

 I also hope you'll test it. ;-)

yes.

 +int cpm_init_par_io(void)
 +{
 +   struct device_node *np;
 +   const u32 *num_ports;
 +
 +   np = of_find_node_by_name(NULL, fsl,cpm1-pario);
 +   if (!np)
 +   return -ENOENT;
 +

I guess this should be:

 np = of_find_compatible_node(NULL, NULL, fsl,cpm1-pario);

With this modification it works OK for me :)

Thanks,
Jochen
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH 4/4] [POWERPC] CPM1: implement GPIO API

2007-12-22 Thread Anton Vorontsov 
On Sat, Dec 22, 2007 at 05:08:14PM +0100, Jochen Friedrich wrote:
 Hi Anton,
 
  I also hope you'll test it. ;-)
 
 yes.
 
  +int cpm_init_par_io(void)
  +{
  +   struct device_node *np;
  +   const u32 *num_ports;
  +
  +   np = of_find_node_by_name(NULL, fsl,cpm1-pario);
  +   if (!np)
  +   return -ENOENT;
  +
 
 I guess this should be:
 
  np = of_find_compatible_node(NULL, NULL, fsl,cpm1-pario);
 
 With this modification it works OK for me :)

Fixed, thanks!

-- 
Anton Vorontsov
email: [EMAIL PROTECTED]
backup email: [EMAIL PROTECTED]
irc://irc.freenode.net/bd2
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev