Re: [PATCH 4/5] ehea: fix phyp checkpatch complaints

2008-02-04 Thread Scott Wood
Doug Maxey wrote:
 On Fri, 01 Feb 2008 13:23:45 CST, Scott Wood wrote:
 On Thu, Jan 31, 2008 at 08:20:50PM -0600, Doug Maxey wrote:
  /* input param R5 */
 -#define H_ALL_RES_QP_EQPO EHEA_BMASK_IBM(9, 11)
 ...
 +#define H_ALL_RES_QP_EQPOEHEA_BMASK_IBM(9, 11)
 ...
 This was better the way it was (before, it was readable at any tab setting);
 checkpatch is overeager to complain on tab/space issues (it's a bit hard to
 distinguish indentation from alignment with a regex).
 
 In emacs, with no special offsets, the lines appear to still line up.

Are you using a tab size other than 8?

 What did happen was spaces were turned to tabs where applicable.

I disagree about the applicability. :-)

 What editor shows a bad alignment?

Any editor that has been configured to a non-default tab size.

-Scott

___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev


Re: [PATCH 4/5] ehea: fix phyp checkpatch complaints

2008-02-01 Thread Scott Wood
On Thu, Jan 31, 2008 at 08:20:50PM -0600, Doug Maxey wrote:
  /* input param R5 */
 -#define H_ALL_RES_QP_EQPO EHEA_BMASK_IBM(9, 11)
 -#define H_ALL_RES_QP_QPP  EHEA_BMASK_IBM(12, 12)
 -#define H_ALL_RES_QP_RQR  EHEA_BMASK_IBM(13, 15)
 -#define H_ALL_RES_QP_EQEG EHEA_BMASK_IBM(16, 16)
 -#define H_ALL_RES_QP_LL_QPEHEA_BMASK_IBM(17, 17)
 -#define H_ALL_RES_QP_DMA128   EHEA_BMASK_IBM(19, 19)
 -#define H_ALL_RES_QP_HSM  EHEA_BMASK_IBM(20, 21)
 -#define H_ALL_RES_QP_SIGT EHEA_BMASK_IBM(22, 23)
 -#define H_ALL_RES_QP_TENURE   EHEA_BMASK_IBM(48, 55)
 -#define H_ALL_RES_QP_RES_TYP  EHEA_BMASK_IBM(56, 63)
 +#define H_ALL_RES_QP_EQPO  EHEA_BMASK_IBM(9, 11)
 +#define H_ALL_RES_QP_QPP   EHEA_BMASK_IBM(12, 12)
 +#define H_ALL_RES_QP_RQR   EHEA_BMASK_IBM(13, 15)
 +#define H_ALL_RES_QP_EQEG  EHEA_BMASK_IBM(16, 16)
 +#define H_ALL_RES_QP_LL_QP EHEA_BMASK_IBM(17, 17)
 +#define H_ALL_RES_QP_DMA128EHEA_BMASK_IBM(19, 19)
 +#define H_ALL_RES_QP_HSM   EHEA_BMASK_IBM(20, 21)
 +#define H_ALL_RES_QP_SIGT  EHEA_BMASK_IBM(22, 23)
 +#define H_ALL_RES_QP_TENUREEHEA_BMASK_IBM(48, 55)
 +#define H_ALL_RES_QP_RES_TYP   EHEA_BMASK_IBM(56, 63)

This was better the way it was (before, it was readable at any tab setting);
checkpatch is overeager to complain on tab/space issues (it's a bit hard to
distinguish indentation from alignment with a regex).

-Scott
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev


[PATCH 4/5] ehea: fix phyp checkpatch complaints

2008-01-31 Thread Doug Maxey
Cc: Jan-Bernd Themann [EMAIL PROTECTED]
Signed-off-by: Doug Maxey [EMAIL PROTECTED]
---
 drivers/net/ehea/ehea_phyp.c |  158 +-
 drivers/net/ehea/ehea_phyp.h |   22 +++---
 2 files changed, 90 insertions(+), 90 deletions(-)

diff --git a/drivers/net/ehea/ehea_phyp.c b/drivers/net/ehea/ehea_phyp.c
index 95c4a7f..156eb63 100644
--- a/drivers/net/ehea/ehea_phyp.c
+++ b/drivers/net/ehea/ehea_phyp.c
@@ -6,9 +6,9 @@
  *  (C) Copyright IBM Corp. 2006
  *
  *  Authors:
- *   Christoph Raisch [EMAIL PROTECTED]
- *   Jan-Bernd Themann [EMAIL PROTECTED]
- *   Thomas Klein [EMAIL PROTECTED]
+ *  Christoph Raisch [EMAIL PROTECTED]
+ *  Jan-Bernd Themann [EMAIL PROTECTED]
+ *  Thomas Klein [EMAIL PROTECTED]
  *
  *
  * This program is free software; you can redistribute it and/or modify
@@ -38,11 +38,11 @@ static inline u16 get_order_of_qentries(u16 queue_entries)
 }
 
 /* Defines for H_CALL H_ALLOC_RESOURCE */
-#define H_ALL_RES_TYPE_QP1
-#define H_ALL_RES_TYPE_CQ2
-#define H_ALL_RES_TYPE_EQ3
-#define H_ALL_RES_TYPE_MR5
-#define H_ALL_RES_TYPE_MW6
+#define H_ALL_RES_TYPE_QP   1
+#define H_ALL_RES_TYPE_CQ   2
+#define H_ALL_RES_TYPE_EQ   3
+#define H_ALL_RES_TYPE_MR   5
+#define H_ALL_RES_TYPE_MW   6
 
 static long ehea_plpar_hcall_norets(unsigned long opcode,
unsigned long arg1,
@@ -137,77 +137,77 @@ u64 ehea_h_query_ehea_qp(const u64 adapter_handle, const 
u8 qp_category,
 const u64 qp_handle, const u64 sel_mask, void *cb_addr)
 {
return ehea_plpar_hcall_norets(H_QUERY_HEA_QP,
-  adapter_handle,  /* R4 */
-  qp_category, /* R5 */
-  qp_handle,   /* R6 */
-  sel_mask,/* R7 */
+  adapter_handle,  /* R4 */
+  qp_category, /* R5 */
+  qp_handle,   /* R6 */
+  sel_mask,/* R7 */
   virt_to_abs(cb_addr),/* R8 */
   0, 0);
 }
 
 /* input param R5 */
-#define H_ALL_RES_QP_EQPO EHEA_BMASK_IBM(9, 11)
-#define H_ALL_RES_QP_QPP  EHEA_BMASK_IBM(12, 12)
-#define H_ALL_RES_QP_RQR  EHEA_BMASK_IBM(13, 15)
-#define H_ALL_RES_QP_EQEG EHEA_BMASK_IBM(16, 16)
-#define H_ALL_RES_QP_LL_QPEHEA_BMASK_IBM(17, 17)
-#define H_ALL_RES_QP_DMA128   EHEA_BMASK_IBM(19, 19)
-#define H_ALL_RES_QP_HSM  EHEA_BMASK_IBM(20, 21)
-#define H_ALL_RES_QP_SIGT EHEA_BMASK_IBM(22, 23)
-#define H_ALL_RES_QP_TENURE   EHEA_BMASK_IBM(48, 55)
-#define H_ALL_RES_QP_RES_TYP  EHEA_BMASK_IBM(56, 63)
+#define H_ALL_RES_QP_EQPOEHEA_BMASK_IBM(9, 11)
+#define H_ALL_RES_QP_QPP EHEA_BMASK_IBM(12, 12)
+#define H_ALL_RES_QP_RQR EHEA_BMASK_IBM(13, 15)
+#define H_ALL_RES_QP_EQEGEHEA_BMASK_IBM(16, 16)
+#define H_ALL_RES_QP_LL_QP   EHEA_BMASK_IBM(17, 17)
+#define H_ALL_RES_QP_DMA128  EHEA_BMASK_IBM(19, 19)
+#define H_ALL_RES_QP_HSM EHEA_BMASK_IBM(20, 21)
+#define H_ALL_RES_QP_SIGTEHEA_BMASK_IBM(22, 23)
+#define H_ALL_RES_QP_TENURE  EHEA_BMASK_IBM(48, 55)
+#define H_ALL_RES_QP_RES_TYP EHEA_BMASK_IBM(56, 63)
 
 /* input param R9  */
-#define H_ALL_RES_QP_TOKENEHEA_BMASK_IBM(0, 31)
-#define H_ALL_RES_QP_PD   EHEA_BMASK_IBM(32,63)
+#define H_ALL_RES_QP_TOKEN   EHEA_BMASK_IBM(0, 31)
+#define H_ALL_RES_QP_PD  EHEA_BMASK_IBM(32, 63)
 
 /* input param R10 */
-#define H_ALL_RES_QP_MAX_SWQE EHEA_BMASK_IBM(4, 7)
-#define H_ALL_RES_QP_MAX_R1WQEEHEA_BMASK_IBM(12, 15)
-#define H_ALL_RES_QP_MAX_R2WQEEHEA_BMASK_IBM(20, 23)
-#define H_ALL_RES_QP_MAX_R3WQEEHEA_BMASK_IBM(28, 31)
+#define H_ALL_RES_QP_MAX_SWQEEHEA_BMASK_IBM(4, 7)
+#define H_ALL_RES_QP_MAX_R1WQE   EHEA_BMASK_IBM(12, 15)
+#define H_ALL_RES_QP_MAX_R2WQE   EHEA_BMASK_IBM(20, 23)
+#define H_ALL_RES_QP_MAX_R3WQE   EHEA_BMASK_IBM(28, 31)
 /* Max Send Scatter Gather Elements */
-#define H_ALL_RES_QP_MAX_SSGE EHEA_BMASK_IBM(37, 39)
-#define H_ALL_RES_QP_MAX_R1SGEEHEA_BMASK_IBM(45, 47)
+#define H_ALL_RES_QP_MAX_SSGEEHEA_BMASK_IBM(37, 39)
+#define H_ALL_RES_QP_MAX_R1SGE   EHEA_BMASK_IBM(45, 47)
 /* Max Receive SG Elements RQ1 */
-#define H_ALL_RES_QP_MAX_R2SGEEHEA_BMASK_IBM(53, 55)
-#define H_ALL_RES_QP_MAX_R3SGEEHEA_BMASK_IBM(61, 63)
+#define H_ALL_RES_QP_MAX_R2SGE   EHEA_BMASK_IBM(53, 55)
+#define H_ALL_RES_QP_MAX_R3SGE   EHEA_BMASK_IBM(61, 63)
 
 /* input param R11 */
-#define H_ALL_RES_QP_SWQE_IDL EHEA_BMASK_IBM(0, 7)
+#define H_ALL_RES_QP_SWQE_IDLEHEA_BMASK_IBM(0, 7)
 /* max swqe immediate