Re: [PATCH 49/57] video: irq: Remove IRQF_DISABLED

2011-09-21 Thread David Brown
On Wed, Sep 21, 2011 at 05:28:50PM +0800, Yong Zhang wrote:
> Since commit [c58543c8: genirq: Run irq handlers with interrupts disabled],
> We run all interrupt handlers with interrupts disabled
> and we even check and yell when an interrupt handler
> returns with interrupts enabled (see commit [b738a50a:
> genirq: Warn when handler enables interrupts]).
> 
> So now this flag is a NOOP and can be removed.
> 
> Signed-off-by: Yong Zhang 
> ---
>  drivers/video/msm/mddi.c  |2 +-
>  drivers/video/msm/mdp.c   |2 +-

Acked-by: David Brown 

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev


[PATCH 49/57] video: irq: Remove IRQF_DISABLED

2011-09-21 Thread Yong Zhang
Since commit [c58543c8: genirq: Run irq handlers with interrupts disabled],
We run all interrupt handlers with interrupts disabled
and we even check and yell when an interrupt handler
returns with interrupts enabled (see commit [b738a50a:
genirq: Warn when handler enables interrupts]).

So now this flag is a NOOP and can be removed.

Signed-off-by: Yong Zhang 
---
 drivers/video/au1200fb.c  |2 +-
 drivers/video/bf54x-lq043fb.c |2 +-
 drivers/video/bfin-lq035q1-fb.c   |2 +-
 drivers/video/bfin-t350mcqb-fb.c  |2 +-
 drivers/video/bfin_adv7393fb.c|2 +-
 drivers/video/mb862xx/mb862xxfbdrv.c  |4 ++--
 drivers/video/msm/mddi.c  |2 +-
 drivers/video/msm/mdp.c   |2 +-
 drivers/video/nuc900fb.c  |2 +-
 drivers/video/omap2/displays/panel-taal.c |2 +-
 drivers/video/ps3fb.c |2 +-
 drivers/video/pxa3xx-gcu.c|2 +-
 drivers/video/pxafb.c |2 +-
 drivers/video/s3c2410fb.c |2 +-
 drivers/video/sa1100fb.c  |3 +--
 drivers/video/sh_mobile_lcdcfb.c  |2 +-
 drivers/video/tmiofb.c|2 +-
 drivers/video/vt8500lcdfb.c   |2 +-
 18 files changed, 19 insertions(+), 20 deletions(-)

diff --git a/drivers/video/au1200fb.c b/drivers/video/au1200fb.c
index a19a40e..7200559 100644
--- a/drivers/video/au1200fb.c
+++ b/drivers/video/au1200fb.c
@@ -1673,7 +1673,7 @@ static int __devinit au1200fb_drv_probe(struct 
platform_device *dev)
/* Now hook interrupt too */
irq = platform_get_irq(dev, 0);
ret = request_irq(irq, au1200fb_handle_irq,
- IRQF_DISABLED | IRQF_SHARED, "lcd", (void *)dev);
+ IRQF_SHARED, "lcd", (void *)dev);
if (ret) {
print_err("fail to request interrupt line %d (err: %d)",
  irq, ret);
diff --git a/drivers/video/bf54x-lq043fb.c b/drivers/video/bf54x-lq043fb.c
index 2464b91..56720fb 100644
--- a/drivers/video/bf54x-lq043fb.c
+++ b/drivers/video/bf54x-lq043fb.c
@@ -633,7 +633,7 @@ static int __devinit bfin_bf54x_probe(struct 
platform_device *pdev)
goto out7;
}
 
-   if (request_irq(info->irq, bfin_bf54x_irq_error, IRQF_DISABLED,
+   if (request_irq(info->irq, bfin_bf54x_irq_error, 0,
"PPI ERROR", info) < 0) {
printk(KERN_ERR DRIVER_NAME
   ": unable to request PPI ERROR IRQ\n");
diff --git a/drivers/video/bfin-lq035q1-fb.c b/drivers/video/bfin-lq035q1-fb.c
index 23b6c4b..c633068 100644
--- a/drivers/video/bfin-lq035q1-fb.c
+++ b/drivers/video/bfin-lq035q1-fb.c
@@ -695,7 +695,7 @@ static int __devinit bfin_lq035q1_probe(struct 
platform_device *pdev)
goto out7;
}
 
-   ret = request_irq(info->irq, bfin_lq035q1_irq_error, IRQF_DISABLED,
+   ret = request_irq(info->irq, bfin_lq035q1_irq_error, 0,
DRIVER_NAME" PPI ERROR", info);
if (ret < 0) {
dev_err(&pdev->dev, "unable to request PPI ERROR IRQ\n");
diff --git a/drivers/video/bfin-t350mcqb-fb.c b/drivers/video/bfin-t350mcqb-fb.c
index d8de29f..d5e1267 100644
--- a/drivers/video/bfin-t350mcqb-fb.c
+++ b/drivers/video/bfin-t350mcqb-fb.c
@@ -529,7 +529,7 @@ static int __devinit bfin_t350mcqb_probe(struct 
platform_device *pdev)
goto out7;
}
 
-   ret = request_irq(info->irq, bfin_t350mcqb_irq_error, IRQF_DISABLED,
+   ret = request_irq(info->irq, bfin_t350mcqb_irq_error, 0,
"PPI ERROR", info);
if (ret < 0) {
printk(KERN_ERR DRIVER_NAME
diff --git a/drivers/video/bfin_adv7393fb.c b/drivers/video/bfin_adv7393fb.c
index 8486f54..811dd7f 100644
--- a/drivers/video/bfin_adv7393fb.c
+++ b/drivers/video/bfin_adv7393fb.c
@@ -481,7 +481,7 @@ static int __devinit bfin_adv7393_fb_probe(struct 
i2c_client *client,
goto out_4;
}
 
-   if (request_irq(IRQ_PPI_ERROR, ppi_irq_error, IRQF_DISABLED,
+   if (request_irq(IRQ_PPI_ERROR, ppi_irq_error, 0,
"PPI ERROR", fbdev) < 0) {
dev_err(&client->dev, "unable to request PPI ERROR IRQ\n");
ret = -EFAULT;
diff --git a/drivers/video/mb862xx/mb862xxfbdrv.c 
b/drivers/video/mb862xx/mb862xxfbdrv.c
index 12a634a..11a7a33 100644
--- a/drivers/video/mb862xx/mb862xxfbdrv.c
+++ b/drivers/video/mb862xx/mb862xxfbdrv.c
@@ -738,7 +738,7 @@ static int __devinit of_platform_mb862xx_probe(struct 
platform_device *ofdev)
if (mb862xx_gdc_init(par))
goto io_unmap;
 
-   if (request_irq(par->irq, mb862xx_intr, IRQF_DISABLED,
+   if (request_irq(par->irq, mb862xx_intr, 0,
DRV_NAME, (void *)par)) {
dev_err(dev, "Cannot request irq\n");