Re: [PATCH v1 06/11] powerpc/code-patching: Fix patch_branch() return on out-of-range failure

[Christophe Leroy]

Le 02/12/2021 à 13:00, Christophe Leroy a écrit :
> Do not silentely ignore a failure of create_branch() in
> patch_branch(). Return -ERANGE.
> 
> Signed-off-by: Christophe Leroy 

 From 
https://patchwork.ozlabs.org/project/linuxppc-dev/patch/4940b03de220d1dfe2c6b47a41e60925497ce125.1630657331.git.christophe.le...@csgroup.eu/

Reviewed-by: Naveen N. Rao 

> ---
>   arch/powerpc/lib/code-patching.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/lib/code-patching.c 
> b/arch/powerpc/lib/code-patching.c
> index a43ca22313ee..e7a2a41ae8eb 100644
> --- a/arch/powerpc/lib/code-patching.c
> +++ b/arch/powerpc/lib/code-patching.c
> @@ -191,7 +191,9 @@ int patch_branch(u32 *addr, unsigned long target, int 
> flags)
>   {
>   ppc_inst_t instr;
>   
> - create_branch(, addr, target, flags);
> + if (create_branch(, addr, target, flags))
> + return -ERANGE;
> +
>   return patch_instruction(addr, instr);
>   }
>   
> 

[PATCH v1 06/11] powerpc/code-patching: Fix patch_branch() return on out-of-range failure

[Christophe Leroy]

Do not silentely ignore a failure of create_branch() in
patch_branch(). Return -ERANGE.

Signed-off-by: Christophe Leroy 
---
 arch/powerpc/lib/code-patching.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/powerpc/lib/code-patching.c b/arch/powerpc/lib/code-patching.c
index a43ca22313ee..e7a2a41ae8eb 100644
--- a/arch/powerpc/lib/code-patching.c
+++ b/arch/powerpc/lib/code-patching.c
@@ -191,7 +191,9 @@ int patch_branch(u32 *addr, unsigned long target, int flags)
 {
ppc_inst_t instr;
 
-   create_branch(, addr, target, flags);
+   if (create_branch(, addr, target, flags))
+   return -ERANGE;
+
return patch_instruction(addr, instr);
 }
 
-- 
2.33.1