Re: [PATCH v1 3/3] mm: use "GUP-fast" instead "fast GUP" in remaining comments

[John Hubbard]

On 4/2/24 5:55 AM, David Hildenbrand wrote:

Let's fixup the remaining comments to consistently call that thing
"GUP-fast". With this change, we consistently call it "GUP-fast".

Reviewed-by: Mike Rapoport (IBM) 
Signed-off-by: David Hildenbrand 
---
  mm/filemap.c| 2 +-
  mm/khugepaged.c | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)


Yes, everything is changed over now, confirmed.

Reviewed-by: John Hubbard 


thanks,
--
John Hubbard
NVIDIA

Re: [PATCH v1 3/3] mm: use "GUP-fast" instead "fast GUP" in remaining comments

[Jason Gunthorpe]

On Tue, Apr 02, 2024 at 02:55:16PM +0200, David Hildenbrand wrote:
> Let's fixup the remaining comments to consistently call that thing
> "GUP-fast". With this change, we consistently call it "GUP-fast".
> 
> Reviewed-by: Mike Rapoport (IBM) 
> Signed-off-by: David Hildenbrand 
> ---
>  mm/filemap.c| 2 +-
>  mm/khugepaged.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Jason Gunthorpe 

Jason

[PATCH v1 3/3] mm: use "GUP-fast" instead "fast GUP" in remaining comments

[David Hildenbrand]

Let's fixup the remaining comments to consistently call that thing
"GUP-fast". With this change, we consistently call it "GUP-fast".

Reviewed-by: Mike Rapoport (IBM) 
Signed-off-by: David Hildenbrand 
---
 mm/filemap.c| 2 +-
 mm/khugepaged.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/filemap.c b/mm/filemap.c
index 387b394754fa..c668e11cd6ef 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -1810,7 +1810,7 @@ EXPORT_SYMBOL(page_cache_prev_miss);
  * C. Return the page to the page allocator
  *
  * This means that any page may have its reference count temporarily
- * increased by a speculative page cache (or fast GUP) lookup as it can
+ * increased by a speculative page cache (or GUP-fast) lookup as it can
  * be allocated by another user before the RCU grace period expires.
  * Because the refcount temporarily acquired here may end up being the
  * last refcount on the page, any page allocation must be freeable by
diff --git a/mm/khugepaged.c b/mm/khugepaged.c
index 38830174608f..6972fa05132e 100644
--- a/mm/khugepaged.c
+++ b/mm/khugepaged.c
@@ -1169,7 +1169,7 @@ static int collapse_huge_page(struct mm_struct *mm, 
unsigned long address,
 * huge and small TLB entries for the same virtual address to
 * avoid the risk of CPU bugs in that area.
 *
-* Parallel fast GUP is fine since fast GUP will back off when
+* Parallel GUP-fast is fine since GUP-fast will back off when
 * it detects PMD is changed.
 */
_pmd = pmdp_collapse_flush(vma, address, pmd);
-- 
2.44.0