[PATCH v2] cpufreq: ppc: Add missing #include asm/smp.h

2015-03-04 Thread Geert Uytterhoeven
If CONFIG_SMP=n, linux/smp.h does not include asm/smp.h, causing:

drivers/cpufreq/ppc-corenet-cpufreq.c: In function 'corenet_cpufreq_cpu_init':
drivers/cpufreq/ppc-corenet-cpufreq.c:173:3: error: implicit declaration of 
function 'get_hard_smp_processor_id' [-Werror=implicit-function-declaration]

Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be
---
Seen with e.g. corenet64_smp_defconfig + CONFIG_CPU_FREQ=y,
CONFIG_PPC_CORENET_CPUFREQ=y, CONFIG_SMP=n

v2:
  - Add comment for #include directive, as requested by Viresh
---
 drivers/cpufreq/ppc-corenet-cpufreq.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/cpufreq/ppc-corenet-cpufreq.c 
b/drivers/cpufreq/ppc-corenet-cpufreq.c
index bee5df7794d33d10..7cb4b766cf948d3f 100644
--- a/drivers/cpufreq/ppc-corenet-cpufreq.c
+++ b/drivers/cpufreq/ppc-corenet-cpufreq.c
@@ -22,6 +22,8 @@
 #include linux/smp.h
 #include sysdev/fsl_soc.h
 
+#include asm/smp.h   /* for get_hard_smp_processor_id() in UP configs */
+
 /**
  * struct cpu_data - per CPU data struct
  * @parent: the parent node of cpu clock
-- 
1.9.1

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v2] cpufreq: ppc: Add missing #include asm/smp.h

2015-03-04 Thread Rafael J. Wysocki
On Wednesday, March 04, 2015 12:56:20 PM Geert Uytterhoeven wrote:
 If CONFIG_SMP=n, linux/smp.h does not include asm/smp.h, causing:
 
 drivers/cpufreq/ppc-corenet-cpufreq.c: In function 'corenet_cpufreq_cpu_init':
 drivers/cpufreq/ppc-corenet-cpufreq.c:173:3: error: implicit declaration of 
 function 'get_hard_smp_processor_id' [-Werror=implicit-function-declaration]
 
 Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be
 ---
 Seen with e.g. corenet64_smp_defconfig + CONFIG_CPU_FREQ=y,
 CONFIG_PPC_CORENET_CPUFREQ=y, CONFIG_SMP=n
 
 v2:
   - Add comment for #include directive, as requested by Viresh

Applied, thanks!

 ---
  drivers/cpufreq/ppc-corenet-cpufreq.c | 2 ++
  1 file changed, 2 insertions(+)
 
 diff --git a/drivers/cpufreq/ppc-corenet-cpufreq.c 
 b/drivers/cpufreq/ppc-corenet-cpufreq.c
 index bee5df7794d33d10..7cb4b766cf948d3f 100644
 --- a/drivers/cpufreq/ppc-corenet-cpufreq.c
 +++ b/drivers/cpufreq/ppc-corenet-cpufreq.c
 @@ -22,6 +22,8 @@
  #include linux/smp.h
  #include sysdev/fsl_soc.h
  
 +#include asm/smp.h /* for get_hard_smp_processor_id() in UP configs */
 +
  /**
   * struct cpu_data - per CPU data struct
   * @parent: the parent node of cpu clock
 

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev