Re: [PATCH v2] powerpc/fsl_soc: Search all global-utilities nodes for rstccr

2010-10-07 Thread Kumar Gala

On Aug 31, 2010, at 5:44 PM, Matthew McClintock wrote:

 The first global-utilities node might not contain the rstcr
 property, so we should search all the nodes
 
 Signed-off-by: Matthew McClintock m...@freescale.com
 ---
 -Changed KERN_EMERG to KERN_ERR
 -Break if we do not find rstcr mapped
 -Restore of_put_node that was dropped
 
 arch/powerpc/sysdev/fsl_soc.c |   20 +---
 1 files changed, 13 insertions(+), 7 deletions(-)

applied to next

- k

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev


Re: [PATCH v2] powerpc/fsl_soc: Search all global-utilities nodes for rstccr

2010-09-01 Thread Timur Tabi
Matthew McClintock wrote:
 The first global-utilities node might not contain the rstcr
 property, so we should search all the nodes
 
 Signed-off-by: Matthew McClintock m...@freescale.com

Acked-by: Timur Tabi ti...@freescale.com


___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev


[PATCH v2] powerpc/fsl_soc: Search all global-utilities nodes for rstccr

2010-08-31 Thread Matthew McClintock
The first global-utilities node might not contain the rstcr
property, so we should search all the nodes

Signed-off-by: Matthew McClintock m...@freescale.com
---
-Changed KERN_EMERG to KERN_ERR
-Break if we do not find rstcr mapped
-Restore of_put_node that was dropped

 arch/powerpc/sysdev/fsl_soc.c |   20 +---
 1 files changed, 13 insertions(+), 7 deletions(-)

diff --git a/arch/powerpc/sysdev/fsl_soc.c b/arch/powerpc/sysdev/fsl_soc.c
index b91f7ac..6c67d9e 100644
--- a/arch/powerpc/sysdev/fsl_soc.c
+++ b/arch/powerpc/sysdev/fsl_soc.c
@@ -378,17 +378,23 @@ static __be32 __iomem *rstcr;
 static int __init setup_rstcr(void)
 {
struct device_node *np;
-   np = of_find_node_by_name(NULL, global-utilities);
-   if ((np  of_get_property(np, fsl,has-rstcr, NULL))) {
-   rstcr = of_iomap(np, 0) + 0xb0;
-   if (!rstcr)
-   printk (KERN_EMERG Error: reset control register 
-   not mapped!\n);
-   } else if (ppc_md.restart == fsl_rstcr_restart)
+
+   for_each_node_by_name(np, global-utilities) {
+   if ((of_get_property(np, fsl,has-rstcr, NULL))) {
+   rstcr = of_iomap(np, 0) + 0xb0;
+   if (!rstcr)
+   printk (KERN_ERR Error: reset control 
+   register not mapped!\n);
+   break;
+   }
+   }
+
+   if (!rstcr  ppc_md.restart == fsl_rstcr_restart)
printk(KERN_ERR No RSTCR register, warm reboot won't work\n);
 
if (np)
of_node_put(np);
+
return 0;
 }
 
-- 
1.6.6.1


___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev