Re: [PATCH v2] powerpc: Append linux_banner to exception information in xmon.

2015-12-02 Thread Stewart Smith
Rashmica Gupta  writes:
> Currently if you are in xmon without an oops etc. to view the kernel
> version you have to type "d $linux_banner" - not necessarily obvious. As
> this is useful information, append to the output of "e" command.
>
> Example output:
> $mon> e
> cpu 0x1: Vector: 0  at [c000f879ba80]
> pc: c0081718: sysrq_handle_xmon+0x68/0x80
> lr: c0081718: sysrq_handle_xmon+0x68/0x80
> sp: c000f879bbe0
>msr: 80009033
>   current = 0xc000f604d5c0
>   paca= 0xcfdc0480 softe: 0irq_happened: 0x01
> pid   = 2467, comm = bash
> Linux version 4.4.0-rc2-8-gc51af91c3ab3-dirty (rashmica@circle) (gcc
> version 5.1.1 20150629 (GCC) ) #45 SMP Wed Nov 25 10:25:12 AEDT 2015
>
> Signed-off-by: Rashmica Gupta 

+10,245,789

Acked-by: Stewart Smith 

If I had a dollar for every time this would have helped *this morning*,
I'd at least be buying you enough coffee for it to be problematic.

I'd be keen in it heading to stable@ fixing the actual problem of
"people can't actually include the damn kernel version in their bug
report" - but maybe somebody else can work out if this is something
that's likely to be accepted.

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v2] powerpc: Append linux_banner to exception information in xmon.

2015-11-25 Thread Denis Kirjanov
On 11/25/15, Rashmica Gupta  wrote:
> Currently if you are in xmon without an oops etc. to view the kernel
> version you have to type "d $linux_banner" - not necessarily obvious. As
> this is useful information, append to the output of "e" command.
>
> Example output:
> $mon> e
> cpu 0x1: Vector: 0  at [c000f879ba80]
> pc: c0081718: sysrq_handle_xmon+0x68/0x80
> lr: c0081718: sysrq_handle_xmon+0x68/0x80
> sp: c000f879bbe0
>msr: 80009033
>   current = 0xc000f604d5c0
>   paca= 0xcfdc0480 softe: 0irq_happened: 0x01
> pid   = 2467, comm = bash
> Linux version 4.4.0-rc2-8-gc51af91c3ab3-dirty (rashmica@circle) (gcc
> version 5.1.1 20150629 (GCC) ) #45 SMP Wed Nov 25 10:25:12 AEDT 2015
>
> Signed-off-by: Rashmica Gupta 
You forgot to update the subject line
> ---
> Added example output and word wrapping.
>
>  arch/powerpc/xmon/xmon.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c
> index df05bd2fca07..6d3d9d031aea 100644
> --- a/arch/powerpc/xmon/xmon.c
> +++ b/arch/powerpc/xmon/xmon.c
> @@ -1528,6 +1528,8 @@ static void excprint(struct pt_regs *fp)
>
>   if (trap == 0x700)
>   print_bug_trap(fp);
> +
> + printf(linux_banner);
>  }
>
>  static void prregs(struct pt_regs *fp)
> --
> 2.5.0
>
> ___
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v2] powerpc: Append linux_banner to exception information in xmon.

2015-11-25 Thread Michael Ellerman


On 25 November 2015 7:15:46 pm AEDT, Denis Kirjanov  
wrote:
>You forgot to update the subject line

That's OK I will fix it up when I apply it.

cheers
-- 
Sent from my Android phone with K-9 Mail. Please excuse my brevity.
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH v2] powerpc: Append linux_banner to exception information in xmon.

2015-11-24 Thread Rashmica Gupta
Currently if you are in xmon without an oops etc. to view the kernel
version you have to type "d $linux_banner" - not necessarily obvious. As
this is useful information, append to the output of "e" command.

Example output:
$mon> e
cpu 0x1: Vector: 0  at [c000f879ba80]
pc: c0081718: sysrq_handle_xmon+0x68/0x80
lr: c0081718: sysrq_handle_xmon+0x68/0x80
sp: c000f879bbe0
   msr: 80009033
  current = 0xc000f604d5c0
  paca= 0xcfdc0480   softe: 0irq_happened: 0x01
pid   = 2467, comm = bash
Linux version 4.4.0-rc2-8-gc51af91c3ab3-dirty (rashmica@circle) (gcc
version 5.1.1 20150629 (GCC) ) #45 SMP Wed Nov 25 10:25:12 AEDT 2015

Signed-off-by: Rashmica Gupta 
---
Added example output and word wrapping.

 arch/powerpc/xmon/xmon.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c
index df05bd2fca07..6d3d9d031aea 100644
--- a/arch/powerpc/xmon/xmon.c
+++ b/arch/powerpc/xmon/xmon.c
@@ -1528,6 +1528,8 @@ static void excprint(struct pt_regs *fp)
 
if (trap == 0x700)
print_bug_trap(fp);
+
+   printf(linux_banner);
 }
 
 static void prregs(struct pt_regs *fp)
-- 
2.5.0

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev