Re: [PATCH v2 3/3] drivers/block/z2ram: use ioremap_wt() instead of __ioremap(_PAGE_WRITETHRU)

2018-08-27 Thread Geert Uytterhoeven 
On Mon, Aug 27, 2018 at 6:10 PM Christophe Leroy
 wrote:
> _PAGE_WRITETHRU is a target specific flag. Prefer generic functions.
>
> Signed-off-by: Christophe Leroy 

>From a Zorro bus point of view:
Acked-by: Geert Uytterhoeven 

> --- a/drivers/block/z2ram.c
> +++ b/drivers/block/z2ram.c
> @@ -190,8 +190,7 @@ static int z2_open(struct block_device *bdev, fmode_t 
> mode)
> vfree(vmalloc (size));
> }
>
> -   vaddr = (unsigned long) __ioremap (paddr, size,
> -  _PAGE_WRITETHRU);
> +   vaddr = (unsigned long)ioremap_wt(paddr, size);
>
>  #else
> vaddr = (unsigned long)z_remap_nocache_nonser(paddr, size);

However, since the removal of APUS support, this file can no longer be
compiled on powerpc.

Gr{oetje,eeting}s,

Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

[PATCH v2 3/3] drivers/block/z2ram: use ioremap_wt() instead of __ioremap(_PAGE_WRITETHRU)

2018-08-27 Thread Christophe Leroy 
_PAGE_WRITETHRU is a target specific flag. Prefer generic functions.

Signed-off-by: Christophe Leroy 
---
 v2: no change

 drivers/block/z2ram.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/block/z2ram.c b/drivers/block/z2ram.c
index d0c5bc4e0703..cfbd70520eeb 100644
--- a/drivers/block/z2ram.c
+++ b/drivers/block/z2ram.c
@@ -190,8 +190,7 @@ static int z2_open(struct block_device *bdev, fmode_t mode)
vfree(vmalloc (size));
}
 
-   vaddr = (unsigned long) __ioremap (paddr, size, 
-  _PAGE_WRITETHRU);
+   vaddr = (unsigned long)ioremap_wt(paddr, size);
 
 #else
vaddr = (unsigned long)z_remap_nocache_nonser(paddr, size);
-- 
2.13.3