Re: [PATCH v2 5/7] mm/treewide: Replace pmd_large() with pmd_leaf()

2024-03-04 Thread Jason Gunthorpe
On Thu, Feb 29, 2024 at 04:42:56PM +0800, pet...@redhat.com wrote:
> From: Peter Xu 
> 
> pmd_large() is always defined as pmd_leaf().  Merge their usages.  Chose
> pmd_leaf() because pmd_leaf() is a global API, while pmd_large() is not.
> 
> Signed-off-by: Peter Xu 
> ---
>  arch/arm/mm/dump.c   |  4 ++--
>  arch/powerpc/mm/book3s64/pgtable.c   |  2 +-
>  arch/powerpc/mm/book3s64/radix_pgtable.c |  2 +-
>  arch/powerpc/mm/pgtable_64.c |  2 +-
>  arch/s390/boot/vmem.c|  2 +-
>  arch/s390/include/asm/pgtable.h  |  8 
>  arch/s390/mm/gmap.c  | 12 ++--
>  arch/s390/mm/hugetlbpage.c   |  2 +-
>  arch/s390/mm/pageattr.c  |  2 +-
>  arch/s390/mm/pgtable.c   |  6 +++---
>  arch/s390/mm/vmem.c  |  6 +++---
>  arch/sparc/mm/init_64.c  |  4 ++--
>  arch/x86/boot/compressed/ident_map_64.c  |  2 +-
>  arch/x86/kvm/mmu/mmu.c   |  2 +-
>  arch/x86/mm/fault.c  |  8 
>  arch/x86/mm/init_32.c|  2 +-
>  arch/x86/mm/init_64.c|  8 
>  arch/x86/mm/kasan_init_64.c  |  2 +-
>  arch/x86/mm/mem_encrypt_identity.c   |  4 ++--
>  arch/x86/mm/pat/set_memory.c |  4 ++--
>  arch/x86/mm/pgtable.c|  2 +-
>  arch/x86/mm/pti.c|  4 ++--
>  arch/x86/power/hibernate.c   |  2 +-
>  arch/x86/xen/mmu_pv.c|  4 ++--
>  drivers/misc/sgi-gru/grufault.c  |  2 +-
>  25 files changed, 49 insertions(+), 49 deletions(-)

Reviewed-by: Jason Gunthorpe 

Jason


[PATCH v2 5/7] mm/treewide: Replace pmd_large() with pmd_leaf()

2024-02-29 Thread peterx
From: Peter Xu 

pmd_large() is always defined as pmd_leaf().  Merge their usages.  Chose
pmd_leaf() because pmd_leaf() is a global API, while pmd_large() is not.

Signed-off-by: Peter Xu 
---
 arch/arm/mm/dump.c   |  4 ++--
 arch/powerpc/mm/book3s64/pgtable.c   |  2 +-
 arch/powerpc/mm/book3s64/radix_pgtable.c |  2 +-
 arch/powerpc/mm/pgtable_64.c |  2 +-
 arch/s390/boot/vmem.c|  2 +-
 arch/s390/include/asm/pgtable.h  |  8 
 arch/s390/mm/gmap.c  | 12 ++--
 arch/s390/mm/hugetlbpage.c   |  2 +-
 arch/s390/mm/pageattr.c  |  2 +-
 arch/s390/mm/pgtable.c   |  6 +++---
 arch/s390/mm/vmem.c  |  6 +++---
 arch/sparc/mm/init_64.c  |  4 ++--
 arch/x86/boot/compressed/ident_map_64.c  |  2 +-
 arch/x86/kvm/mmu/mmu.c   |  2 +-
 arch/x86/mm/fault.c  |  8 
 arch/x86/mm/init_32.c|  2 +-
 arch/x86/mm/init_64.c|  8 
 arch/x86/mm/kasan_init_64.c  |  2 +-
 arch/x86/mm/mem_encrypt_identity.c   |  4 ++--
 arch/x86/mm/pat/set_memory.c |  4 ++--
 arch/x86/mm/pgtable.c|  2 +-
 arch/x86/mm/pti.c|  4 ++--
 arch/x86/power/hibernate.c   |  2 +-
 arch/x86/xen/mmu_pv.c|  4 ++--
 drivers/misc/sgi-gru/grufault.c  |  2 +-
 25 files changed, 49 insertions(+), 49 deletions(-)

diff --git a/arch/arm/mm/dump.c b/arch/arm/mm/dump.c
index a9381095ab36..cd032522d902 100644
--- a/arch/arm/mm/dump.c
+++ b/arch/arm/mm/dump.c
@@ -349,12 +349,12 @@ static void walk_pmd(struct pg_state *st, pud_t *pud, 
unsigned long start)
for (i = 0; i < PTRS_PER_PMD; i++, pmd++) {
addr = start + i * PMD_SIZE;
domain = get_domain_name(pmd);
-   if (pmd_none(*pmd) || pmd_large(*pmd) || !pmd_present(*pmd))
+   if (pmd_none(*pmd) || pmd_leaf(*pmd) || !pmd_present(*pmd))
note_page(st, addr, 4, pmd_val(*pmd), domain);
else
walk_pte(st, pmd, addr, domain);
 
-   if (SECTION_SIZE < PMD_SIZE && pmd_large(pmd[1])) {
+   if (SECTION_SIZE < PMD_SIZE && pmd_leaf(pmd[1])) {
addr += SECTION_SIZE;
pmd++;
domain = get_domain_name(pmd);
diff --git a/arch/powerpc/mm/book3s64/pgtable.c 
b/arch/powerpc/mm/book3s64/pgtable.c
index 3438ab72c346..45f526547b27 100644
--- a/arch/powerpc/mm/book3s64/pgtable.c
+++ b/arch/powerpc/mm/book3s64/pgtable.c
@@ -113,7 +113,7 @@ void set_pmd_at(struct mm_struct *mm, unsigned long addr,
 
WARN_ON(pte_hw_valid(pmd_pte(*pmdp)) && !pte_protnone(pmd_pte(*pmdp)));
assert_spin_locked(pmd_lockptr(mm, pmdp));
-   WARN_ON(!(pmd_large(pmd)));
+   WARN_ON(!(pmd_leaf(pmd)));
 #endif
trace_hugepage_set_pmd(addr, pmd_val(pmd));
return set_pte_at(mm, addr, pmdp_ptep(pmdp), pmd_pte(pmd));
diff --git a/arch/powerpc/mm/book3s64/radix_pgtable.c 
b/arch/powerpc/mm/book3s64/radix_pgtable.c
index 1f8db10693e3..5cc4008329be 100644
--- a/arch/powerpc/mm/book3s64/radix_pgtable.c
+++ b/arch/powerpc/mm/book3s64/radix_pgtable.c
@@ -924,7 +924,7 @@ bool vmemmap_can_optimize(struct vmem_altmap *altmap, 
struct dev_pagemap *pgmap)
 int __meminit vmemmap_check_pmd(pmd_t *pmdp, int node,
unsigned long addr, unsigned long next)
 {
-   int large = pmd_large(*pmdp);
+   int large = pmd_leaf(*pmdp);
 
if (large)
vmemmap_verify(pmdp_ptep(pmdp), node, addr, next);
diff --git a/arch/powerpc/mm/pgtable_64.c b/arch/powerpc/mm/pgtable_64.c
index 386c6b06eab7..9b99113cb51a 100644
--- a/arch/powerpc/mm/pgtable_64.c
+++ b/arch/powerpc/mm/pgtable_64.c
@@ -132,7 +132,7 @@ struct page *pmd_page(pmd_t pmd)
 * enabled so these checks can't be used.
 */
if (!IS_ENABLED(CONFIG_HAVE_ARCH_HUGE_VMAP))
-   VM_WARN_ON(!(pmd_large(pmd) || pmd_huge(pmd)));
+   VM_WARN_ON(!(pmd_leaf(pmd) || pmd_huge(pmd)));
return pte_page(pmd_pte(pmd));
}
return virt_to_page(pmd_page_vaddr(pmd));
diff --git a/arch/s390/boot/vmem.c b/arch/s390/boot/vmem.c
index e3a4500a5a75..348ab02b1028 100644
--- a/arch/s390/boot/vmem.c
+++ b/arch/s390/boot/vmem.c
@@ -333,7 +333,7 @@ static void pgtable_pmd_populate(pud_t *pud, unsigned long 
addr, unsigned long e
}
pte = boot_pte_alloc();
pmd_populate(_mm, pmd, pte);
-   } else if (pmd_large(*pmd)) {
+   } else if (pmd_leaf(*pmd)) {
continue;
}
pgtable_pte_populate(pmd, addr, next, mode);
diff --git