Re: [PATCH v3] ASoC: fsl: Convert to using %pOF instead of full_name

[Nicolin Chen]

On Mon, Aug 07, 2017 at 06:29:18PM -0500, Rob Herring wrote:
> Now that we have a custom printf format specifier, convert users of
> full_name to use %pOF instead. This is preparation to remove storing
> of the full path string for each node.
> 
> Signed-off-by: Rob Herring 
> Cc: Timur Tabi 
> Cc: Nicolin Chen 

Acked-by: Nicolin Chen 

Thanks

> Cc: Xiubo Li 
> Cc: Fabio Estevam 
> Cc: Liam Girdwood 
> Cc: Mark Brown 
> Cc: linuxppc-dev@lists.ozlabs.org
> Cc: alsa-de...@alsa-project.org
> ---
> v3: Split ASoC changes to separate patch
> 
>  sound/soc/fsl/fsl_dma.c|  4 ++--
>  sound/soc/fsl/imx-audmux.c | 16 
>  2 files changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/sound/soc/fsl/fsl_dma.c b/sound/soc/fsl/fsl_dma.c
> index ccadefceeff2..ed8ea002902d 100644
> --- a/sound/soc/fsl/fsl_dma.c
> +++ b/sound/soc/fsl/fsl_dma.c
> @@ -897,8 +897,8 @@ static int fsl_soc_dma_probe(struct platform_device *pdev)
>  
>   ret = of_address_to_resource(ssi_np, 0, );
>   if (ret) {
> - dev_err(>dev, "could not determine resources for %s\n",
> - ssi_np->full_name);
> + dev_err(>dev, "could not determine resources for %pOF\n",
> + ssi_np);
>   of_node_put(ssi_np);
>   return ret;
>   }
> diff --git a/sound/soc/fsl/imx-audmux.c b/sound/soc/fsl/imx-audmux.c
> index fc57da341d61..392d5eef356d 100644
> --- a/sound/soc/fsl/imx-audmux.c
> +++ b/sound/soc/fsl/imx-audmux.c
> @@ -268,13 +268,13 @@ static int imx_audmux_parse_dt_defaults(struct 
> platform_device *pdev,
>  
>   ret = of_property_read_u32(child, "fsl,audmux-port", );
>   if (ret) {
> - dev_warn(>dev, "Failed to get fsl,audmux-port of 
> child node \"%s\"\n",
> - child->full_name);
> + dev_warn(>dev, "Failed to get fsl,audmux-port of 
> child node \"%pOF\"\n",
> + child);
>   continue;
>   }
>   if (!of_property_read_bool(child, "fsl,port-config")) {
> - dev_warn(>dev, "child node \"%s\" does not have 
> property fsl,port-config\n",
> - child->full_name);
> + dev_warn(>dev, "child node \"%pOF\" does not have 
> property fsl,port-config\n",
> + child);
>   continue;
>   }
>  
> @@ -292,15 +292,15 @@ static int imx_audmux_parse_dt_defaults(struct 
> platform_device *pdev,
>   }
>  
>   if (ret != -EOVERFLOW) {
> - dev_err(>dev, "Failed to read u32 at index %d of 
> child %s\n",
> - i, child->full_name);
> + dev_err(>dev, "Failed to read u32 at index %d of 
> child %pOF\n",
> + i, child);
>   continue;
>   }
>  
>   if (audmux_type == IMX31_AUDMUX) {
>   if (i % 2) {
> - dev_err(>dev, "One pdcr value is missing 
> in child node %s\n",
> - child->full_name);
> + dev_err(>dev, "One pdcr value is missing 
> in child node %pOF\n",
> + child);
>   continue;
>   }
>   imx_audmux_v2_configure_port(port, ptcr, pdcr);
> -- 
> 2.11.0
> 

[PATCH v3] ASoC: fsl: Convert to using %pOF instead of full_name

[Rob Herring]

Now that we have a custom printf format specifier, convert users of
full_name to use %pOF instead. This is preparation to remove storing
of the full path string for each node.

Signed-off-by: Rob Herring 
Cc: Timur Tabi 
Cc: Nicolin Chen 
Cc: Xiubo Li 
Cc: Fabio Estevam 
Cc: Liam Girdwood 
Cc: Mark Brown 
Cc: linuxppc-dev@lists.ozlabs.org
Cc: alsa-de...@alsa-project.org
---
v3: Split ASoC changes to separate patch

 sound/soc/fsl/fsl_dma.c|  4 ++--
 sound/soc/fsl/imx-audmux.c | 16 
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/sound/soc/fsl/fsl_dma.c b/sound/soc/fsl/fsl_dma.c
index ccadefceeff2..ed8ea002902d 100644
--- a/sound/soc/fsl/fsl_dma.c
+++ b/sound/soc/fsl/fsl_dma.c
@@ -897,8 +897,8 @@ static int fsl_soc_dma_probe(struct platform_device *pdev)
 
ret = of_address_to_resource(ssi_np, 0, );
if (ret) {
-   dev_err(>dev, "could not determine resources for %s\n",
-   ssi_np->full_name);
+   dev_err(>dev, "could not determine resources for %pOF\n",
+   ssi_np);
of_node_put(ssi_np);
return ret;
}
diff --git a/sound/soc/fsl/imx-audmux.c b/sound/soc/fsl/imx-audmux.c
index fc57da341d61..392d5eef356d 100644
--- a/sound/soc/fsl/imx-audmux.c
+++ b/sound/soc/fsl/imx-audmux.c
@@ -268,13 +268,13 @@ static int imx_audmux_parse_dt_defaults(struct 
platform_device *pdev,
 
ret = of_property_read_u32(child, "fsl,audmux-port", );
if (ret) {
-   dev_warn(>dev, "Failed to get fsl,audmux-port of 
child node \"%s\"\n",
-   child->full_name);
+   dev_warn(>dev, "Failed to get fsl,audmux-port of 
child node \"%pOF\"\n",
+   child);
continue;
}
if (!of_property_read_bool(child, "fsl,port-config")) {
-   dev_warn(>dev, "child node \"%s\" does not have 
property fsl,port-config\n",
-   child->full_name);
+   dev_warn(>dev, "child node \"%pOF\" does not have 
property fsl,port-config\n",
+   child);
continue;
}
 
@@ -292,15 +292,15 @@ static int imx_audmux_parse_dt_defaults(struct 
platform_device *pdev,
}
 
if (ret != -EOVERFLOW) {
-   dev_err(>dev, "Failed to read u32 at index %d of 
child %s\n",
-   i, child->full_name);
+   dev_err(>dev, "Failed to read u32 at index %d of 
child %pOF\n",
+   i, child);
continue;
}
 
if (audmux_type == IMX31_AUDMUX) {
if (i % 2) {
-   dev_err(>dev, "One pdcr value is missing 
in child node %s\n",
-   child->full_name);
+   dev_err(>dev, "One pdcr value is missing 
in child node %pOF\n",
+   child);
continue;
}
imx_audmux_v2_configure_port(port, ptcr, pdcr);
-- 
2.11.0