Re: [PATCH v3 0/4 REPOST] OF infrastructure for SPI devices
On 7/25/08, Jon Smirl <[EMAIL PROTECTED]> wrote:
> On 7/25/08, Grant Likely <[EMAIL PROTECTED]> wrote:
> > I don't know what to do with these patches. I'd really like to see them
> > in .27, and now that akpm has cleared his queue, the prerequisite patch
> > has been merged so they are ready to go in. However, even though there
> > has been favourable reception on the SPI and linuxppc lists for these
> > changes I don't have any acks from anybody yet.
>
>
> I have compatible hardware but it has an MMC card socket hooked up. I
> haven't figured out yet how to get this driver hooked to the MMC
> subsystem and make the file system on the card work. (I've been
> working on ALSA).
>
> I believe I need this:
> http://lkml.org/lkml/2008/6/5/209
>
> Then I need to get everything hooked together. Point me in the right
> direction and I can help with testing.
Grant, your SPI driver works with MMC cards. I needed to add the patch
noted above.
http://lkml.org/lkml/2008/6/5/209
What's the status of merging Anton's patch?
And then tweak names until everything matches.
[EMAIL PROTECTED] {
#address-cells = <1>;
#size-cells = <0>;
compatible = "fsl,mpc5200b-spi","fsl,mpc5200-spi";
reg = <0xf00 0x20>;
interrupts = <0x2 0xd 0x0 0x2 0xe 0x0>;
interrupt-parent = <&mpc5200_pic>;
[EMAIL PROTECTED] {
compatible = "linux,mmc-spi";
reg = <0>;
spi-max-frequency = <2000>;
/* Unregulated slot. */
voltage-range = <3300 3300>;
/*gpios = <&sdcsr_pio 1 0 /* WP */
/* &sdcsr_pio 0 1>; /* nCD */
};
};
diff --git a/drivers/mmc/host/mmc_spi.c b/drivers/mmc/host/mmc_spi.c
index 7503b81..eb056b9 100644
--- a/drivers/mmc/host/mmc_spi.c
+++ b/drivers/mmc/host/mmc_spi.c
@@ -1400,7 +1400,7 @@ static int __devexit mmc_spi_remove(struct
spi_device *spi)
static struct spi_driver mmc_spi_driver = {
.driver = {
- .name = "mmc_spi",
+ .name = "mmc-spi",
.bus = &spi_bus_type,
.owner =THIS_MODULE,
},
diff --git a/drivers/of/of_mmc_spi.c b/drivers/of/of_mmc_spi.c
index aa4e017..f189cdb 100644
--- a/drivers/of/of_mmc_spi.c
+++ b/drivers/of/of_mmc_spi.c
@@ -95,7 +95,7 @@ static int of_mmc_spi_add(struct device *dev)
const u32 *voltage_range;
int size;
- if (!np || !of_device_is_compatible(np, "mmc-spi"))
+ if (!np || !of_device_is_compatible(np, "linux,mmc-spi"))
return NOTIFY_DONE;
oms = kzalloc(sizeof(*oms), GFP_KERNEL);
@@ -152,7 +152,7 @@ static int of_mmc_spi_del(struct device *dev)
struct device_node *np = dev->archdata.of_node;
struct of_mmc_spi *oms;
- if (!np || !of_device_is_compatible(np, "mmc-spi") ||
+ if (!np || !of_device_is_compatible(np, "linux,mmc-spi") ||
!dev->platform_data)
return NOTIFY_DONE;
--
Jon Smirl
[EMAIL PROTECTED]
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH v3 0/4 REPOST] OF infrastructure for SPI devices
On Sun, Jul 27, 2008 at 02:49:28PM -0700, David Brownell wrote: > On Friday 25 July 2008, Grant Likely wrote: > > I don't know what to do with these patches. I'd really like to see them > > in .27, and now that akpm has cleared his queue, the prerequisite patch > > has been merged so they are ready to go in. However, even though there > > has been favourable reception on the SPI and linuxppc lists for these > > changes I don't have any acks from anybody yet. > > > > David, can you please reply on if you are okay with these patches > > getting merged? If so, do you want me to merge them via my tree, or > > do you want to pick them up? > > OK ... to recap, #1 and #3 are OF-specific, I'll be agnostic. > If other OF folk think it's OK, great. > > Some cleanup was needed for #2, but it was basically ok ... > I'd like to see the final version, and if it goes via an > OF push that's OK by me. (Though I'd like to see that change > make it into 2.6.27 regardless, so let me know.) Thanks for the review. 1-3 is already merged into my git tree and Ben has pulled them. I hope that's okay. Here's a link to the commit: http://git.kernel.org/?p=linux/kernel/git/benh/powerpc.git;a=commitdiff;h=dc87c98e8f635a718f1abb2c3e15fc77c0001651 Let me know if you see anything else that needs to be changed and I'll submit a fixup patch. > And #4 isn't quite cooked yet. Okay, I'll hack on this more and post v4. Thanks again, g. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH v3 0/4 REPOST] OF infrastructure for SPI devices
On Friday 25 July 2008, Grant Likely wrote: > I don't know what to do with these patches. I'd really like to see them > in .27, and now that akpm has cleared his queue, the prerequisite patch > has been merged so they are ready to go in. However, even though there > has been favourable reception on the SPI and linuxppc lists for these > changes I don't have any acks from anybody yet. > > David, can you please reply on if you are okay with these patches > getting merged? If so, do you want me to merge them via my tree, or > do you want to pick them up? OK ... to recap, #1 and #3 are OF-specific, I'll be agnostic. If other OF folk think it's OK, great. Some cleanup was needed for #2, but it was basically ok ... I'd like to see the final version, and if it goes via an OF push that's OK by me. (Though I'd like to see that change make it into 2.6.27 regardless, so let me know.) And #4 isn't quite cooked yet. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH v3 0/4 REPOST] OF infrastructure for SPI devices
On 7/25/08, Grant Likely <[EMAIL PROTECTED]> wrote: > I don't know what to do with these patches. I'd really like to see them > in .27, and now that akpm has cleared his queue, the prerequisite patch > has been merged so they are ready to go in. However, even though there > has been favourable reception on the SPI and linuxppc lists for these > changes I don't have any acks from anybody yet. I have compatible hardware but it has an MMC card socket hooked up. I haven't figured out yet how to get this driver hooked to the MMC subsystem and make the file system on the card work. (I've been working on ALSA). I believe I need this: http://lkml.org/lkml/2008/6/5/209 Then I need to get everything hooked together. Point me in the right direction and I can help with testing. > > David, can you please reply on if you are okay with these patches > getting merged? If so, do you want me to merge them via my tree, or > do you want to pick them up? > > Thanks, > g. > > -- > Grant Likely, B.Sc. P.Eng. > Secret Lab Technologies Ltd. > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to [EMAIL PROTECTED] > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- Jon Smirl [EMAIL PROTECTED] ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
[PATCH v3 0/4 REPOST] OF infrastructure for SPI devices
I don't know what to do with these patches. I'd really like to see them in .27, and now that akpm has cleared his queue, the prerequisite patch has been merged so they are ready to go in. However, even though there has been favourable reception on the SPI and linuxppc lists for these changes I don't have any acks from anybody yet. David, can you please reply on if you are okay with these patches getting merged? If so, do you want me to merge them via my tree, or do you want to pick them up? Thanks, g. -- Grant Likely, B.Sc. P.Eng. Secret Lab Technologies Ltd. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
