Re: [PATCH v3 16/27] Mips/MSI: Save msi chip in pci sysdata

2014-10-26 Thread Yijing Wang 
On 2014/10/25 21:04, Ralf Baechle wrote:
 On Wed, Oct 15, 2014 at 11:07:04AM +0800, Yijing Wang wrote:
 
 +static inline struct msi_chip *pci_msi_chip(struct pci_bus *bus)
 +{
 +struct pci_controller *control = (struct pci_controller *)bus-sysdata;
 
 bus-sysdata is void * so this cast is unnecessary.

Yes, will update it, thanks!

 
   Ralf
 
 .
 


-- 
Thanks!
Yijing

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v3 16/27] Mips/MSI: Save msi chip in pci sysdata

2014-10-25 Thread Ralf Baechle 
On Wed, Oct 15, 2014 at 11:07:04AM +0800, Yijing Wang wrote:

 +static inline struct msi_chip *pci_msi_chip(struct pci_bus *bus)
 +{
 + struct pci_controller *control = (struct pci_controller *)bus-sysdata;

bus-sysdata is void * so this cast is unnecessary.

  Ralf
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH v3 16/27] Mips/MSI: Save msi chip in pci sysdata

2014-10-14 Thread Yijing Wang 
Save msi chip in pci sysdata, add arch pci_find_msi_chip()
to extract out msi chip.

Signed-off-by: Yijing Wang wangyij...@huawei.com
---
 arch/mips/include/asm/pci.h |   14 ++
 1 files changed, 14 insertions(+), 0 deletions(-)

diff --git a/arch/mips/include/asm/pci.h b/arch/mips/include/asm/pci.h
index 974b0e3..287661b 100644
--- a/arch/mips/include/asm/pci.h
+++ b/arch/mips/include/asm/pci.h
@@ -43,6 +43,9 @@ struct pci_controller {
 
int iommu;
 
+#ifdef CONFIG_PCI_MSI
+   struct msi_chip *msi_chip;
+#endif
/* Optional access methods for reading/writing the bus number
   of the PCI controller */
int (*get_busno)(void);
@@ -54,6 +57,17 @@ struct pci_controller {
  */
 extern void register_pci_controller(struct pci_controller *hose);
 
+#ifdef CONFIG_PCI_MSI
+
+static inline struct msi_chip *pci_msi_chip(struct pci_bus *bus)
+{
+   struct pci_controller *control = (struct pci_controller *)bus-sysdata;
+
+   return control-msi_chip;
+}
+
+#endif
+
 /*
  * board supplied pci irq fixup routine
  */
-- 
1.7.1

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev