Re: [PATCH v3 2/2] crypto: vmx - add missing dependencies
On Thu, Feb 17, 2022 at 11:57:51AM +0100, Petr Vorel wrote:
> vmx-crypto module depends on CRYPTO_AES, CRYPTO_CBC, CRYPTO_CTR or
> CRYPTO_XTS, thus add them.
>
> These dependencies are likely to be enabled, but if
> CRYPTO_DEV_VMX=y && !CRYPTO_MANAGER_DISABLE_TESTS
> and either of CRYPTO_AES, CRYPTO_CBC, CRYPTO_CTR or CRYPTO_XTS is built
> as module or disabled, alg_test() from crypto/testmgr.c complains during
> boot about failing to allocate the generic fallback implementations
> (2 == ENOENT):
>
> [0.540953] Failed to allocate xts(aes) fallback: -2
> [0.541014] alg: skcipher: failed to allocate transform for p8_aes_xts: -2
> [0.541120] alg: self-tests for p8_aes_xts (xts(aes)) failed (rc=-2)
> [0.50] Failed to allocate ctr(aes) fallback: -2
> [0.544497] alg: skcipher: failed to allocate transform for p8_aes_ctr: -2
> [0.544603] alg: self-tests for p8_aes_ctr (ctr(aes)) failed (rc=-2)
> [0.547992] Failed to allocate cbc(aes) fallback: -2
> [0.548052] alg: skcipher: failed to allocate transform for p8_aes_cbc: -2
> [0.548156] alg: self-tests for p8_aes_cbc (cbc(aes)) failed (rc=-2)
> [0.550745] Failed to allocate transformation for 'aes': -2
> [0.550801] alg: cipher: Failed to load transform for p8_aes: -2
> [0.550892] alg: self-tests for p8_aes (aes) failed (rc=-2)
>
> Fixes: c07f5d3da643 ("crypto: vmx - Adding support for XTS")
> Fixes: d2e3ae6f3aba ("crypto: vmx - Enabling VMX module for PPC64")
>
> Suggested-by: Nicolai Stange
> Signed-off-by: Petr Vorel
> ---
> changes v2->v3:
> * more less the same, just in drivers/crypto/Kconfig (previously it was
> in drivers/crypto/vmx/Kconfig)
> * change commit subject to be compatible
>
> drivers/crypto/Kconfig | 4
> 1 file changed, 4 insertions(+)
Please respin this patch to add the selects to the existing tristate.
Thanks,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
[PATCH v3 2/2] crypto: vmx - add missing dependencies
vmx-crypto module depends on CRYPTO_AES, CRYPTO_CBC, CRYPTO_CTR or
CRYPTO_XTS, thus add them.
These dependencies are likely to be enabled, but if
CRYPTO_DEV_VMX=y && !CRYPTO_MANAGER_DISABLE_TESTS
and either of CRYPTO_AES, CRYPTO_CBC, CRYPTO_CTR or CRYPTO_XTS is built
as module or disabled, alg_test() from crypto/testmgr.c complains during
boot about failing to allocate the generic fallback implementations
(2 == ENOENT):
[0.540953] Failed to allocate xts(aes) fallback: -2
[0.541014] alg: skcipher: failed to allocate transform for p8_aes_xts: -2
[0.541120] alg: self-tests for p8_aes_xts (xts(aes)) failed (rc=-2)
[0.50] Failed to allocate ctr(aes) fallback: -2
[0.544497] alg: skcipher: failed to allocate transform for p8_aes_ctr: -2
[0.544603] alg: self-tests for p8_aes_ctr (ctr(aes)) failed (rc=-2)
[0.547992] Failed to allocate cbc(aes) fallback: -2
[0.548052] alg: skcipher: failed to allocate transform for p8_aes_cbc: -2
[0.548156] alg: self-tests for p8_aes_cbc (cbc(aes)) failed (rc=-2)
[0.550745] Failed to allocate transformation for 'aes': -2
[0.550801] alg: cipher: Failed to load transform for p8_aes: -2
[0.550892] alg: self-tests for p8_aes (aes) failed (rc=-2)
Fixes: c07f5d3da643 ("crypto: vmx - Adding support for XTS")
Fixes: d2e3ae6f3aba ("crypto: vmx - Enabling VMX module for PPC64")
Suggested-by: Nicolai Stange
Signed-off-by: Petr Vorel
---
changes v2->v3:
* more less the same, just in drivers/crypto/Kconfig (previously it was
in drivers/crypto/vmx/Kconfig)
* change commit subject to be compatible
drivers/crypto/Kconfig | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
index 923fa1effb4a..0eafb2a49f04 100644
--- a/drivers/crypto/Kconfig
+++ b/drivers/crypto/Kconfig
@@ -764,7 +764,11 @@ config CRYPTO_DEV_QCOM_RNG
config CRYPTO_DEV_VMX
tristate "Power VMX cryptographic acceleration instructions driver"
depends on PPC64 && VSX
+ select CRYPTO_AES
+ select CRYPTO_CBC
+ select CRYPTO_CTR
select CRYPTO_GHASH
+ select CRYPTO_XTS
help
Support for VMX cryptographic acceleration instructions on Power8 CPU.
This module supports acceleration for AES and GHASH in hardware. If
you
--
2.35.1
