[PATCH v3 8/8] x86: switch to using asm-generic for seccomp.h

2015-03-04 Thread Kees Cook
Switch to using the newly created asm-generic/seccomp.h for the seccomp
strict mode syscall definitions. The obsolete sigreturn syscall override
is retained in 32-bit mode, and the ia32 syscall overrides are used in
the compat case. Remaining definitions were identical.

Signed-off-by: Kees Cook keesc...@chromium.org
---
 arch/x86/include/asm/seccomp.h| 21 ++---
 arch/x86/include/asm/seccomp_32.h | 11 ---
 arch/x86/include/asm/seccomp_64.h | 17 -
 3 files changed, 18 insertions(+), 31 deletions(-)
 delete mode 100644 arch/x86/include/asm/seccomp_32.h
 delete mode 100644 arch/x86/include/asm/seccomp_64.h

diff --git a/arch/x86/include/asm/seccomp.h b/arch/x86/include/asm/seccomp.h
index 0f3d7f099224..0c8c7c8861b4 100644
--- a/arch/x86/include/asm/seccomp.h
+++ b/arch/x86/include/asm/seccomp.h
@@ -1,5 +1,20 @@
+#ifndef _ASM_X86_SECCOMP_H
+#define _ASM_X86_SECCOMP_H
+
+#include asm/unistd.h
+
 #ifdef CONFIG_X86_32
-# include asm/seccomp_32.h
-#else
-# include asm/seccomp_64.h
+#define __NR_seccomp_sigreturn __NR_sigreturn
 #endif
+
+#ifdef CONFIG_COMPAT
+#include asm/ia32_unistd.h
+#define __NR_seccomp_read_32   __NR_ia32_read
+#define __NR_seccomp_write_32  __NR_ia32_write
+#define __NR_seccomp_exit_32   __NR_ia32_exit
+#define __NR_seccomp_sigreturn_32  __NR_ia32_sigreturn
+#endif
+
+#include asm-generic/seccomp.h
+
+#endif /* _ASM_X86_SECCOMP_H */
diff --git a/arch/x86/include/asm/seccomp_32.h 
b/arch/x86/include/asm/seccomp_32.h
deleted file mode 100644
index b811d6f5780c..
--- a/arch/x86/include/asm/seccomp_32.h
+++ /dev/null
@@ -1,11 +0,0 @@
-#ifndef _ASM_X86_SECCOMP_32_H
-#define _ASM_X86_SECCOMP_32_H
-
-#include linux/unistd.h
-
-#define __NR_seccomp_read __NR_read
-#define __NR_seccomp_write __NR_write
-#define __NR_seccomp_exit __NR_exit
-#define __NR_seccomp_sigreturn __NR_sigreturn
-
-#endif /* _ASM_X86_SECCOMP_32_H */
diff --git a/arch/x86/include/asm/seccomp_64.h 
b/arch/x86/include/asm/seccomp_64.h
deleted file mode 100644
index 84ec1bd161a5..
--- a/arch/x86/include/asm/seccomp_64.h
+++ /dev/null
@@ -1,17 +0,0 @@
-#ifndef _ASM_X86_SECCOMP_64_H
-#define _ASM_X86_SECCOMP_64_H
-
-#include linux/unistd.h
-#include asm/ia32_unistd.h
-
-#define __NR_seccomp_read __NR_read
-#define __NR_seccomp_write __NR_write
-#define __NR_seccomp_exit __NR_exit
-#define __NR_seccomp_sigreturn __NR_rt_sigreturn
-
-#define __NR_seccomp_read_32 __NR_ia32_read
-#define __NR_seccomp_write_32 __NR_ia32_write
-#define __NR_seccomp_exit_32 __NR_ia32_exit
-#define __NR_seccomp_sigreturn_32 __NR_ia32_sigreturn
-
-#endif /* _ASM_X86_SECCOMP_64_H */
-- 
1.9.1

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v3 8/8] x86: switch to using asm-generic for seccomp.h

2015-03-04 Thread Ingo Molnar

* Kees Cook keesc...@chromium.org wrote:

 Switch to using the newly created asm-generic/seccomp.h for the 
 seccomp strict mode syscall definitions. The obsolete sigreturn 
 syscall override is retained in 32-bit mode, and the ia32 syscall 
 overrides are used in the compat case. Remaining definitions were 
 identical.
 
 Signed-off-by: Kees Cook keesc...@chromium.org

Acked-by: Ingo Molnar mi...@kernel.org

Thanks,

Ingo
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev