Re: [PATCH v4 0/2] powerpc/512x: add LocalPlus Bus FIFO device driver
On Tue, Oct 27, 2015 at 11:42:57PM +0300, Alexander Popov wrote: > >> Hello, > >> > >> I've done my best to fix the issues pointed by Timur Tabi and Vinod Koul. > >> Could I have a feedback please? > > > > I dont see to have v4 in my list :( Can you please repost > > Hello, Vinod > > I'm sure I haven't miss your address in the list of the recipients. > Anyway I can repost. > > Anatolij Gustschin wrote that he applied v4 with some fix to mpc5xxx/next > some time ago. Okay, I though these were dmaengine patches but looking back they seemed to be for arch code, so nothing to do here for me and then you :) > So should I repost v4 for everybody? How should I mark the reposted patches? Its merged so fine with me -- ~Vinod ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH v4 0/2] powerpc/512x: add LocalPlus Bus FIFO device driver
On 27.10.2015 05:22, Vinod Koul wrote: > On Thu, Oct 22, 2015 at 01:15:03AM +0300, Alexander Popov wrote: >> On 12.10.2015 00:08, Alexander Popov wrote: >>> This driver for Freescale MPC512x LocalPlus Bus FIFO (called SCLPC >>> in the Reference Manual) allows Direct Memory Access transfers >>> between RAM and peripheral devices on LocalPlus Bus. >> >>> Changes in v4: >>> - the race condition is fixed; >>> - plenty of style fixes are made; >>> - devm_* functions and EPROBE_DEFER are used in probe(). >> >> Hello, >> >> I've done my best to fix the issues pointed by Timur Tabi and Vinod Koul. >> Could I have a feedback please? > > I dont see to have v4 in my list :( Can you please repost Hello, Vinod I'm sure I haven't miss your address in the list of the recipients. Anyway I can repost. Anatolij Gustschin wrote that he applied v4 with some fix to mpc5xxx/next some time ago. So should I repost v4 for everybody? How should I mark the reposted patches? Best regards, Alexander ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH v4 0/2] powerpc/512x: add LocalPlus Bus FIFO device driver
On Thu, Oct 22, 2015 at 01:15:03AM +0300, Alexander Popov wrote: > On 12.10.2015 00:08, Alexander Popov wrote: > > This driver for Freescale MPC512x LocalPlus Bus FIFO (called SCLPC > > in the Reference Manual) allows Direct Memory Access transfers > > between RAM and peripheral devices on LocalPlus Bus. > > > Changes in v4: > > - the race condition is fixed; > > - plenty of style fixes are made; > > - devm_* functions and EPROBE_DEFER are used in probe(). > > Hello, > > I've done my best to fix the issues pointed by Timur Tabi and Vinod Koul. > Could I have a feedback please? I dont see to have v4 in my list :( Can you please repost -- ~Vinod ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH v4 0/2] powerpc/512x: add LocalPlus Bus FIFO device driver
On 12.10.2015 00:08, Alexander Popov wrote: > This driver for Freescale MPC512x LocalPlus Bus FIFO (called SCLPC > in the Reference Manual) allows Direct Memory Access transfers > between RAM and peripheral devices on LocalPlus Bus. > Changes in v4: > - the race condition is fixed; > - plenty of style fixes are made; > - devm_* functions and EPROBE_DEFER are used in probe(). Hello, I've done my best to fix the issues pointed by Timur Tabi and Vinod Koul. Could I have a feedback please? Best regards, Alexander ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
[PATCH v4 0/2] powerpc/512x: add LocalPlus Bus FIFO device driver
This driver for Freescale MPC512x LocalPlus Bus FIFO (called SCLPC in the Reference Manual) allows Direct Memory Access transfers between RAM and peripheral devices on LocalPlus Bus. Changes in v3: - resource usage in probe() is fixed; - driver methods are made safe against remove(); - dma_request_slave_channel() is used to get DMA channel number from the device tree; - chip select number concerned with the DMA transaction is determined from 'localbus' device tree node information; - register set is described as a structure; - symbolic names are given to shift counts to keep magic numbers out of the code; - choosing values for LPBFIFO BPT (bytes per transfer) and DMA maxburst is improved, so DMA transfer size has increased for some cases; - device tree binding for LPBFIFO is documented; - Kconfig and Makefile are improved; - email address "a13xp0p0...@gmail.com" is changed to a more pleasant alias "alex.po...@linux.com". Changes in v4: - the race condition is fixed; - plenty of style fixes are made; - devm_* functions and EPROBE_DEFER are used in probe(). Alexander Popov (2): powerpc/512x: add LocalPlus Bus FIFO device driver powerpc/512x: add a device tree binding for LocalPlus Bus FIFO .../bindings/powerpc/fsl/mpc512x_lpbfifo.txt | 21 + arch/powerpc/boot/dts/mpc5121.dtsi | 11 +- arch/powerpc/boot/dts/mpc5125twr.dts | 11 +- arch/powerpc/configs/mpc512x_defconfig | 1 + arch/powerpc/include/asm/mpc5121.h | 59 +++ arch/powerpc/platforms/512x/Kconfig| 6 + arch/powerpc/platforms/512x/Makefile | 1 + arch/powerpc/platforms/512x/mpc512x_lpbfifo.c | 539 + 8 files changed, 646 insertions(+), 3 deletions(-) create mode 100644 Documentation/devicetree/bindings/powerpc/fsl/mpc512x_lpbfifo.txt create mode 100644 arch/powerpc/platforms/512x/mpc512x_lpbfifo.c -- 1.9.1 ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
