Re: [PATCH v4 0/6] allow ramoops to collect all kmesg_dump events

2020-05-15 Thread Pavel Tatashin
On Fri, May 15, 2020 at 2:44 PM Kees Cook  wrote:
>
> Hello!
>
> I wanted to get the pstore tree nailed down, so here's the v4 of
> Pavel's series, tweaked for the feedback during v3 review.

Hi Kees,

Thank you, I was planning to send a new version of this series later
today. Let me quickly review it.

Pasha

>
> -Kees
>
> v4:
> - rebase on pstore tree
> - collapse shutdown types into a single dump reason
>   
> https://lore.kernel.org/lkml/ca+ck2bapv5u1ih5y9t5funtyximtfctdyxjcpuyjoyhnokr...@mail.gmail.com/
> - fix dump_oops vs max_reason module params
>   https://lore.kernel.org/lkml/20200512233504.GA118720@sequoia/
> - typos
>   
> https://lore.kernel.org/lkml/4cdeaa2af2fe0d6cc2ca8ce3a37608340799df8a.ca...@perches.com/
> - rename DT parsing routines ..._size -> ..._u32
>   
> https://lore.kernel.org/lkml/ca+ck2bcu8efomiu+nebjvn-o2dbuecxwrfssnjb3ys3cacb...@mail.gmail.com/
> v3: https://lore.kernel.org/lkml/20200506211523.15077-1-keesc...@chromium.org/
> v2: 
> https://lore.kernel.org/lkml/20200505154510.93506-1-pasha.tatas...@soleen.com
> v1: 
> https://lore.kernel.org/lkml/20200502143555.543636-1-pasha.tatas...@soleen.com
>
> Kees Cook (3):
>   printk: Collapse shutdown types into a single dump reason
>   printk: Introduce kmsg_dump_reason_str()
>   pstore/ram: Introduce max_reason and convert dump_oops
>
> Pavel Tatashin (3):
>   printk: honor the max_reason field in kmsg_dumper
>   pstore/platform: Pass max_reason to kmesg dump
>   ramoops: Add max_reason optional field to ramoops DT node
>
>  Documentation/admin-guide/ramoops.rst | 14 +++--
>  .../bindings/reserved-memory/ramoops.txt  | 13 -
>  arch/powerpc/kernel/nvram_64.c|  4 +-
>  drivers/platform/chrome/chromeos_pstore.c |  2 +-
>  fs/pstore/platform.c  | 26 ++---
>  fs/pstore/ram.c   | 58 +--
>  include/linux/kmsg_dump.h | 12 +++-
>  include/linux/pstore.h|  7 +++
>  include/linux/pstore_ram.h|  2 +-
>  kernel/printk/printk.c| 32 --
>  kernel/reboot.c   |  6 +-
>  11 files changed, 114 insertions(+), 62 deletions(-)
>
> --
> 2.20.1
>


[PATCH v4 0/6] allow ramoops to collect all kmesg_dump events

2020-05-15 Thread Kees Cook
Hello!

I wanted to get the pstore tree nailed down, so here's the v4 of
Pavel's series, tweaked for the feedback during v3 review.

-Kees

v4:
- rebase on pstore tree
- collapse shutdown types into a single dump reason
  
https://lore.kernel.org/lkml/ca+ck2bapv5u1ih5y9t5funtyximtfctdyxjcpuyjoyhnokr...@mail.gmail.com/
- fix dump_oops vs max_reason module params
  https://lore.kernel.org/lkml/20200512233504.GA118720@sequoia/
- typos
  
https://lore.kernel.org/lkml/4cdeaa2af2fe0d6cc2ca8ce3a37608340799df8a.ca...@perches.com/
- rename DT parsing routines ..._size -> ..._u32
  
https://lore.kernel.org/lkml/ca+ck2bcu8efomiu+nebjvn-o2dbuecxwrfssnjb3ys3cacb...@mail.gmail.com/
v3: https://lore.kernel.org/lkml/20200506211523.15077-1-keesc...@chromium.org/
v2: 
https://lore.kernel.org/lkml/20200505154510.93506-1-pasha.tatas...@soleen.com
v1: 
https://lore.kernel.org/lkml/20200502143555.543636-1-pasha.tatas...@soleen.com

Kees Cook (3):
  printk: Collapse shutdown types into a single dump reason
  printk: Introduce kmsg_dump_reason_str()
  pstore/ram: Introduce max_reason and convert dump_oops

Pavel Tatashin (3):
  printk: honor the max_reason field in kmsg_dumper
  pstore/platform: Pass max_reason to kmesg dump
  ramoops: Add max_reason optional field to ramoops DT node

 Documentation/admin-guide/ramoops.rst | 14 +++--
 .../bindings/reserved-memory/ramoops.txt  | 13 -
 arch/powerpc/kernel/nvram_64.c|  4 +-
 drivers/platform/chrome/chromeos_pstore.c |  2 +-
 fs/pstore/platform.c  | 26 ++---
 fs/pstore/ram.c   | 58 +--
 include/linux/kmsg_dump.h | 12 +++-
 include/linux/pstore.h|  7 +++
 include/linux/pstore_ram.h|  2 +-
 kernel/printk/printk.c| 32 --
 kernel/reboot.c   |  6 +-
 11 files changed, 114 insertions(+), 62 deletions(-)

-- 
2.20.1