Re: [PATCH v4 RESEND 0/3] sed-opal: keyrings, discovery, revert, key store
On Mon, 2023-06-05 at 15:14 -0600, Jens Axboe wrote: > On 6/1/23 4:37PM, gjo...@linux.vnet.ibm.com wrote: > > From: Greg Joyce > > > > This patchset has gone through numerous rounds of review and > > all comments/suggetions have been addressed. I believe that > > this patchset is ready for inclusion. > > > > TCG SED Opal is a specification from The Trusted Computing Group > > that allows self encrypting storage devices (SED) to be locked at > > power on and require an authentication key to unlock the drive. > > > > The current SED Opal implementation in the block driver > > requires that authentication keys be provided in an ioctl > > so that they can be presented to the underlying SED > > capable drive. Currently, the key is typically entered by > > a user with an application like sedutil or sedcli. While > > this process works, it does not lend itself to automation > > like unlock by a udev rule. > > > > The SED block driver has been extended so it can alternatively > > obtain a key from a sed-opal kernel keyring. The SED ioctls > > will indicate the source of the key, either directly in the > > ioctl data or from the keyring. > > > > Two new SED ioctls have also been added. These are: > > 1) IOC_OPAL_REVERT_LSP to revert LSP state > > 2) IOC_OPAL_DISCOVERY to discover drive capabilities/state > > > > change log v4: > > - rebase to 6.3-rc7 > > - replaced "255" magic number with U8_MAX > > None of this applies for for-6.5/block, and I'm a little puzzled > as to why you'd rebase to an old kernel rather than a 6.4-rc at > least? > > Please resend one that is current. Rebase to for-6.5/block coming shortly.
Re: [PATCH v4 RESEND 0/3] sed-opal: keyrings, discovery, revert, key store
On 6/1/23 4:37 PM, gjo...@linux.vnet.ibm.com wrote: > From: Greg Joyce > > This patchset has gone through numerous rounds of review and > all comments/suggetions have been addressed. I believe that > this patchset is ready for inclusion. > > TCG SED Opal is a specification from The Trusted Computing Group > that allows self encrypting storage devices (SED) to be locked at > power on and require an authentication key to unlock the drive. > > The current SED Opal implementation in the block driver > requires that authentication keys be provided in an ioctl > so that they can be presented to the underlying SED > capable drive. Currently, the key is typically entered by > a user with an application like sedutil or sedcli. While > this process works, it does not lend itself to automation > like unlock by a udev rule. > > The SED block driver has been extended so it can alternatively > obtain a key from a sed-opal kernel keyring. The SED ioctls > will indicate the source of the key, either directly in the > ioctl data or from the keyring. > > Two new SED ioctls have also been added. These are: > 1) IOC_OPAL_REVERT_LSP to revert LSP state > 2) IOC_OPAL_DISCOVERY to discover drive capabilities/state > > change log v4: > - rebase to 6.3-rc7 > - replaced "255" magic number with U8_MAX None of this applies for for-6.5/block, and I'm a little puzzled as to why you'd rebase to an old kernel rather than a 6.4-rc at least? Please resend one that is current. -- Jens Axboe
[PATCH v4 RESEND 0/3] sed-opal: keyrings, discovery, revert, key store
From: Greg Joyce This patchset has gone through numerous rounds of review and all comments/suggetions have been addressed. I believe that this patchset is ready for inclusion. TCG SED Opal is a specification from The Trusted Computing Group that allows self encrypting storage devices (SED) to be locked at power on and require an authentication key to unlock the drive. The current SED Opal implementation in the block driver requires that authentication keys be provided in an ioctl so that they can be presented to the underlying SED capable drive. Currently, the key is typically entered by a user with an application like sedutil or sedcli. While this process works, it does not lend itself to automation like unlock by a udev rule. The SED block driver has been extended so it can alternatively obtain a key from a sed-opal kernel keyring. The SED ioctls will indicate the source of the key, either directly in the ioctl data or from the keyring. Two new SED ioctls have also been added. These are: 1) IOC_OPAL_REVERT_LSP to revert LSP state 2) IOC_OPAL_DISCOVERY to discover drive capabilities/state change log v4: - rebase to 6.3-rc7 - replaced "255" magic number with U8_MAX change log: - rebase to 6.x - added latest reviews - removed platform functions for persistent key storage - replaced key update logic with key_create_or_update() - minor bracing and padding changes - add error returns - opal_key structure is application provided but kernel verified - added brief description of TCG SED Opal Greg Joyce (3): block: sed-opal: Implement IOC_OPAL_DISCOVERY block: sed-opal: Implement IOC_OPAL_REVERT_LSP block: sed-opal: keyring support for SED keys block/Kconfig | 2 + block/opal_proto.h| 4 + block/sed-opal.c | 252 +- include/linux/sed-opal.h | 5 + include/uapi/linux/sed-opal.h | 25 +++- 5 files changed, 282 insertions(+), 6 deletions(-) Signed-off-by: Greg Joyce base-commit: 6a8f57ae2eb07ab39a6f0ccad60c760743051026 -- gjo...@linux.vnet.ibm.com