Re: [PATCH v5 0/4] powerpc/pstore: Add pstore support for nvram partitions

2015-02-05 Thread Kees Cook
On Thu, Feb 5, 2015 at 11:35 AM, Hari Bathini
 wrote:
> This patch series adds pstore support on powernv platform to
> read different nvram partitions and write compressed data to
> oops-log nvram partition. As pseries platform already has
> pstore support, this series moves most of the common code
> for pseries and powernv platforms to a common file. Tested
> the patches successfully on both pseries and powernv
> platforms. Also, tested the patches successfully, on a kernel
> compiled with both CONFIG_PPC_PSERIES=y & CONFIG_PPC_POWERNV=y.
>
> Changes from v4:
> 1. Added a patch for y2038-safe code changes
>
> ---
>
> Hari Bathini (4):
>   powerpc/nvram: move generic code for nvram and pstore
>   pstore: Add pstore type id for PPC64 opal nvram partition
>   pstore: add pstore support on powernv
>   powerpc: make timestamp related code y2038-safe

Thanks! I skimmed this, and it looks good to me.

Reviewed-by: Kees Cook 

-Kees

>
>
>  arch/powerpc/include/asm/nvram.h|   50 ++
>  arch/powerpc/include/asm/rtas.h |5
>  arch/powerpc/kernel/nvram_64.c  |  677 
> +++
>  arch/powerpc/platforms/powernv/opal-nvram.c |   10
>  arch/powerpc/platforms/pseries/nvram.c  |  673 
> ---
>  fs/pstore/inode.c   |3
>  include/linux/pstore.h  |1
>  7 files changed, 754 insertions(+), 665 deletions(-)
>
> --
> -Hari
>



-- 
Kees Cook
Chrome OS Security
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH v5 0/4] powerpc/pstore: Add pstore support for nvram partitions

2015-02-05 Thread Hari Bathini
This patch series adds pstore support on powernv platform to
read different nvram partitions and write compressed data to
oops-log nvram partition. As pseries platform already has
pstore support, this series moves most of the common code
for pseries and powernv platforms to a common file. Tested
the patches successfully on both pseries and powernv
platforms. Also, tested the patches successfully, on a kernel
compiled with both CONFIG_PPC_PSERIES=y & CONFIG_PPC_POWERNV=y.

Changes from v4:
1. Added a patch for y2038-safe code changes

---

Hari Bathini (4):
  powerpc/nvram: move generic code for nvram and pstore
  pstore: Add pstore type id for PPC64 opal nvram partition
  pstore: add pstore support on powernv
  powerpc: make timestamp related code y2038-safe


 arch/powerpc/include/asm/nvram.h|   50 ++
 arch/powerpc/include/asm/rtas.h |5 
 arch/powerpc/kernel/nvram_64.c  |  677 +++
 arch/powerpc/platforms/powernv/opal-nvram.c |   10 
 arch/powerpc/platforms/pseries/nvram.c  |  673 ---
 fs/pstore/inode.c   |3 
 include/linux/pstore.h  |1 
 7 files changed, 754 insertions(+), 665 deletions(-)

--
-Hari

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev