[RFC/PATCH 24/32] usb: gadget: s3c-hsotg: let udc-core manage gadget-dev

2013-01-24 Thread Felipe Balbi 
By simply setting a flag, we can drop some
boilerplate code.

Signed-off-by: Felipe Balbi ba...@ti.com
---
 drivers/usb/gadget/s3c-hsotg.c | 14 +-
 1 file changed, 1 insertion(+), 13 deletions(-)

diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hsotg.c
index 833d85b..bd8292d 100644
--- a/drivers/usb/gadget/s3c-hsotg.c
+++ b/drivers/usb/gadget/s3c-hsotg.c
@@ -3552,17 +3552,13 @@ static int s3c_hsotg_probe(struct platform_device *pdev)
 
dev_info(dev, regs %p, irq %d\n, hsotg-regs, hsotg-irq);
 
-   device_initialize(hsotg-gadget.dev);
-
-   dev_set_name(hsotg-gadget.dev, gadget);
-
hsotg-gadget.max_speed = USB_SPEED_HIGH;
hsotg-gadget.ops = s3c_hsotg_gadget_ops;
hsotg-gadget.name = dev_name(dev);
-
hsotg-gadget.dev.parent = dev;
hsotg-gadget.dev.dma_mask = dev-dma_mask;
hsotg-gadget.dev.release = s3c_hsotg_release;
+   hsotg-gadget.register_my_device = true;
 
/* reset the system */
 
@@ -3643,12 +3639,6 @@ static int s3c_hsotg_probe(struct platform_device *pdev)
 
s3c_hsotg_phy_disable(hsotg);
 
-   ret = device_add(hsotg-gadget.dev);
-   if (ret) {
-   put_device(hsotg-gadget.dev);
-   goto err_ep_mem;
-   }
-
ret = usb_add_gadget_udc(pdev-dev, hsotg-gadget);
if (ret)
goto err_ep_mem;
@@ -3687,10 +3677,8 @@ static int s3c_hsotg_remove(struct platform_device *pdev)
}
 
s3c_hsotg_phy_disable(hsotg);
-
clk_disable_unprepare(hsotg-clk);
 
-   device_unregister(hsotg-gadget.dev);
return 0;
 }
 
-- 
1.8.1.rc1.5.g7e0651a

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [RFC/PATCH 24/32] usb: gadget: s3c-hsotg: let udc-core manage gadget-dev

2013-01-24 Thread Tomasz Figa 
Hi Felipe,

On Thursday 24 of January 2013 17:46:02 Felipe Balbi wrote:
 By simply setting a flag, we can drop some
 boilerplate code.
 
 Signed-off-by: Felipe Balbi ba...@ti.com
 ---
  drivers/usb/gadget/s3c-hsotg.c | 14 +-
  1 file changed, 1 insertion(+), 13 deletions(-)
 
 diff --git a/drivers/usb/gadget/s3c-hsotg.c
 b/drivers/usb/gadget/s3c-hsotg.c index 833d85b..bd8292d 100644
 --- a/drivers/usb/gadget/s3c-hsotg.c
 +++ b/drivers/usb/gadget/s3c-hsotg.c
 @@ -3552,17 +3552,13 @@ static int s3c_hsotg_probe(struct
 platform_device *pdev)
 
   dev_info(dev, regs %p, irq %d\n, hsotg-regs, hsotg-irq);
 
 - device_initialize(hsotg-gadget.dev);
 -
 - dev_set_name(hsotg-gadget.dev, gadget);
 -
   hsotg-gadget.max_speed = USB_SPEED_HIGH;
   hsotg-gadget.ops = s3c_hsotg_gadget_ops;
   hsotg-gadget.name = dev_name(dev);
 -
   hsotg-gadget.dev.parent = dev;
   hsotg-gadget.dev.dma_mask = dev-dma_mask;
   hsotg-gadget.dev.release = s3c_hsotg_release;
 + hsotg-gadget.register_my_device = true;
 
   /* reset the system */
 
 @@ -3643,12 +3639,6 @@ static int s3c_hsotg_probe(struct platform_device
 *pdev)
 
   s3c_hsotg_phy_disable(hsotg);
 
 - ret = device_add(hsotg-gadget.dev);
 - if (ret) {
 - put_device(hsotg-gadget.dev);
 - goto err_ep_mem;
 - }
 -
   ret = usb_add_gadget_udc(pdev-dev, hsotg-gadget);
   if (ret)
   goto err_ep_mem;
 @@ -3687,10 +3677,8 @@ static int s3c_hsotg_remove(struct
 platform_device *pdev) }
 
   s3c_hsotg_phy_disable(hsotg);
 -
   clk_disable_unprepare(hsotg-clk);
 
 - device_unregister(hsotg-gadget.dev);
   return 0;
  }

Looks good.

Reviewed-by: Tomasz Figa tomasz.f...@gmail.com

Best regards,
Tomasz Figa

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev