Re: [RFC PATCH v1 1/4] Revert "objtool: Enable objtool to run only on files with ftrace enabled"
Le 25/05/2022 à 18:34, Peter Zijlstra a écrit : > On Wed, May 25, 2022 at 05:58:14PM +0200, Christophe Leroy wrote: >> This reverts commit cf3013dfad89ad5ac7d16d56dced72d7c138a20e. >> >> That commit is problematic as we miss some static calls. > > Revert ?!?! who comitted this. And there's a ton more broken than just > static calls. This must absolutely not be. No worry, it is just a follow-up of my previous series which includes it.
Re: [RFC PATCH v1 1/4] Revert "objtool: Enable objtool to run only on files with ftrace enabled"
On Wed, May 25, 2022 at 05:58:14PM +0200, Christophe Leroy wrote: > This reverts commit cf3013dfad89ad5ac7d16d56dced72d7c138a20e. > > That commit is problematic as we miss some static calls. Revert ?!?! who comitted this. And there's a ton more broken than just static calls. This must absolutely not be.
[RFC PATCH v1 1/4] Revert "objtool: Enable objtool to run only on files with ftrace enabled"
This reverts commit cf3013dfad89ad5ac7d16d56dced72d7c138a20e. That commit is problematic as we miss some static calls. Signed-off-by: Christophe Leroy --- scripts/Makefile.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/Makefile.build b/scripts/Makefile.build index 06ceffd92921..2e0c3f9c1459 100644 --- a/scripts/Makefile.build +++ b/scripts/Makefile.build @@ -258,8 +258,8 @@ else # 'OBJECT_FILES_NON_STANDARD_foo.o := 'y': skip objtool checking for a file # 'OBJECT_FILES_NON_STANDARD_foo.o := 'n': override directory skip for a file -$(obj)/%.o: objtool-enabled = $(and $(if $(filter-out y%, $(OBJECT_FILES_NON_STANDARD_$(basetarget).o)$(OBJECT_FILES_NON_STANDARD)n),y), \ -$(if $(findstring $(strip $(CC_FLAGS_FTRACE)),$(_c_flags)),y),y) +$(obj)/%.o: objtool-enabled = $(if $(filter-out y%, \ + $(OBJECT_FILES_NON_STANDARD_$(basetarget).o)$(OBJECT_FILES_NON_STANDARD)n),y) endif -- 2.35.3
