Re: [patch 2/5] macintosh: qindfarm_smu_sat: semaphore to mutex

2008-05-04 Thread Benjamin Herrenschmidt

On Fri, 2008-05-02 at 13:34 -0700, [EMAIL PROTECTED] wrote:
> From: Daniel Walker <[EMAIL PROTECTED]>
> 
> Signed-off-by: Daniel Walker <[EMAIL PROTECTED]>

Acked-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]>

> Cc: Paul Mackerras <[EMAIL PROTECTED]>
> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
> ---


___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev


[patch 2/5] macintosh: qindfarm_smu_sat: semaphore to mutex

2008-05-02 Thread akpm
From: Daniel Walker <[EMAIL PROTECTED]>

Signed-off-by: Daniel Walker <[EMAIL PROTECTED]>
Cc: Benjamin Herrenschmidt <[EMAIL PROTECTED]>
Cc: Paul Mackerras <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
---

 drivers/macintosh/windfarm_smu_sat.c |   10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)

diff -puN 
drivers/macintosh/windfarm_smu_sat.c~macintosh-qindfarm_smu_sat-semaphore-to-mutex
 drivers/macintosh/windfarm_smu_sat.c
--- 
a/drivers/macintosh/windfarm_smu_sat.c~macintosh-qindfarm_smu_sat-semaphore-to-mutex
+++ a/drivers/macintosh/windfarm_smu_sat.c
@@ -13,7 +13,7 @@
 #include 
 #include 
 #include 
-#include 
+#include 
 #include 
 #include 
 #include 
@@ -36,7 +36,7 @@
 struct wf_sat {
int nr;
atomic_trefcnt;
-   struct semaphoremutex;
+   struct mutexmutex;
unsigned long   last_read; /* jiffies when cache last updated */
u8  cache[16];
struct i2c_client   i2c;
@@ -163,7 +163,7 @@ static int wf_sat_get(struct wf_sensor *
if (sat->i2c.adapter == NULL)
return -ENODEV;
 
-   down(&sat->mutex);
+   mutex_lock(&sat->mutex);
if (time_after(jiffies, (sat->last_read + MAX_AGE))) {
err = wf_sat_read_cache(sat);
if (err)
@@ -182,7 +182,7 @@ static int wf_sat_get(struct wf_sensor *
err = 0;
 
  fail:
-   up(&sat->mutex);
+   mutex_unlock(&sat->mutex);
return err;
 }
 
@@ -233,7 +233,7 @@ static void wf_sat_create(struct i2c_ada
sat->nr = -1;
sat->node = of_node_get(dev);
atomic_set(&sat->refcnt, 0);
-   init_MUTEX(&sat->mutex);
+   mutex_init(&sat->mutex);
sat->i2c.addr = (addr >> 1) & 0x7f;
sat->i2c.adapter = adapter;
sat->i2c.driver = &wf_sat_driver;
_
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev