RE: 1 GB lowmem

2008-05-22 Thread Rune Torgersen
Kumar Gala wrote:
> something like that would be good.  is there really anything PPC32
> specific about it? 

Apparently. The Kconfig option is only available for arch/powerpc and
arch/ppc, and the only place in the whole codetree where
CONFIG_TASK_SIZE is used is that particular spot in
asm-powerpc/processor.h, and that again is within CONFIG_PPC32 define,
so it seems only PPC32 is using TASK_SIZE.

___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev


FW: 1 GB lowmem

2008-05-22 Thread Rune Torgersen
Kumar Gala wrote:
> On May 21, 2008, at 4:24 PM, Rune Torgersen wrote:
> 
>> Kumar Gala wrote:
>>> On May 21, 2008, at 3:55 PM, Rune Torgersen wrote:
 Argh... Found it. Had to set CONFIG_TASK_SIZE to 0x8000. Now it
 works in both vaniulla an d RT kernel.
>>> 
>>> We should really add some sanity check on CONFIG_TASK_SIZE vs
>>> KERNEL_START.
>> 
>> Something like this?
>> Wording sould probablyy be a bit different/cleare.
>> 
>> diff --git a/include/asm-powerpc/processor.h
>> b/include/asm-powerpc/processor.h
>> index fd98ca9..72e0e3f 100644
>> --- a/include/asm-powerpc/processor.h
>> +++ b/include/asm-powerpc/processor.h
>> @@ -81,6 +81,10 @@ extern struct task_struct *last_task_used_altivec;
>> extern struct task_struct *last_task_used_spe;
>> 
>> #ifdef CONFIG_PPC32
>> +
>> +#if CONFIG_TASK_SIZE > CONFIG_KERNEL_START
>> +#error User TASK_SIZE overlaps with KERNEL_START address
>> +#endif
>> #define TASK_SIZE  (CONFIG_TASK_SIZE)
>> 
>> /* This decides where the kernel will search for a free chunk of vm
>> 
> 
> something like that would be good.  is there really anything PPC32
> specific about it? 
> 
Probably not. Could this be done in the Kconfig file instead?. Don't
know if Kconfig supports doing a comparison.

___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev


RE: 1 GB lowmem

2008-05-22 Thread Rune Torgersen
Kumar Gala wrote:
> On May 21, 2008, at 4:24 PM, Rune Torgersen wrote:
> 
>> Kumar Gala wrote:
>>> On May 21, 2008, at 3:55 PM, Rune Torgersen wrote:
 Argh... Found it. Had to set CONFIG_TASK_SIZE to 0x8000. Now it
 works in both vaniulla an d RT kernel.
>>> 
>>> We should really add some sanity check on CONFIG_TASK_SIZE vs
>>> KERNEL_START.
>> 
>> Something like this?
>> Wording sould probablyy be a bit different/cleare.
>> 
>> diff --git a/include/asm-powerpc/processor.h
>> b/include/asm-powerpc/processor.h
>> index fd98ca9..72e0e3f 100644
>> --- a/include/asm-powerpc/processor.h
>> +++ b/include/asm-powerpc/processor.h
>> @@ -81,6 +81,10 @@ extern struct task_struct *last_task_used_altivec;
>> extern struct task_struct *last_task_used_spe;
>> 
>> #ifdef CONFIG_PPC32
>> +
>> +#if CONFIG_TASK_SIZE > CONFIG_KERNEL_START
>> +#error User TASK_SIZE overlaps with KERNEL_START address
>> +#endif
>> #define TASK_SIZE  (CONFIG_TASK_SIZE)
>> 
>> /* This decides where the kernel will search for a free chunk of vm
>> 
> 
> something like that would be good.  is there really anything PPC32
> specific about it? 
> 
Probably not. Could this be done in the Kconfig file instead?. Don't
know if Kconfig supports doing a comparison.

___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev


Re: 1 GB lowmem

2008-05-21 Thread Kumar Gala


On May 21, 2008, at 4:24 PM, Rune Torgersen wrote:


Kumar Gala wrote:

On May 21, 2008, at 3:55 PM, Rune Torgersen wrote:

Argh... Found it. Had to set CONFIG_TASK_SIZE to 0x8000. Now it
works in both vaniulla an d RT kernel.


We should really add some sanity check on CONFIG_TASK_SIZE vs
KERNEL_START.


Something like this?
Wording sould probablyy be a bit different/cleare.

diff --git a/include/asm-powerpc/processor.h
b/include/asm-powerpc/processor.h
index fd98ca9..72e0e3f 100644
--- a/include/asm-powerpc/processor.h
+++ b/include/asm-powerpc/processor.h
@@ -81,6 +81,10 @@ extern struct task_struct *last_task_used_altivec;
extern struct task_struct *last_task_used_spe;

#ifdef CONFIG_PPC32
+
+#if CONFIG_TASK_SIZE > CONFIG_KERNEL_START
+#error User TASK_SIZE overlaps with KERNEL_START address
+#endif
#define TASK_SIZE  (CONFIG_TASK_SIZE)

/* This decides where the kernel will search for a free chunk of vm



something like that would be good.  is there really anything PPC32  
specific about it?


- k
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev


Re: 1 GB lowmem

2008-05-21 Thread Benjamin Herrenschmidt

On Wed, 2008-05-21 at 13:00 -0500, Rune Torgersen wrote:
> Hi
> 
> I am trying to enable 1 GB of lowmem on a Freescale 8280.
> In arch/ppc this was easilly done by:
> CONFIG_ADVANCED_OPTIONS=y
> CONFIG_HIGHMEM_START=0xfe00
> CONFIG_LOWMEM_SIZE_BOOL=y
> CONFIG_LOWMEM_SIZE=0x4000
> CONFIG_KERNEL_START_BOOL=y
> CONFIG_KERNEL_START=0xa000
> 
> This does not work in arch/powerpc. CPU hangs as soon as init starts.
> Any ideas what to look at, what to change?

You probably need to lower TASK_SIZE too.

> The reason I want to do this is because I cannot get highmem support to
> work when using CONFIG_PREEMPT_RT.
> (hitting a bug_on in kmap_atomic)

We should look into fixing that :-)

Ben.


___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev


RE: 1 GB lowmem

2008-05-21 Thread Rune Torgersen
Kumar Gala wrote:
> On May 21, 2008, at 3:55 PM, Rune Torgersen wrote:
>> Argh... Found it. Had to set CONFIG_TASK_SIZE to 0x8000. Now it
>> works in both vaniulla an d RT kernel.
> 
> We should really add some sanity check on CONFIG_TASK_SIZE vs
> KERNEL_START. 

Something like this?
Wording sould probablyy be a bit different/cleare.

diff --git a/include/asm-powerpc/processor.h
b/include/asm-powerpc/processor.h
index fd98ca9..72e0e3f 100644
--- a/include/asm-powerpc/processor.h
+++ b/include/asm-powerpc/processor.h
@@ -81,6 +81,10 @@ extern struct task_struct *last_task_used_altivec;
 extern struct task_struct *last_task_used_spe;

 #ifdef CONFIG_PPC32
+
+#if CONFIG_TASK_SIZE > CONFIG_KERNEL_START
+#error User TASK_SIZE overlaps with KERNEL_START address
+#endif
 #define TASK_SIZE  (CONFIG_TASK_SIZE)

 /* This decides where the kernel will search for a free chunk of vm


___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev


Re: 1 GB lowmem

2008-05-21 Thread Kumar Gala


On May 21, 2008, at 3:55 PM, Rune Torgersen wrote:


Rune Torgersen wrote:

[EMAIL PROTECTED] wrote:

Hi

I am trying to enable 1 GB of lowmem on a Freescale 8280.
In arch/ppc this was easilly done by:
CONFIG_ADVANCED_OPTIONS=y
CONFIG_HIGHMEM_START=0xfe00
CONFIG_LOWMEM_SIZE_BOOL=y
CONFIG_LOWMEM_SIZE=0x4000
CONFIG_KERNEL_START_BOOL=y
CONFIG_KERNEL_START=0xa000

This does not work in arch/powerpc. CPU hangs as soon as init  
starts.

Any ideas what to look at, what to change?

The reason I want to do this is because I cannot get highmem support
to work when using CONFIG_PREEMPT_RT.
(hitting a bug_on in kmap_atomic)


Scratch that. 1 GB lowmem works with vanilla 2.6.25.4, but
not at all with 2.6.25.4-rt[13]


Argh... Found it. Had to set CONFIG_TASK_SIZE to 0x8000. Now it
works in both vaniulla an d RT kernel.


We should really add some sanity check on CONFIG_TASK_SIZE vs  
KERNEL_START.


- k
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev


RE: 1 GB lowmem

2008-05-21 Thread Rune Torgersen
Rune Torgersen wrote:
> [EMAIL PROTECTED] wrote:
>> Hi
>> 
>> I am trying to enable 1 GB of lowmem on a Freescale 8280.
>> In arch/ppc this was easilly done by:
>> CONFIG_ADVANCED_OPTIONS=y
>> CONFIG_HIGHMEM_START=0xfe00
>> CONFIG_LOWMEM_SIZE_BOOL=y
>> CONFIG_LOWMEM_SIZE=0x4000
>> CONFIG_KERNEL_START_BOOL=y
>> CONFIG_KERNEL_START=0xa000
>> 
>> This does not work in arch/powerpc. CPU hangs as soon as init starts.
>> Any ideas what to look at, what to change?
>> 
>> The reason I want to do this is because I cannot get highmem support
>> to work when using CONFIG_PREEMPT_RT.
>> (hitting a bug_on in kmap_atomic)
> 
> Scratch that. 1 GB lowmem works with vanilla 2.6.25.4, but
> not at all with 2.6.25.4-rt[13]

Argh... Found it. Had to set CONFIG_TASK_SIZE to 0x8000. Now it
works in both vaniulla an d RT kernel.
Highmem still doesn't work.

___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev


RE: 1 GB lowmem

2008-05-21 Thread Rune Torgersen
[EMAIL PROTECTED] wrote:
> Hi
> 
> I am trying to enable 1 GB of lowmem on a Freescale 8280.
> In arch/ppc this was easilly done by:
> CONFIG_ADVANCED_OPTIONS=y
> CONFIG_HIGHMEM_START=0xfe00
> CONFIG_LOWMEM_SIZE_BOOL=y
> CONFIG_LOWMEM_SIZE=0x4000
> CONFIG_KERNEL_START_BOOL=y
> CONFIG_KERNEL_START=0xa000
> 
> This does not work in arch/powerpc. CPU hangs as soon as init starts.
> Any ideas what to look at, what to change?
> 
> The reason I want to do this is because I cannot get highmem
> support to
> work when using CONFIG_PREEMPT_RT.
> (hitting a bug_on in kmap_atomic)

Scratch that. 1 GB lowmem works with vanilla 2.6.25.4, but not at all
with 2.6.25.4-rt[13]
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev


1 GB lowmem

2008-05-21 Thread Rune Torgersen
Hi

I am trying to enable 1 GB of lowmem on a Freescale 8280.
In arch/ppc this was easilly done by:
CONFIG_ADVANCED_OPTIONS=y
CONFIG_HIGHMEM_START=0xfe00
CONFIG_LOWMEM_SIZE_BOOL=y
CONFIG_LOWMEM_SIZE=0x4000
CONFIG_KERNEL_START_BOOL=y
CONFIG_KERNEL_START=0xa000

This does not work in arch/powerpc. CPU hangs as soon as init starts.
Any ideas what to look at, what to change?

The reason I want to do this is because I cannot get highmem support to
work when using CONFIG_PREEMPT_RT.
(hitting a bug_on in kmap_atomic)
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev