Hi Ilya, Are you going to push further in submitting the ADMA driver for 440SPE ? If you are not I am planning to pursue this effort. I also have couple later version of Soc's needed to submit.
Thank and Regards, Marri From: linux-raid-ow...@vger.kernel.org [mailto:linux-raid-ow...@vger.kernel.org] On Behalf Of Ilya Yanok Sent: Thursday, November 13, 2008 9:51 AM To: Josh Boyer Cc:; d...@denx.de; w...@denx.de Subject: Re: [PATCH 11/11] ppc440spe-adma: ADMA driver for PPC440SP(e) systems This message has been archived. View the original item <http://sdcmailvault.ad.amcc.com/EnterpriseVault/ViewMessage.asp?VaultId =1E9560FDB597EB744B7F046F24F9462D91110000sdcmailvault.ad.amcc.com&Savese tId=705000000000000~200811131750430000~2~2007F01CF3764FBC926BAD4B10FE5BC > Josh Boyer wrote: > On Thu, Nov 13, 2008 at 06:16:04PM +0300, Ilya Yanok wrote: > >> Adds the platform device definitions and the architecture specific support >> routines for the ppc440spe adma driver. >> >> Any board equipped with PPC440SP(e) controller may utilize this driver. >> >> Signed-off-by: Yuri Tikhonov <y...@emcraft.com> >> Signed-off-by: Ilya Yanok <ya...@emcraft.com> >> > > Before I really dig into reviewing this driver, I'm going to ask you as simple > question. This looks like a 1/2 completed port of an arch/ppc driver that uses > the device tree (incorrectly) to get the interrupt resources and that's about it. > Otherwise, it's just a straight up platform device driver. Is that correct? > Yep, that's correct. > If that is the case, I think the driver needs more work before it can be merged. > It should get the DCR and MMIO resources from the device tree as well. It should > be binding on compatible properties and not based on device tree paths. And it > should probably be an of_platform device driver. > Surely, you're right. I agree with you in that this driver isn't ready for merging. But it works so we'd like to publish it so interested people could use it and test it. Regards, Ilya. -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev