RE: [PATCH] [POWERPC] Enable correct operation of serial ports withnonzero regshift.

[Stephen Neuendorffer]

gcc knows better. :)

> -Original Message-
> From: Stephen Rothwell [mailto:[EMAIL PROTECTED]
> Sent: Thursday, February 14, 2008 3:27 PM
> To: Stephen Neuendorffer
> Cc: Pavel Kiryukhin; linuxppc-dev@ozlabs.org
> Subject: Re: [PATCH] [POWERPC] Enable correct operation of serial
ports withnonzero regshift.
> 
> On Thu, 14 Feb 2008 10:55:31 -0800 "Stephen Neuendorffer"
<[EMAIL PROTECTED]> wrote:
> >
> > > --- a/arch/powerpc/kernel/legacy_serial.c
> > > +++ b/arch/powerpc/kernel/legacy_serial.c
> > > + /* get regshift if present*/
> > > + regshift = get_property(np, "reg-shift", NULL);
> >
> > of_get_property, presumably?
> 
> Damn, how did I miss that?  :-)
> 
> --
> Cheers,
> Stephen Rothwell[EMAIL PROTECTED]
> http://www.canb.auug.org.au/~sfr/

___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] [POWERPC] Enable correct operation of serial ports withnonzero regshift.

[Stephen Rothwell]

On Thu, 14 Feb 2008 10:55:31 -0800 "Stephen Neuendorffer" <[EMAIL PROTECTED]> 
wrote:
>
> > --- a/arch/powerpc/kernel/legacy_serial.c
> > +++ b/arch/powerpc/kernel/legacy_serial.c
> > +   /* get regshift if present*/
> > +   regshift = get_property(np, "reg-shift", NULL);
> 
> of_get_property, presumably?

Damn, how did I miss that?  :-)

-- 
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/


pgpNg9UlWVuGe.pgp
Description: PGP signature
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

RE: [PATCH] [POWERPC] Enable correct operation of serial ports withnonzero regshift.

[Stephen Neuendorffer]

> --- a/arch/powerpc/kernel/legacy_serial.c
> +++ b/arch/powerpc/kernel/legacy_serial.c
> + /* get regshift if present*/
> + regshift = get_property(np, "reg-shift", NULL);

of_get_property, presumably?

--- a/drivers/serial/of_serial.c
+++ b/drivers/serial/of_serial.c
> + regshift = get_property(np, "reg-shift", NULL);

ditto...

Otherwise, 

Acked-by: Stephen Neuendorffer <[EMAIL PROTECTED]>

Also, can you post a patch to the Xilinx portion of
booting-without-of.txt that has the device tree entries necessary to get
the uart to work?  (Since I happened to be tracking down what I assume
is the same issue when you posted the patch!)

Steve



___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev