RE: [PATCH] devicetree/binding/powerpc/fsl: Add binding for CPLD

2014-07-03 Thread Priyanka Jain


> -Original Message-
> From: Wood Scott-B07421
> Sent: Thursday, July 03, 2014 11:38 PM
> To: Jain Priyanka-B32167
> Cc: devicet...@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> Subject: Re: [PATCH] devicetree/binding/powerpc/fsl: Add binding for CPLD
> 
> On Thu, 2014-07-03 at 15:39 +0530, Priyanka Jain wrote:
> > Some Freescale boards like T1040RDB have on board CPLD connected on
> > the IFC bus. Add binding for this in board.txt file
> >
> > Signed-off-by: Priyanka Jain 
> > ---
> >  .../devicetree/bindings/powerpc/fsl/board.txt  |   19
> +++
> >  1 files changed, 19 insertions(+), 0 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/powerpc/fsl/board.txt
> > b/Documentation/devicetree/bindings/powerpc/fsl/board.txt
> > index 700dec4..f35f295 100644
> > --- a/Documentation/devicetree/bindings/powerpc/fsl/board.txt
> > +++ b/Documentation/devicetree/bindings/powerpc/fsl/board.txt
> > @@ -84,3 +84,22 @@ Example:
> > compatible = "fsl,bsc9132qds-fpga", "fsl,fpga-qixis-i2c";
> > reg = <0x66>;
> > };
> > +
> > +* Freescale on-board CPLD
> > +
> > +Some Freescale boards like T1040RDB have on board CPLD connected on
> > +the IFC bus.
> > +
> > +Required properties:
> > +- compatible: Should be a board-specific string like "fsl,-
> cpld"
> > +  Example:
> > +   "fsl,T1040RDB-cpld", "fsl,T1042RDB-cpld", "fsl,T1042RDB_PI-cpld"
> > +- reg: Should contain the chip select, address offset and length of
> > +the CPLD
> > +
> > +Example:
> > +   cpld@3,0 {
> > +   #address-cells = <1>;
> > +   #size-cells = <1>;
> > +   compatible = "fsl,T1040RDB-cpld";
> > +   reg = <3 0 0x300>;
> > +   };
> 
> Please keep the board name in lowercase like the rest.
> 
> -Scott
> 
[Jain Priyanka-B32167]Thanks for the inputs.  I will correct this

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] devicetree/binding/powerpc/fsl: Add binding for CPLD

2014-07-03 Thread Scott Wood
On Thu, 2014-07-03 at 15:39 +0530, Priyanka Jain wrote:
> Some Freescale boards like T1040RDB have on board CPLD connected on
> the IFC bus. Add binding for this in board.txt file
> 
> Signed-off-by: Priyanka Jain 
> ---
>  .../devicetree/bindings/powerpc/fsl/board.txt  |   19 +++
>  1 files changed, 19 insertions(+), 0 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/powerpc/fsl/board.txt 
> b/Documentation/devicetree/bindings/powerpc/fsl/board.txt
> index 700dec4..f35f295 100644
> --- a/Documentation/devicetree/bindings/powerpc/fsl/board.txt
> +++ b/Documentation/devicetree/bindings/powerpc/fsl/board.txt
> @@ -84,3 +84,22 @@ Example:
>   compatible = "fsl,bsc9132qds-fpga", "fsl,fpga-qixis-i2c";
>   reg = <0x66>;
>   };
> +
> +* Freescale on-board CPLD
> +
> +Some Freescale boards like T1040RDB have on board CPLD connected on
> +the IFC bus.
> +
> +Required properties:
> +- compatible: Should be a board-specific string like "fsl,-cpld"
> +  Example:
> + "fsl,T1040RDB-cpld", "fsl,T1042RDB-cpld", "fsl,T1042RDB_PI-cpld"
> +- reg: Should contain the chip select, address offset and length of the CPLD
> +
> +Example:
> + cpld@3,0 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "fsl,T1040RDB-cpld";
> + reg = <3 0 0x300>;
> + };

Please keep the board name in lowercase like the rest.

-Scott


___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev