RE: [PATCH] fsl/fman: add dependency on HAS_DMA

2017-06-27 Thread Madalin-cristian Bucur 
> -Original Message-
> From: geert.uytterhoe...@gmail.com [mailto:geert.uytterhoe...@gmail.com]
> On Behalf Of Geert Uytterhoeven
> Sent: Monday, June 26, 2017 7:17 PM
> To: Fabio Estevam <feste...@gmail.com>
> Cc: Madalin-cristian Bucur <madalin.bu...@nxp.com>;
> net...@vger.kernel.org; David S. Miller <da...@davemloft.net>; linuxppc-
> d...@lists.ozlabs.org; linux-kernel <linux-ker...@vger.kernel.org>
> Subject: Re: [PATCH] fsl/fman: add dependency on HAS_DMA
> 
> On Mon, Jun 26, 2017 at 5:20 PM, Fabio Estevam <feste...@gmail.com> wrote:
> > On Mon, Jun 26, 2017 at 12:12 PM, Madalin Bucur <madalin.bu...@nxp.com>
> wrote:
> >> A previous commit inserted a dependency on DMA API that requires
> >> HAS_DMA to be added in Kconfig.
> >
> > It would be nice to specify the commit that caused this.
> 
> That would be commit 5567e989198b5a8d ("fsl/fman: propagate dma_ops").
> 
> However, none of the fman code uses any DMA API calls, so IMHO
> the set_dma_ops() should be done somewhere else.

The Ethernet driver is making use of the DMA ops set here.

> Gr{oetje,eeting}s,
> 
> Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
> 
> In personal conversations with technical people, I call myself a hacker.
> But
> when I'm talking to journalists I just say "programmer" or something like
> that.
> -- Linus Torvalds

Re: [PATCH] fsl/fman: add dependency on HAS_DMA

2017-06-26 Thread Geert Uytterhoeven 
On Mon, Jun 26, 2017 at 5:20 PM, Fabio Estevam  wrote:
> On Mon, Jun 26, 2017 at 12:12 PM, Madalin Bucur  wrote:
>> A previous commit inserted a dependency on DMA API that requires
>> HAS_DMA to be added in Kconfig.
>
> It would be nice to specify the commit that caused this.

That would be commit 5567e989198b5a8d ("fsl/fman: propagate dma_ops").

However, none of the fman code uses any DMA API calls, so IMHO
the set_dma_ops() should be done somewhere else.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

RE: [PATCH] fsl/fman: add dependency on HAS_DMA

2017-06-26 Thread Madalin-cristian Bucur 
> -Original Message-
> From: Fabio Estevam [mailto:feste...@gmail.com]
> Sent: Monday, June 26, 2017 6:21 PM
> To: Madalin-cristian Bucur <madalin.bu...@nxp.com>
> Cc: net...@vger.kernel.org; David S. Miller <da...@davemloft.net>; Geert
> Uytterhoeven <ge...@linux-m68k.org>; linuxppc-dev@lists.ozlabs.org; linux-
> kernel <linux-ker...@vger.kernel.org>
> Subject: Re: [PATCH] fsl/fman: add dependency on HAS_DMA
> 
> On Mon, Jun 26, 2017 at 12:12 PM, Madalin Bucur <madalin.bu...@nxp.com>
> wrote:
> > A previous commit inserted a dependency on DMA API that requires
> > HAS_DMA to be added in Kconfig.
> 
> It would be nice to specify the commit that caused this.

Sent v2, thanks.

Madalin

Re: [PATCH] fsl/fman: add dependency on HAS_DMA

2017-06-26 Thread Fabio Estevam 
On Mon, Jun 26, 2017 at 12:12 PM, Madalin Bucur  wrote:
> A previous commit inserted a dependency on DMA API that requires
> HAS_DMA to be added in Kconfig.

It would be nice to specify the commit that caused this.