RE: [PATCH v2 1/2] powerpc/mpc85xx: support the MTD for p1022ds flash
Yes, I tested with the latest Linux kernel, with my patch, the NOR and NAND MTD
can work well.
Best Regards
Jerry Huang
-Original Message-
From: Tabi Timur-B04825
Sent: Wednesday, April 18, 2012 2:10 AM
To: Huang Changming-R66093
Cc: linuxppc-dev@lists.ozlabs.org; Kumar Gala
Subject: Re: [PATCH v2 1/2] powerpc/mpc85xx: support the MTD for p1022ds
flash
On Tue, Apr 17, 2012 at 4:15 AM, chang-ming.hu...@freescale.com wrote:
diff --git a/arch/powerpc/platforms/85xx/p1022_ds.c
b/arch/powerpc/platforms/85xx/p1022_ds.c
index e74b7cd..0db3a7e 100644
--- a/arch/powerpc/platforms/85xx/p1022_ds.c
+++ b/arch/powerpc/platforms/85xx/p1022_ds.c
@@ -463,6 +463,7 @@ static void __init p1022_ds_setup_arch(void)
static struct of_device_id __initdata p1022_ds_ids[] = {
/* So that the DMA channel nodes can be probed individually: */
{ .compatible = fsl,eloplus-dma, },
+ { .compatible = fsl,p1022-elbc, },
{},
};
Have you actually tested this with an upstream kernel? p1022_ds_ids[] is
broken upstream, so adding a new line won't work.
Take a look at http://patchwork.ozlabs.org/patch/128533/
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
RE: [PATCH v2 1/2] powerpc/mpc85xx: support the MTD for p1022ds flash
But, I observed the Call Trace, but the partition can be parsed correctly.
Maybe your patch can fix this Call Trace.
Best Regards
Jerry Huang
-Original Message-
From: linuxppc-dev-bounces+r66093=freescale@lists.ozlabs.org
[mailto:linuxppc-dev-bounces+r66093=freescale@lists.ozlabs.org] On
Behalf Of Huang Changming-R66093
Sent: Wednesday, April 18, 2012 3:47 PM
To: Tabi Timur-B04825
Cc: linuxppc-dev@lists.ozlabs.org
Subject: RE: [PATCH v2 1/2] powerpc/mpc85xx: support the MTD for p1022ds
flash
Yes, I tested with the latest Linux kernel, with my patch, the NOR and
NAND MTD can work well.
Best Regards
Jerry Huang
-Original Message-
From: Tabi Timur-B04825
Sent: Wednesday, April 18, 2012 2:10 AM
To: Huang Changming-R66093
Cc: linuxppc-dev@lists.ozlabs.org; Kumar Gala
Subject: Re: [PATCH v2 1/2] powerpc/mpc85xx: support the MTD for
p1022ds flash
On Tue, Apr 17, 2012 at 4:15 AM, chang-ming.hu...@freescale.com
wrote:
diff --git a/arch/powerpc/platforms/85xx/p1022_ds.c
b/arch/powerpc/platforms/85xx/p1022_ds.c
index e74b7cd..0db3a7e 100644
--- a/arch/powerpc/platforms/85xx/p1022_ds.c
+++ b/arch/powerpc/platforms/85xx/p1022_ds.c
@@ -463,6 +463,7 @@ static void __init p1022_ds_setup_arch(void)
static struct of_device_id __initdata p1022_ds_ids[] = {
/* So that the DMA channel nodes can be probed individually:
*/
{ .compatible = fsl,eloplus-dma, },
+ { .compatible = fsl,p1022-elbc, },
{},
};
Have you actually tested this with an upstream kernel? p1022_ds_ids[]
is broken upstream, so adding a new line won't work.
Take a look at http://patchwork.ozlabs.org/patch/128533/
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH v2 1/2] powerpc/mpc85xx: support the MTD for p1022ds flash
Huang Changming-R66093 wrote:
But, I observed the Call Trace, but the partition can be parsed correctly.
Maybe your patch can fix this Call Trace.
Can you post the call trace?
I think the reason this patch works is because the localbus node is not
already probed by mpc85xx_common_publish_devices().
mpc85xx_common_publish_devices() has this line in it:
{ .name = localbus, },
But this does not work any more, because all of our 85xx localbus nodes
are now called localbus@ffe05000.
I'm beginning to hate mpc85xx_common_publish_devices() now. Not only
because it's broken for the P1022DS, but also because it's not
set-in-stone like everyone thought.
--
Timur Tabi
Linux kernel developer at Freescale
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH v2 1/2] powerpc/mpc85xx: support the MTD for p1022ds flash
On Tue, Apr 17, 2012 at 4:15 AM, chang-ming.hu...@freescale.com wrote:
diff --git a/arch/powerpc/platforms/85xx/p1022_ds.c
b/arch/powerpc/platforms/85xx/p1022_ds.c
index e74b7cd..0db3a7e 100644
--- a/arch/powerpc/platforms/85xx/p1022_ds.c
+++ b/arch/powerpc/platforms/85xx/p1022_ds.c
@@ -463,6 +463,7 @@ static void __init p1022_ds_setup_arch(void)
static struct of_device_id __initdata p1022_ds_ids[] = {
/* So that the DMA channel nodes can be probed individually: */
{ .compatible = fsl,eloplus-dma, },
+ { .compatible = fsl,p1022-elbc, },
{},
};
Have you actually tested this with an upstream kernel? p1022_ds_ids[]
is broken upstream, so adding a new line won't work.
Take a look at http://patchwork.ozlabs.org/patch/128533/
--
Timur Tabi
Linux kernel developer at Freescale
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
