Re: [PATCH v5 19/19] dt-bindings: usb: intel, keembay-dwc3: Validate DWC3 sub-node
On Sat, 05 Dec 2020 18:24:26 +0300, Serge Semin wrote: > Intel Keem Bay DWC3 compatible DT nodes are supposed to have a DWC USB3 > compatible sub-node to describe a fully functioning USB interface. Let's > use the available DWC USB3 DT schema to validate the Qualcomm DWC3 > sub-nodes. > > Note since the generic DWC USB3 DT node is supposed to be named as generic > USB HCD ("^usb(@.*)?") one we have to accordingly fix the sub-nodes name > regexp and fix the DT node example. > > Signed-off-by: Serge Semin > > --- > > Changelog v5: > - This is a new patch created for the new Intel Keem Bay bindings file, > which has been added just recently. > --- > .../devicetree/bindings/usb/intel,keembay-dwc3.yaml | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) > Reviewed-by: Rob Herring
RE: [PATCH v5 19/19] dt-bindings: usb: intel,keembay-dwc3: Validate DWC3 sub-node
Hi Serge. > -Original Message- > From: Serge Semin > Sent: Saturday, December 5, 2020 11:24 PM > To: Nyman, Mathias ; Felipe Balbi > ; Krzysztof Kozlowski ; Greg Kroah- > Hartman ; Rob Herring > ; Chunfeng Yun ; > Wan Mohamad, Wan Ahmad Zainie > > Cc: Serge Semin ; Serge Semin > ; Alexey Malahov > ; Pavel Parkhomenko > ; Andy Gross > ; Bjorn Andersson ; > Manu Gautam ; Roger Quadros > ; Lad Prabhakar lad...@bp.renesas.com>; Yoshihiro Shimoda > ; narmstrong > ; Kevin Hilman ; > Martin Blumenstingl ; linux-arm- > ker...@lists.infradead.org; linux-snps-...@lists.infradead.org; linux- > m...@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; linux- > u...@vger.kernel.org; devicet...@vger.kernel.org; linux- > ker...@vger.kernel.org > Subject: [PATCH v5 19/19] dt-bindings: usb: intel,keembay-dwc3: Validate > DWC3 sub-node > > Intel Keem Bay DWC3 compatible DT nodes are supposed to have a DWC > USB3 compatible sub-node to describe a fully functioning USB interface. Let's > use the available DWC USB3 DT schema to validate the Qualcomm DWC3 sub- > nodes. > > Note since the generic DWC USB3 DT node is supposed to be named as > generic USB HCD ("^usb(@.*)?") one we have to accordingly fix the sub- > nodes name regexp and fix the DT node example. > > Signed-off-by: Serge Semin LGTM. With minor change to fix the typo above, Qualcomm to Intel Keem Bay, Acked-by: Wan Ahmad Zainie > > --- > > Changelog v5: > - This is a new patch created for the new Intel Keem Bay bindings file, > which has been added just recently. > --- > .../devicetree/bindings/usb/intel,keembay-dwc3.yaml | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/intel,keembay- > dwc3.yaml b/Documentation/devicetree/bindings/usb/intel,keembay- > dwc3.yaml > index dd32c10ce6c7..43b91ab62004 100644 > --- a/Documentation/devicetree/bindings/usb/intel,keembay-dwc3.yaml > +++ b/Documentation/devicetree/bindings/usb/intel,keembay-dwc3.yaml > @@ -34,11 +34,8 @@ properties: > # Required child node: > > patternProperties: > - "^dwc3@[0-9a-f]+$": > -type: object > -description: > - A child node must exist to represent the core DWC3 IP block. > - The content of the node is defined in dwc3.txt. > + "^usb@[0-9a-f]+$": > +$ref: snps,dwc3.yaml# > > required: >- compatible > @@ -68,7 +65,7 @@ examples: >#address-cells = <1>; >#size-cells = <1>; > > - dwc3@3400 { > + usb@3400 { > compatible = "snps,dwc3"; > reg = <0x3400 0x1>; > interrupts = ; > -- > 2.29.2 Best regards, Zainie
Re: [PATCH v5 19/19] dt-bindings: usb: intel,keembay-dwc3: Validate DWC3 sub-node
Hi Wan, On Sun, Dec 06, 2020 at 09:56:47AM +, Wan Mohamad, Wan Ahmad Zainie wrote: > Hi Serge. > > > -Original Message- > > From: Serge Semin > > Sent: Saturday, December 5, 2020 11:24 PM > > To: Nyman, Mathias ; Felipe Balbi > > ; Krzysztof Kozlowski ; Greg Kroah- > > Hartman ; Rob Herring > > ; Chunfeng Yun ; > > Wan Mohamad, Wan Ahmad Zainie > > > > Cc: Serge Semin ; Serge Semin > > ; Alexey Malahov > > ; Pavel Parkhomenko > > ; Andy Gross > > ; Bjorn Andersson ; > > Manu Gautam ; Roger Quadros > > ; Lad Prabhakar > lad...@bp.renesas.com>; Yoshihiro Shimoda > > ; narmstrong > > ; Kevin Hilman ; > > Martin Blumenstingl ; linux-arm- > > ker...@lists.infradead.org; linux-snps-...@lists.infradead.org; linux- > > m...@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; linux- > > u...@vger.kernel.org; devicet...@vger.kernel.org; linux- > > ker...@vger.kernel.org > > Subject: [PATCH v5 19/19] dt-bindings: usb: intel,keembay-dwc3: Validate > > DWC3 sub-node > > > > Intel Keem Bay DWC3 compatible DT nodes are supposed to have a DWC > > USB3 compatible sub-node to describe a fully functioning USB interface. > > Let's > > use the available DWC USB3 DT schema to validate the Qualcomm DWC3 sub- > > nodes. > > > > Note since the generic DWC USB3 DT node is supposed to be named as > > generic USB HCD ("^usb(@.*)?") one we have to accordingly fix the sub- > > nodes name regexp and fix the DT node example. > > > > Signed-off-by: Serge Semin > > LGTM. With minor change to fix the typo above, Qualcomm to Intel > Keem Bay, > Acked-by: Wan Ahmad Zainie Ah, right. Thanks for noticing that. A probability of copy-paste mistakes increases proportionally to the number sleepless hours.) -Sergey > > > > > --- > > > > Changelog v5: > > - This is a new patch created for the new Intel Keem Bay bindings file, > > which has been added just recently. > > --- > > .../devicetree/bindings/usb/intel,keembay-dwc3.yaml | 9 +++-- > > 1 file changed, 3 insertions(+), 6 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/usb/intel,keembay- > > dwc3.yaml b/Documentation/devicetree/bindings/usb/intel,keembay- > > dwc3.yaml > > index dd32c10ce6c7..43b91ab62004 100644 > > --- a/Documentation/devicetree/bindings/usb/intel,keembay-dwc3.yaml > > +++ b/Documentation/devicetree/bindings/usb/intel,keembay-dwc3.yaml > > @@ -34,11 +34,8 @@ properties: > > # Required child node: > > > > patternProperties: > > - "^dwc3@[0-9a-f]+$": > > -type: object > > -description: > > - A child node must exist to represent the core DWC3 IP block. > > - The content of the node is defined in dwc3.txt. > > + "^usb@[0-9a-f]+$": > > +$ref: snps,dwc3.yaml# > > > > required: > >- compatible > > @@ -68,7 +65,7 @@ examples: > >#address-cells = <1>; > >#size-cells = <1>; > > > > - dwc3@3400 { > > + usb@3400 { > > compatible = "snps,dwc3"; > > reg = <0x3400 0x1>; > > interrupts = ; > > -- > > 2.29.2 > > Best regards, > Zainie