Re: [PATCH] [POWERPC] qe_lib: fix few fluffy negligences (was: Re: [PATCH 1/5] [POWERPC] qe_lib and users: get rid of most device_types and model)

2008-02-05 Thread Kumar Gala 

 From: Anton Vorontsov [EMAIL PROTECTED]
 Subject: [POWERPC] qe_lib: fix few fluffy negligences

 One is intoduced by me (of_node_put() absence) and another was
 present already (not checking for NULL).

 Found by Stephen Rothwell.

 Signed-off-by: Anton Vorontsov [EMAIL PROTECTED]
 ---
 arch/powerpc/sysdev/qe_lib/qe.c |   10 +-
 1 files changed, 5 insertions(+), 5 deletions(-)

applied.

- k

___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] [POWERPC] qe_lib: fix few fluffy negligences (was: Re: [PATCH 1/5] [POWERPC] qe_lib and users: get rid of most device_types and model)

2008-02-04 Thread Stephen Rothwell 
On Mon, 4 Feb 2008 16:46:17 +0300 Anton Vorontsov [EMAIL PROTECTED] wrote:

 On Tue, Feb 05, 2008 at 12:13:18AM +1100, Stephen Rothwell wrote:
  
  If you don't care about the returned length (argument three to
  of_get_property), you can just pass NULL (and dispense with size).
  Also, what happens if prop is NULL?
 
 All this was in the old code already, I just didn't fix that.

I appreciate that, but it did need fixing.

 - - - -
 From: Anton Vorontsov [EMAIL PROTECTED]
 Subject: [POWERPC] qe_lib: fix few fluffy negligences
 
 One is intoduced by me (of_node_put() absence) and another was
 present already (not checking for NULL).
 
 Found by Stephen Rothwell.
 
 Signed-off-by: Anton Vorontsov [EMAIL PROTECTED]

Acked-by: Stephen Rothwell [EMAIL PROTECTED]

-- 
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/


pgpt7fvPzUXX7.pgp
Description: PGP signature
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev