Re: [PATCH] PCI: Remove unnecessary of_irq.h includes
On Wed, Oct 19, 2022 at 02:54:51PM -0500, Bjorn Helgaas wrote: > From: Bjorn Helgaas > > Many host controller drivers #include even though they > don't need it. Remove the unnecessary #includes. > > Signed-off-by: Bjorn Helgaas > drivers/pci/controller/pcie-microchip-host.c | 1 - LGTM... Acked-by: Conor Dooley
RE: [PATCH] PCI: Remove unnecessary of_irq.h includes
> -Original Message- > From: Bjorn Helgaas > > From: Bjorn Helgaas > > Many host controller drivers #include even though they > don't need it. Remove the unnecessary #includes. > > Signed-off-by: Bjorn Helgaas > --- > drivers/pci/controller/cadence/pci-j721e.c | 1 - > drivers/pci/controller/dwc/pci-layerscape.c | 1 - > drivers/pci/controller/dwc/pcie-armada8k.c | 1 - > drivers/pci/controller/dwc/pcie-tegra194.c | 1 - > drivers/pci/controller/pci-v3-semi.c | 1 - > drivers/pci/controller/pci-xgene-msi.c | 1 - > drivers/pci/controller/pci-xgene.c | 1 - > drivers/pci/controller/pcie-altera-msi.c | 1 - > drivers/pci/controller/pcie-iproc-platform.c | 1 - > drivers/pci/controller/pcie-iproc.c | 1 - > drivers/pci/controller/pcie-microchip-host.c | 1 - > drivers/pci/controller/pcie- > rockchip-host.c | 1 - > drivers/pci/controller/pcie-xilinx-cpm.c | 1 - > drivers/pci/controller/pcie-xilinx-nwl.c | 1 - > 14 files changed, 14 deletions(-) Acked-by: Roy Zang Roy
Re: [PATCH] PCI: Remove unnecessary of_irq.h includes
On Thu, Oct 20, 2022 at 04:09:37PM +0800, kernel test robot wrote: > Hi Bjorn, > > I love your patch! Yet something to improve: > > [auto build test ERROR on helgaas-pci/next] > [also build test ERROR on xilinx-xlnx/master rockchip/for-next linus/master > v6.1-rc1 next-20221020] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: > https://github.com/intel-lab-lkp/linux/commits/Bjorn-Helgaas/PCI-Remove-unnecessary-of_irq-h-includes/20221020-100633 > base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next > patch link: > https://lore.kernel.org/r/20221019195452.37606-1-helgaas%40kernel.org > patch subject: [PATCH] PCI: Remove unnecessary of_irq.h includes > config: ia64-randconfig-r026-20221020 > compiler: ia64-linux-gcc (GCC) 12.1.0 > reproduce (this is a W=1 build): > wget > https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O > ~/bin/make.cross > chmod +x ~/bin/make.cross > # > https://github.com/intel-lab-lkp/linux/commit/273a24b16a40ffd6a64c6c55aecbfae00a1cd996 > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review > Bjorn-Helgaas/PCI-Remove-unnecessary-of_irq-h-includes/20221020-100633 > git checkout 273a24b16a40ffd6a64c6c55aecbfae00a1cd996 > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 > O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/pci/controller/ FYI, the instructions above didn't work for me. Missing "config". $ git remote add linux-review https://github.com/intel-lab-lkp/linux $ git fetch --no-tags linux-review Bjorn-Helgaas/PCI-Remove-unnecessary-of_irq-h-includes/20221020-100633 $ git checkout 273a24b16a40ffd6a64c6c55aecbfae00a1cd996 HEAD is now at 273a24b16a40 PCI: Remove unnecessary of_irq.h includes $ mkdir build_dir && cp config build_dir/.config cp: cannot stat 'config': No such file or directory $ COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/pci/controller/ Compiler will be installed in /home/bjorn/0day Cannot find ia64-linux under https://download.01.org/0day-ci/cross-package check /tmp/0day-ci-crosstool-files Please set new url, e.g. export URL=https://cdn.kernel.org/pub/tools/crosstool/files/bin/x86_64 gcc crosstool install failed Install gcc cross compiler failed setup_crosstool failed
Re: [PATCH] PCI: Remove unnecessary of_irq.h includes
[+cc Pali, heads-up for trivial addition of to pci-mvebu.c] On Thu, Oct 20, 2022 at 08:20:25AM +0100, Conor Dooley wrote: > On Thu, Oct 20, 2022 at 03:08:50PM +0800, kernel test robot wrote: > > Hi Bjorn, > > > > I love your patch! Yet something to improve: > > > > >> drivers/pci/controller/pcie-microchip-host.c:473:31: error: incomplete > > >> definition of type 'struct irq_domain' > >struct mc_pcie *port = domain->host_data; > > That's what I get for only visually inspecting the patch before Acking > it.. Un-ack I suppose. No problem! I think what happened is the pcie-microchip-host.c uses irq_domain_add_linear() so it needs , but it currently gets it via , which it doesn't otherwise need. I added a preparatory patch to include explicitly, but I haven't been able to cross-build either riscv or ia64 to verify this fix. I'll wait a few days and post an updated series for the 0-day bot to test. Same situation for pcie-altera-msi.c. pci-mvebu.c also relies on getting via , but it actually depends on of_irq.h, so I'll just add an irqdomain.h include there. Bjorn
Re: [PATCH] PCI: Remove unnecessary of_irq.h includes
On Thu, Oct 20, 2022 at 08:45:47AM -0500, Bjorn Helgaas wrote: > [+cc Pali, heads-up for trivial addition of to > pci-mvebu.c] > > On Thu, Oct 20, 2022 at 08:20:25AM +0100, Conor Dooley wrote: > > On Thu, Oct 20, 2022 at 03:08:50PM +0800, kernel test robot wrote: > > > Hi Bjorn, > > > > > > I love your patch! Yet something to improve: > > > > > > >> drivers/pci/controller/pcie-microchip-host.c:473:31: error: incomplete > > > >> definition of type 'struct irq_domain' > > >struct mc_pcie *port = domain->host_data; > > > > That's what I get for only visually inspecting the patch before Acking > > it.. Un-ack I suppose. > > No problem! > > I think what happened is the pcie-microchip-host.c uses > irq_domain_add_linear() so it needs , but it > currently gets it via , which it doesn't otherwise > need. > > I added a preparatory patch to include explicitly, > but I haven't been able to cross-build either riscv or ia64 to verify > this fix. I'll wait a few days and post an updated series for the > 0-day bot to test. I saw you saying you couldn't find the config from LKP, FWIW a build using riscv defconfig w/ CONFIG_PCIE_MICROCHIP_HOST=y fails for me in the same way as lkp reports. Otherwise, dump the patch in response to this and I'll give it a shot later if you like? HTH, Conor. > > Same situation for pcie-altera-msi.c. > > pci-mvebu.c also relies on getting via > , but it actually depends on of_irq.h, so I'll just > add an irqdomain.h include there. > > Bjorn >
Re: [PATCH] PCI: Remove unnecessary of_irq.h includes
On Thu, Oct 20, 2022 at 08:41:01AM -0500, Bjorn Helgaas wrote: > On Thu, Oct 20, 2022 at 04:09:37PM +0800, kernel test robot wrote: > > Hi Bjorn, > > > > I love your patch! Yet something to improve: > > > > [auto build test ERROR on helgaas-pci/next] > > [also build test ERROR on xilinx-xlnx/master rockchip/for-next linus/master > > v6.1-rc1 next-20221020] > > [If your patch is applied to the wrong git tree, kindly drop us a note. > > And when submitting patch, we suggest to use '--base' as documented in > > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > > > url: > > https://github.com/intel-lab-lkp/linux/commits/Bjorn-Helgaas/PCI-Remove-unnecessary-of_irq-h-includes/20221020-100633 > > base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next > > patch link: > > https://lore.kernel.org/r/20221019195452.37606-1-helgaas%40kernel.org > > patch subject: [PATCH] PCI: Remove unnecessary of_irq.h includes > > config: ia64-randconfig-r026-20221020 > > compiler: ia64-linux-gcc (GCC) 12.1.0 > > reproduce (this is a W=1 build): > > wget > > https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O > > ~/bin/make.cross > > chmod +x ~/bin/make.cross > > # > > https://github.com/intel-lab-lkp/linux/commit/273a24b16a40ffd6a64c6c55aecbfae00a1cd996 > > git remote add linux-review https://github.com/intel-lab-lkp/linux > > git fetch --no-tags linux-review > > Bjorn-Helgaas/PCI-Remove-unnecessary-of_irq-h-includes/20221020-100633 > > git checkout 273a24b16a40ffd6a64c6c55aecbfae00a1cd996 > > # save the config file > > mkdir build_dir && cp config build_dir/.config > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 > > O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/pci/controller/ > > FYI, the instructions above didn't work for me. Missing "config". Sorry, my fault, "config" was a MIME attachment. Possibly update the instructions: - # save the config file + # save the config file from the MIME attachment
Re: [PATCH] PCI: Remove unnecessary of_irq.h includes
On Thu, Oct 20, 2022 at 10:13:10PM +0800, kernel test robot wrote: > Hi Bjorn, > > I love your patch! Yet something to improve: > > [auto build test ERROR on helgaas-pci/next] > [also build test ERROR on xilinx-xlnx/master rockchip/for-next linus/master > v6.1-rc1 next-20221020] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: > https://github.com/intel-lab-lkp/linux/commits/Bjorn-Helgaas/PCI-Remove-unnecessary-of_irq-h-includes/20221020-100633 > base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next > patch link: > https://lore.kernel.org/r/20221019195452.37606-1-helgaas%40kernel.org > patch subject: [PATCH] PCI: Remove unnecessary of_irq.h includes > config: s390-randconfig-r044-20221019 > compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project > 791a7ae1ba3efd6bca96338e10ffde557ba83920) > reproduce (this is a W=1 build): > wget > https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O > ~/bin/make.cross > chmod +x ~/bin/make.cross > # install s390 cross compiling tool for clang build > # apt-get install binutils-s390x-linux-gnu > # > https://github.com/intel-lab-lkp/linux/commit/273a24b16a40ffd6a64c6c55aecbfae00a1cd996 > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review > Bjorn-Helgaas/PCI-Remove-unnecessary-of_irq-h-includes/20221020-100633 > git checkout 273a24b16a40ffd6a64c6c55aecbfae00a1cd996 > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 > O=build_dir ARCH=s390 SHELL=/bin/bash drivers/pci/controller/ Maybe more user error? $ COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash drivers/pci/controller/ Compiler will be installed in /home/bjorn/0day make --keep-going HOSTCC=/home/bjorn/0day/clang/bin/clang CC=/home/bjorn/0day/clang/bin/clang OBJCOPY=/usr/s390x-linux-gnu/bin/objcopy AR=llvm-ar NM=llvm-nm STRIP=llvm-strip OBJDUMP=llvm-objdump OBJSIZE=llvm-size READELF=llvm-readelf HOSTCXX=clang++ HOSTAR=llvm-ar CROSS_COMPILE=s390x-linux-gnu- --jobs=16 W=1 O=build_dir ARCH=s390 SHELL=/bin/bash drivers/pci/controller/ make[1]: Entering directory '/home/bjorn/linux/build_dir' SYNCinclude/config/auto.conf.cmd GEN Makefile scripts/Kconfig.include:40: linker 's390x-linux-gnu-ld' not found make[3]: *** [../scripts/kconfig/Makefile:77: syncconfig] Error 1 make[2]: *** [../Makefile:697: syncconfig] Error 2 make[1]: *** [/home/bjorn/linux/Makefile:798: include/config/auto.conf.cmd] Error 2 make[1]: Failed to remake makefile 'include/config/auto.conf.cmd'. make[1]: Failed to remake makefile 'include/config/auto.conf'. GEN Makefile Error: kernelrelease not valid - run 'make prepare' to update it ../scripts/mkcompile_h: 19: s390x-linux-gnu-ld: not found make[1]: Target 'drivers/pci/controller/' not remade because of errors. make[1]: Leaving directory '/home/bjorn/linux/build_dir' make: *** [Makefile:231: __sub-make] Error 2 make: Target 'drivers/pci/controller/' not remade because of errors.
Re: [PATCH] PCI: Remove unnecessary of_irq.h includes
On Thursday 20 October 2022 08:45:47 Bjorn Helgaas wrote: > [+cc Pali, heads-up for trivial addition of to > pci-mvebu.c] ... > pci-mvebu.c also relies on getting via > , but it actually depends on of_irq.h, so I'll just > add an irqdomain.h include there. > > Bjorn > Ok, that is fine!
Re: [kbuild-all] Re: [PATCH] PCI: Remove unnecessary of_irq.h includes
On 10/20/2022 9:41 PM, Bjorn Helgaas wrote: On Thu, Oct 20, 2022 at 04:09:37PM +0800, kernel test robot wrote: Hi Bjorn, I love your patch! Yet something to improve: [auto build test ERROR on helgaas-pci/next] [also build test ERROR on xilinx-xlnx/master rockchip/for-next linus/master v6.1-rc1 next-20221020] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Bjorn-Helgaas/PCI-Remove-unnecessary-of_irq-h-includes/20221020-100633 base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next patch link: https://lore.kernel.org/r/20221019195452.37606-1-helgaas%40kernel.org patch subject: [PATCH] PCI: Remove unnecessary of_irq.h includes config: ia64-randconfig-r026-20221020 compiler: ia64-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/273a24b16a40ffd6a64c6c55aecbfae00a1cd996 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Bjorn-Helgaas/PCI-Remove-unnecessary-of_irq-h-includes/20221020-100633 git checkout 273a24b16a40ffd6a64c6c55aecbfae00a1cd996 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/pci/controller/ FYI, the instructions above didn't work for me. Missing "config". $ git remote add linux-review https://github.com/intel-lab-lkp/linux $ git fetch --no-tags linux-review Bjorn-Helgaas/PCI-Remove-unnecessary-of_irq-h-includes/20221020-100633 $ git checkout 273a24b16a40ffd6a64c6c55aecbfae00a1cd996 HEAD is now at 273a24b16a40 PCI: Remove unnecessary of_irq.h includes $ mkdir build_dir && cp config build_dir/.config cp: cannot stat 'config': No such file or directory $ COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/pci/controller/ Compiler will be installed in /home/bjorn/0day Cannot find ia64-linux under https://download.01.org/0day-ci/cross-package check /tmp/0day-ci-crosstool-files Hi Bjorn, Sorry for the inconvenience, the 01.org website is unstable recently, could you try "URL=https://cdn.kernel.org/pub/tools/crosstool/files/bin/x86_64 COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/pci/controller/"? Best Regards, Rong Chen Please set new url, e.g. export URL=https://cdn.kernel.org/pub/tools/crosstool/files/bin/x86_64 gcc crosstool install failed Install gcc cross compiler failed setup_crosstool failed ___ kbuild-all mailing list -- kbuild-...@lists.01.org To unsubscribe send an email to kbuild-all-le...@lists.01.org
Re: [kbuild-all] Re: [PATCH] PCI: Remove unnecessary of_irq.h includes
On 10/20/2022 11:07 PM, Bjorn Helgaas wrote: On Thu, Oct 20, 2022 at 10:13:10PM +0800, kernel test robot wrote: Hi Bjorn, I love your patch! Yet something to improve: [auto build test ERROR on helgaas-pci/next] [also build test ERROR on xilinx-xlnx/master rockchip/for-next linus/master v6.1-rc1 next-20221020] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Bjorn-Helgaas/PCI-Remove-unnecessary-of_irq-h-includes/20221020-100633 base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next patch link: https://lore.kernel.org/r/20221019195452.37606-1-helgaas%40kernel.org patch subject: [PATCH] PCI: Remove unnecessary of_irq.h includes config: s390-randconfig-r044-20221019 compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 791a7ae1ba3efd6bca96338e10ffde557ba83920) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install s390 cross compiling tool for clang build # apt-get install binutils-s390x-linux-gnu # https://github.com/intel-lab-lkp/linux/commit/273a24b16a40ffd6a64c6c55aecbfae00a1cd996 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Bjorn-Helgaas/PCI-Remove-unnecessary-of_irq-h-includes/20221020-100633 git checkout 273a24b16a40ffd6a64c6c55aecbfae00a1cd996 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash drivers/pci/controller/ Maybe more user error? $ COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash drivers/pci/controller/ Compiler will be installed in /home/bjorn/0day make --keep-going HOSTCC=/home/bjorn/0day/clang/bin/clang CC=/home/bjorn/0day/clang/bin/clang OBJCOPY=/usr/s390x-linux-gnu/bin/objcopy AR=llvm-ar NM=llvm-nm STRIP=llvm-strip OBJDUMP=llvm-objdump OBJSIZE=llvm-size READELF=llvm-readelf HOSTCXX=clang++ HOSTAR=llvm-ar CROSS_COMPILE=s390x-linux-gnu- --jobs=16 W=1 O=build_dir ARCH=s390 SHELL=/bin/bash drivers/pci/controller/ make[1]: Entering directory '/home/bjorn/linux/build_dir' SYNCinclude/config/auto.conf.cmd GEN Makefile scripts/Kconfig.include:40: linker 's390x-linux-gnu-ld' not found Hi Bjorn, You may need to install the below package, or similar package for other OS: $ dpkg -S /usr/bin/s390x-linux-gnu-ld binutils-s390x-linux-gnu: /usr/bin/s390x-linux-gnu-ld >> # install s390 cross compiling tool for clang build >> # apt-get install binutils-s390x-linux-gnu Best Regards, Rong Chen make[3]: *** [../scripts/kconfig/Makefile:77: syncconfig] Error 1 make[2]: *** [../Makefile:697: syncconfig] Error 2 make[1]: *** [/home/bjorn/linux/Makefile:798: include/config/auto.conf.cmd] Error 2 make[1]: Failed to remake makefile 'include/config/auto.conf.cmd'. make[1]: Failed to remake makefile 'include/config/auto.conf'. GEN Makefile Error: kernelrelease not valid - run 'make prepare' to update it ../scripts/mkcompile_h: 19: s390x-linux-gnu-ld: not found make[1]: Target 'drivers/pci/controller/' not remade because of errors. make[1]: Leaving directory '/home/bjorn/linux/build_dir' make: *** [Makefile:231: __sub-make] Error 2 make: Target 'drivers/pci/controller/' not remade because of errors. ___ kbuild-all mailing list -- kbuild-...@lists.01.org To unsubscribe send an email to kbuild-all-le...@lists.01.org
