Re: [PATCH] cxl: Set psl_fir_cntl to production environment value

[Uma Krishnan]

Reviewed-by: Uma Krishnan 

On 8/8/2016 4:57 AM, Frederic Barrat wrote:

Switch the setting of psl_fir_cntl from debug to production
environment recommended value. It mostly affects the PSL behavior when
an error is raised in psl_fir1/2.

Tested with cxlflash.

Signed-off-by: Frederic Barrat 
---
 drivers/misc/cxl/pci.c | 9 ++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c
index d152e2d..4be25c4 100644
--- a/drivers/misc/cxl/pci.c
+++ b/drivers/misc/cxl/pci.c
@@ -379,7 +379,7 @@ static int calc_capp_routing(struct pci_dev *dev, u64 
*chipid, u64 *capp_unit_id

 static int init_implementation_adapter_psl_regs(struct cxl *adapter, struct 
pci_dev *dev)
 {
-   u64 psl_dsnctl;
+   u64 psl_dsnctl, psl_fircntl;
u64 chipid;
u64 capp_unit_id;
int rc;
@@ -398,8 +398,11 @@ static int init_implementation_adapter_psl_regs(struct cxl 
*adapter, struct pci_
cxl_p1_write(adapter, CXL_PSL_RESLCKTO, 0x2000200ULL);
/* snoop write mask */
cxl_p1_write(adapter, CXL_PSL_SNWRALLOC, 0xULL);
-   /* set fir_accum */
-   cxl_p1_write(adapter, CXL_PSL_FIR_CNTL, 0x0800ULL);
+   /* set fir_cntl to recommended value for production env */
+   psl_fircntl = (0x2ULL << (63-3)); /* ce_report */
+   psl_fircntl |= (0x1ULL << (63-6)); /* FIR_report */
+   psl_fircntl |= 0x1ULL; /* ce_thresh */
+   cxl_p1_write(adapter, CXL_PSL_FIR_CNTL, psl_fircntl);
/* for debugging with trace arrays */
cxl_p1_write(adapter, CXL_PSL_TRACE, 0xFF7CULL);

Re: [PATCH] cxl: Set psl_fir_cntl to production environment value

[Frederic Barrat]

Le 09/08/2016 à 12:53, Michael Ellerman a écrit :

Frederic Barrat  writes:


Switch the setting of psl_fir_cntl from debug to production
environment recommended value. It mostly affects the PSL behavior when
an error is raised in psl_fir1/2.

Tested with cxlflash.


Is this a fix you want in rc1, or something for 4.9 ?


rc1 would be great. The cxlflash folks are eagerly waiting for it.

  Fred

Re: [PATCH] cxl: Set psl_fir_cntl to production environment value

[Michael Ellerman]

Frederic Barrat  writes:

> Switch the setting of psl_fir_cntl from debug to production
> environment recommended value. It mostly affects the PSL behavior when
> an error is raised in psl_fir1/2.
>
> Tested with cxlflash.

Is this a fix you want in rc1, or something for 4.9 ?

cheers