Re: [PATCH] gpio: removes all usage of gpiochip_remove retval
Hi abdoulaye, On Fri, 30 May 2014 01:16:22 +0200 abdoulaye berthe wrote: > > The aim of this patch is to make gpiochip_remove() behavior consistent, > especially when issuing a remove request while the chipio chip is > still requested. A patch has been submitted to change the return value of > gpiochip_remove() from int to void. This one updates users of the return > value: Then you need to keep these two patch in a series with this one first to make sure that the other patch is not applied without this one. And you should add the above explanation to the changelog for this patch. -- Cheers, Stephen Rothwells...@canb.auug.org.au signature.asc Description: PGP signature ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH] gpio: removes all usage of gpiochip_remove retval
On Thu, May 29, 2014 at 11:54:52PM +0200, abdoulaye berthe wrote: > Signed-off-by: abdoulaye berthe Why? ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH] gpio: removes all usage of gpiochip_remove retval
Hi David, The aim of this patch is to make gpiochip_remove() behavior consistent, especially when issuing a remove request while the chipio chip is still requested. A patch has been submitted to change the return value of gpiochip_remove() from int to void. This one updates users of the return value: Cheers, Abdoulaye. On Fri, May 30, 2014 at 12:14 AM, David Daney wrote: > On 05/29/2014 02:54 PM, abdoulaye berthe wrote: > > Did you forget a changelog explaining why this is either needed, or even a > good idea? I joined the conversation late and don't know why you are doing > this. > > Thanks, > David Daney > > > > > Signed-off-by: abdoulaye berthe >> --- >> arch/arm/common/scoop.c| 10 ++ >> arch/mips/txx9/generic/setup.c | 4 ++-- >> arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c | 3 ++- >> arch/sh/boards/mach-x3proto/gpio.c | 6 ++ >> drivers/bcma/driver_gpio.c | 3 ++- >> drivers/gpio/gpio-74x164.c | 8 +++- >> drivers/gpio/gpio-adnp.c | 9 + >> drivers/gpio/gpio-adp5520.c| 8 +--- >> drivers/gpio/gpio-adp5588.c| 6 +- >> drivers/gpio/gpio-amd8111.c| 3 +-- >> drivers/gpio/gpio-arizona.c| 3 ++- >> drivers/gpio/gpio-cs5535.c | 8 +--- >> drivers/gpio/gpio-da9052.c | 3 ++- >> drivers/gpio/gpio-da9055.c | 3 ++- >> drivers/gpio/gpio-dwapb.c | 2 +- >> drivers/gpio/gpio-em.c | 5 + >> drivers/gpio/gpio-f7188x.c | 18 ++ >> drivers/gpio/gpio-generic.c| 3 ++- >> drivers/gpio/gpio-grgpio.c | 4 +--- >> drivers/gpio/gpio-ich.c| 9 + >> drivers/gpio/gpio-it8761e.c| 6 +- >> drivers/gpio/gpio-janz-ttl.c | 8 +--- >> drivers/gpio/gpio-kempld.c | 3 ++- >> drivers/gpio/gpio-lp3943.c | 3 ++- >> drivers/gpio/gpio-lynxpoint.c | 5 + >> drivers/gpio/gpio-max730x.c| 12 >> drivers/gpio/gpio-max732x.c| 7 +-- >> drivers/gpio/gpio-mc33880.c| 11 +++ >> drivers/gpio/gpio-mc9s08dz60.c | 3 ++- >> drivers/gpio/gpio-mcp23s08.c | 26 >> +++--- >> drivers/gpio/gpio-ml-ioh.c | 8 ++-- >> drivers/gpio/gpio-msm-v2.c | 5 + >> drivers/gpio/gpio-mxc.c| 2 +- >> drivers/gpio/gpio-octeon.c | 3 ++- >> drivers/gpio/gpio-palmas.c | 3 ++- >> drivers/gpio/gpio-pca953x.c| 7 +-- >> drivers/gpio/gpio-pcf857x.c| 4 +--- >> drivers/gpio/gpio-pch.c| 10 ++ >> drivers/gpio/gpio-rc5t583.c| 3 ++- >> drivers/gpio/gpio-rcar.c | 5 + >> drivers/gpio/gpio-rdc321x.c| 7 ++- >> drivers/gpio/gpio-sch.c| 16 +++- >> drivers/gpio/gpio-sch311x.c| 6 ++ >> drivers/gpio/gpio-sodaville.c | 4 +--- >> drivers/gpio/gpio-stmpe.c | 8 +--- >> drivers/gpio/gpio-sx150x.c | 7 ++- >> drivers/gpio/gpio-syscon.c | 3 ++- >> drivers/gpio/gpio-tb10x.c | 5 + >> drivers/gpio/gpio-tc3589x.c| 8 +--- >> drivers/gpio/gpio-timberdale.c | 5 + >> drivers/gpio/gpio-tps6586x.c | 3 ++- >> drivers/gpio/gpio-tps65910.c | 3 ++- >> drivers/gpio/gpio-tps65912.c | 3 ++- >> drivers/gpio/gpio-ts5500.c | 6 +++--- >> drivers/gpio/gpio-twl4030.c| 4 +--- >> drivers/gpio/gpio-twl6040.c| 3 ++- >> drivers/gpio/gpio-ucb1400.c| 2 +- >> drivers/gpio/gpio-viperboard.c | 10 +++--- >> drivers/gpio/gpio-vx855.c | 3 +-- >> drivers/gpio/gpio-wm831x.c | 3 ++- >> drivers/gpio/gpio-wm8350.c | 3 ++- >> drivers/gpio/gpio-wm8994.c | 3 ++- >> drivers/hid/hid-cp2112.c | 6 ++ >> drivers/input/keyboard/adp5588-keys.c | 4 +--- >> drivers/input/keyboard/adp5589-keys.c | 4 +--- >> drivers/input/touchscreen/ad7879.c | 10 +++--- >> drivers/leds/leds-pca9532.c| 10 ++ >> drivers/leds/leds-tca6507.c
Re: [PATCH] gpio: removes all usage of gpiochip_remove retval
On 05/29/2014 02:54 PM, abdoulaye berthe wrote: Did you forget a changelog explaining why this is either needed, or even a good idea? I joined the conversation late and don't know why you are doing this. Thanks, David Daney Signed-off-by: abdoulaye berthe --- arch/arm/common/scoop.c| 10 ++ arch/mips/txx9/generic/setup.c | 4 ++-- arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c | 3 ++- arch/sh/boards/mach-x3proto/gpio.c | 6 ++ drivers/bcma/driver_gpio.c | 3 ++- drivers/gpio/gpio-74x164.c | 8 +++- drivers/gpio/gpio-adnp.c | 9 + drivers/gpio/gpio-adp5520.c| 8 +--- drivers/gpio/gpio-adp5588.c| 6 +- drivers/gpio/gpio-amd8111.c| 3 +-- drivers/gpio/gpio-arizona.c| 3 ++- drivers/gpio/gpio-cs5535.c | 8 +--- drivers/gpio/gpio-da9052.c | 3 ++- drivers/gpio/gpio-da9055.c | 3 ++- drivers/gpio/gpio-dwapb.c | 2 +- drivers/gpio/gpio-em.c | 5 + drivers/gpio/gpio-f7188x.c | 18 ++ drivers/gpio/gpio-generic.c| 3 ++- drivers/gpio/gpio-grgpio.c | 4 +--- drivers/gpio/gpio-ich.c| 9 + drivers/gpio/gpio-it8761e.c| 6 +- drivers/gpio/gpio-janz-ttl.c | 8 +--- drivers/gpio/gpio-kempld.c | 3 ++- drivers/gpio/gpio-lp3943.c | 3 ++- drivers/gpio/gpio-lynxpoint.c | 5 + drivers/gpio/gpio-max730x.c| 12 drivers/gpio/gpio-max732x.c| 7 +-- drivers/gpio/gpio-mc33880.c| 11 +++ drivers/gpio/gpio-mc9s08dz60.c | 3 ++- drivers/gpio/gpio-mcp23s08.c | 26 +++--- drivers/gpio/gpio-ml-ioh.c | 8 ++-- drivers/gpio/gpio-msm-v2.c | 5 + drivers/gpio/gpio-mxc.c| 2 +- drivers/gpio/gpio-octeon.c | 3 ++- drivers/gpio/gpio-palmas.c | 3 ++- drivers/gpio/gpio-pca953x.c| 7 +-- drivers/gpio/gpio-pcf857x.c| 4 +--- drivers/gpio/gpio-pch.c| 10 ++ drivers/gpio/gpio-rc5t583.c| 3 ++- drivers/gpio/gpio-rcar.c | 5 + drivers/gpio/gpio-rdc321x.c| 7 ++- drivers/gpio/gpio-sch.c| 16 +++- drivers/gpio/gpio-sch311x.c| 6 ++ drivers/gpio/gpio-sodaville.c | 4 +--- drivers/gpio/gpio-stmpe.c | 8 +--- drivers/gpio/gpio-sx150x.c | 7 ++- drivers/gpio/gpio-syscon.c | 3 ++- drivers/gpio/gpio-tb10x.c | 5 + drivers/gpio/gpio-tc3589x.c| 8 +--- drivers/gpio/gpio-timberdale.c | 5 + drivers/gpio/gpio-tps6586x.c | 3 ++- drivers/gpio/gpio-tps65910.c | 3 ++- drivers/gpio/gpio-tps65912.c | 3 ++- drivers/gpio/gpio-ts5500.c | 6 +++--- drivers/gpio/gpio-twl4030.c| 4 +--- drivers/gpio/gpio-twl6040.c| 3 ++- drivers/gpio/gpio-ucb1400.c| 2 +- drivers/gpio/gpio-viperboard.c | 10 +++--- drivers/gpio/gpio-vx855.c | 3 +-- drivers/gpio/gpio-wm831x.c | 3 ++- drivers/gpio/gpio-wm8350.c | 3 ++- drivers/gpio/gpio-wm8994.c | 3 ++- drivers/hid/hid-cp2112.c | 6 ++ drivers/input/keyboard/adp5588-keys.c | 4 +--- drivers/input/keyboard/adp5589-keys.c | 4 +--- drivers/input/touchscreen/ad7879.c | 10 +++--- drivers/leds/leds-pca9532.c| 10 ++ drivers/leds/leds-tca6507.c| 7 ++- drivers/media/dvb-frontends/cxd2820r_core.c| 10 +++--- drivers/mfd/asic3.c| 3 ++- drivers/mfd/htc-i2cpld.c | 8 +--- drivers/mfd/sm501.c| 17 +++-- drivers/mfd/tc6393xb.c | 13 - drivers/mfd/ucb1x00-core.c | 8 ++-- drivers/pinctrl/pinctrl-abx500.c | 15 +++ drivers/pinctrl/pinctrl-adi2.c | 9 - drivers/pinctrl/pinctrl-as3722.c | 11 ++
